Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2996921pxb; Sun, 29 Aug 2021 09:50:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQNSyhBj1XjNQY9rlxyRZkOHQCWvqUARLYYa2aIX/xjBjoC/eQKpR9YbI5nqxJGvbYqSYI X-Received: by 2002:a05:6e02:1846:: with SMTP id b6mr14132899ilv.264.1630255832095; Sun, 29 Aug 2021 09:50:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630255832; cv=none; d=google.com; s=arc-20160816; b=jWZY4elFBhKlK0fIFIZVnzj7ASzpaycYMwU1P1ezNWj2E8eCUosf6t1YlI2j67ZSgN J+DD9Aw47hAyLMQovklIrKe1mP5rvy4mYG/DWaQRuPAV74p4GcVs1d1ckzLfToZqBovV PBPaWLpIxmvIFdMXy/jgrXqNY5g/eej/Uj3vG4ko0T4L1qGjUuLZzOVuc53xf5+/sNM3 vpuLkXnpeyjAgxS/jPZWoawchOpvCwtFbJ6L263lV1nmL9Bu/hF2O9cYAVYT2avlWp5b EXncxx7uyuKihs4MbUesOff23EtcV+ND1nWf/b8MJuMB4M9g8h1lkMzkmYu9UbbaO22G Q3nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=2ff+10G4Dt6XXoNpjZ+1qlAIxYbBmewJrQRU+zrTaMM=; b=TDH5vcqX3DPVOJngvAeCovirBiBxB/3Vs/L+42Pee7Xgz4bx6INPC4I+qtQ1VtrBHd Dd6FVMyEYA0Jewm5+Q3ft76EP1muQhW5qGbMjuMLx55kpX91i1+lXkHyFRh+413cCjpY a32NNYveDi/dsV6U86VunJ0jAsrehSngCKEQJ9k6syNVyRghZGBNVsvqM8h5CVT7JuMt qKR14AASxRIbtzxetb+2naiK2e7pkoWnCbYggMMlmLPXlrNbrrz0HiBDqeToSM2/wEbi vEPPD63LTzMfMBB79lSPfDMFn1mKuWLrkcSyzDvdu62Au4oTA9E29/U0ExGPjaG0iXdC fMYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bryanbrattlof.com header.s=protonmail header.b="ds5M/OHk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bryanbrattlof.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si12522894ile.20.2021.08.29.09.50.20; Sun, 29 Aug 2021 09:50:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bryanbrattlof.com header.s=protonmail header.b="ds5M/OHk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bryanbrattlof.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbhH2Que (ORCPT + 99 others); Sun, 29 Aug 2021 12:50:34 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:19311 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbhH2Que (ORCPT ); Sun, 29 Aug 2021 12:50:34 -0400 Date: Sun, 29 Aug 2021 16:49:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bryanbrattlof.com; s=protonmail; t=1630255780; bh=2ff+10G4Dt6XXoNpjZ+1qlAIxYbBmewJrQRU+zrTaMM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=ds5M/OHkjvRmXC+YKe3MbnlIvxCbNG/SyqbVp7UmhAc5iTIdfHl6sguKo+1p/fu8w JXYlMZRVcjcjk68IhLoxf8uVZR2m5UQ4N+PXnSC2UHcE1YHDlkZZmhOtkZxfunF1go 3ax48pTGL2F2WhtscwoyEx/koTs+TE0rg4Jo1C5BfQLkIRNRPC918Ewbg+i/qEJgYT mO4U6H4wNytuS8QFqLm0irovV6fOB10Z0SGaOIjG7FeYHJDWG7jTreHFVKZeJ59qg3 OhuWJFWwIey5Wk7exoSh2KmTlzm+8ZnHJjUlqAObP/KcSDd6oDE8bTVXsIHhmwza0S 0t2z6jco/pWHA== To: Krish Jain From: Bryan Brattlof Cc: Greg KH , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Reply-To: Bryan Brattlof Subject: Re: [PATCH] Declare the file_operations struct as const Message-ID: <20210829164921.u5ntqk5jz2v3hlgr@h510> In-Reply-To: References: <20210829144531.c2syu4vv4s22dlg7@h510> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On this day, August 29, 2021, thus sayeth Krish Jain: > > > > > > Hi, what option do you mean? I already ran make allmodconfig and sud= o > > > make modules_install install and then make "CCFLAGS=3D-Werror W=3D1 > > > M=3Ddrivers/staging/android/" and now I do get output but one line > > > "WARNING: Symbol version dump "Module.symvers" is missing. Modules ma= y > > > not have dependencies or modversions. You may get many unresolved > > > symbol warnings." . Then I tried "make CCFLAGS=3D-Werror V=3D1 > > > M=3Ddrivers/staging/android/" and that outputted the following: > > > > > > > Most of the answers you're asking for are going to get vague responses > > (if any) on the mailing lists. The idea being (and I agree with) that > > giving out the answers will steal your opportunity to explore and learn > > the material yourself. > > > > Yes, it would be faster if we told you the answer, but ultimately, we > > would be doing a disservice to you. > > > > Besides, more times than not we (me especially) don't have the answer. > > > > With that said, I will give a (generous) hint. :) > > > > Hi. Do I have to build the kernel once before this works? Or can I > just build a module directly? > Again, do not allow others to rob you of learning how to solve these issues yourself. I *strongly* encourage you to familiarize yourself with the Kernel Build System in the Documentation. https://www.kernel.org/doc/html/latest/kbuild/modules.html Specifically the first paragraph of "2. How to Build External Modules" It may seem like a lot for such a simple issue but it *is* worth it. ~Bryan