Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 29 Aug 2021 18:14:31 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Alexandru Ardelean <ardeleanalex@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        angelo.compagnucci@gmail.com,
        linux-iio <linux-iio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: adc128s052: Fix the error handling path of
 'adc128_probe()'
Message-ID: <20210829181431.67a52d36@jic23-huawei>
In-Reply-To: <f33069f0-601b-4bbb-3766-026f7a161912@wanadoo.fr>
References: <85189f1cfcf6f5f7b42d8730966f2a074b07b5f5.1629542160.git.christophe.jaillet@wanadoo.fr>
        <CA+U=DsoTdb3b+LJEtUagKr=LmK8E2M_2yhtNDENKsczqGaUPYA@mail.gmail.com>
        <f33069f0-601b-4bbb-3766-026f7a161912@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, 24 Aug 2021 21:45:38 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Le 23/08/2021 à 08:42, Alexandru Ardelean a écrit :
> > On Sat, Aug 21, 2021 at 1:43 PM Christophe JAILLET
> > <christophe.jaillet@wanadoo.fr> wrote:  
> >>
> >> A successful 'regulator_enable()' call should be balanced by a
> >> corresponding 'regulator_disable()' call in the error handling path of the
> >> probe, as already done in the remove function.
> >>
> >> Update the error handling path accordingly.  
> > 
> > Good catch.
> > For the fix:
> > 
> > Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Applied and marked for stable.

Thanks,
> > 
> > If you want, you can also send a conversion to
> > devm_iio_device_register() for this driver.
> > And also move the regulator_disable() on a devm_add_action_or_reset() callback.
> > Maybe, that's already part of your plan. If so, apologies for the noise :)
> >   
> 
> Hi,
> 
> I hadn't planned another step but I can send a follow-up patch for that.
> 
> CJ

Note I'll have to sit on that one until this patch is upstream which will be a few weeks
(perhaps a month) given timing.

Jonathan