Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Aug 2021 09:17:27 +0900
From:   Stafford Horne <shorne@gmail.com>
To:     Joel Stanley <joel@jms.id.au>
Cc:     openrisc@lists.librecores.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] openrisc/litex: Add liteeth support
Message-ID: <YSwjlzegL+cKt1hg@antec>
References: <20210826132946.3324593-1-joel@jms.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210826132946.3324593-1-joel@jms.id.au>
Precedence: bulk

On Thu, Aug 26, 2021 at 10:59:43PM +0930, Joel Stanley wrote:
> Hello Stafford,
> 
> Here are some changes so that the openrisc kernel can boot with ethernet
> support with the in-tree device tree.
> 
> I have also updated the address of the serial device to match recent
> litex. I realise this may keep changing, but it does make it easier to
> test upstream kernels if the basics work.
> 
> Joel Stanley (3):
>   openrisc/litex: Update uart address
>   openrisc/litex: Add ethernet device
>   openrisc/litex: Update defconfig
> 
>  arch/openrisc/boot/dts/or1klitex.dts      | 13 ++++++++++--
>  arch/openrisc/configs/or1klitex_defconfig | 26 ++++++++++++++---------
>  2 files changed, 27 insertions(+), 12 deletions(-)

Hi,

These all look fine to me.  Note, I have just using the autogenerated .dts file
created by the litex build, so I don't usually use this one other than for some
basic testing.  I know auto generated one has it's quirks but it does work.

It's good to have these here though.

I will queue these after the ehternet driver is queued.  Are you planning me to
queue the ethernet driver?  Or will someone else be taking that in?

-Stafford