Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3225782pxb; Sun, 29 Aug 2021 18:26:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu7ATW2h6ma9A5CRq16PPYNgGk+dvaDmnWtsj4DUexwcbr+61Rtfp9XItsyNsNkk/fdABd X-Received: by 2002:aa7:dd93:: with SMTP id g19mr21467071edv.262.1630286785820; Sun, 29 Aug 2021 18:26:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630286785; cv=none; d=google.com; s=arc-20160816; b=PA/A083rG2HAvZsYzNYV80ENTkJPkZ3EVm/ylcrAz/ta0/nKLTbiUA23E5ShdMgp45 HaQJyS2HmsxkeHKtE2EERgnO3HWujsecW4//wT5HtI2UqdkxKIwL7bmBhF6+ufSUHHDZ 3Gss8v+uQyZz280UhnojfxsnfOW35fewHv/ey0Qx3bKoDWxIGBieQXIV1L7xwOoslW+G qfyUkwcv86Nq3kKAXzNTetscvd+t08ZMbN35K7WGN412UofaJRpp6t8eCnKCK+oku0qJ ppge0hs0LZGvhiFK6YegM6LilBv9xpeWbvzugPfhsmgqho7z39fNr7xyQOZVZSCw/aOl gzOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=HvzsnmetZNYOSiaYiOwvWVr9wuAJ+4MXrvpH+NTdyIg=; b=tKxEhYXnC3bHhbnts3+6Be3kTvlid09193JrctT+Dra8Ed2kHQ4WYAp6GQR+9aoGxC FZD8CoSBizchPb5QEdpGV9eOKIWrmNRH9Kvn4CrwgN9h6w1ZraCwzuZVI8NI4C/Zbvn1 Fz7q8Rnhzx2cNLDs73PisAC6YRqbMbXuAZFiLo/hts2gvIw3rcn/Px2iDlrA2/w1NFDy eNXYl7cKAFe+mmAOVNP3MLsbrTjdHT1f6r+UZGMC+hofpwy5LTZkStO8H6hPHhuN5KLc oASCihg0VPBbtj/laPjH0Pt1Ah8H6g9fruLMxI3qK5pj1GYwKNiTrGoJj88nLBQZXhH5 IUkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si13098102edr.509.2021.08.29.18.26.02; Sun, 29 Aug 2021 18:26:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236130AbhH3BZk (ORCPT + 99 others); Sun, 29 Aug 2021 21:25:40 -0400 Received: from smtpbg702.qq.com ([203.205.195.102]:38322 "EHLO smtpproxy21.qq.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231401AbhH3BZi (ORCPT ); Sun, 29 Aug 2021 21:25:38 -0400 X-QQ-mid: bizesmtp46t1630286661to8pa6p1 Received: from localhost.localdomain (unknown [111.207.172.18]) by esmtp6.qq.com (ESMTP) with id ; Mon, 30 Aug 2021 09:24:19 +0800 (CST) X-QQ-SSF: 0140000000200070D000B00A0000000 X-QQ-FEAT: KrMf3JMLLXNBGie6cqgwm5UBDY6dT7nckKLs6yVHyn3GdTx38fmsxejuRm+3k M9rvrjyNm5KqW/wPxPyXsLogH7t1UO3fkkB8ieChemlDysJ7aV9kY9w+G3ClZ1aR8H80oIx 0PjrlkrKNuwQncKD+CHr4yaX76wodH3CV3JNoVGeeWSalyrWjCimlbhhix8VJ8kaceU4Dsr VwDnEo9x5aATgfBBsEOVhslZLPO34dwSrYaDNgxWErKreXLSn02NuOsFDZpJyAias7i9JXK 3DTlVS2NkLX+8FqUZu3BzDx4DdZMBZHN++Tvl2FJQX7Ml7MP8JIGCF/jzlwXgNuK31tRrac JiAsWjJhrqnKMCA1pk= X-QQ-GoodBg: 2 From: zhaoxiao To: davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zhaoxiao Subject: [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() Date: Mon, 30 Aug 2021 09:24:17 +0800 Message-Id: <20210830012417.14872-1-zhaoxiao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign2 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change the pr_info to dev_err. Signed-off-by: zhaoxiao --- v2: Remove the adding a return. drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index 4c9a37dd0d3f..abcb55f87579 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -54,14 +54,13 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id bool mdio = false; np = dev_of_node(&pdev->dev); - if (!np) { - pr_info("dwmac_loongson_pci: No OF node\n"); + dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n"); return -ENODEV; } if (!of_device_is_compatible(np, "loongson, pci-gmac")) { - pr_info("dwmac_loongson_pci: Incompatible OF node\n"); + dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n"); return -ENODEV; } @@ -69,6 +68,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id if (!plat) return -ENOMEM; + if (plat->mdio_node) { dev_err(&pdev->dev, "Found MDIO subnode\n"); mdio = true; @@ -111,6 +111,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id phy_mode = device_get_phy_mode(&pdev->dev); if (phy_mode < 0) dev_err(&pdev->dev, "phy_mode not found\n"); + plat->phy_interface = phy_mode; plat->interface = PHY_INTERFACE_MODE_GMII; -- 2.20.1