Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210826132946.3324593-1-joel@jms.id.au> <YSwjlzegL+cKt1hg@antec>
In-Reply-To: <YSwjlzegL+cKt1hg@antec>
From:   Joel Stanley <joel@jms.id.au>
Date:   Mon, 30 Aug 2021 01:41:26 +0000
Message-ID: <CACPK8XdzpSpz_iswn7ojE1TbXpYFqG2orALSvJP7piq=UC0xDg@mail.gmail.com>
Subject: Re: [PATCH 0/3] openrisc/litex: Add liteeth support
To:     Stafford Horne <shorne@gmail.com>
Cc:     openrisc@lists.librecores.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 30 Aug 2021 at 00:17, Stafford Horne <shorne@gmail.com> wrote:
>
> On Thu, Aug 26, 2021 at 10:59:43PM +0930, Joel Stanley wrote:
> > Hello Stafford,
> >
> > Here are some changes so that the openrisc kernel can boot with ethernet
> > support with the in-tree device tree.
> >
> > I have also updated the address of the serial device to match recent
> > litex. I realise this may keep changing, but it does make it easier to
> > test upstream kernels if the basics work.
> >
> > Joel Stanley (3):
> >   openrisc/litex: Update uart address
> >   openrisc/litex: Add ethernet device
> >   openrisc/litex: Update defconfig
> >
> >  arch/openrisc/boot/dts/or1klitex.dts      | 13 ++++++++++--
> >  arch/openrisc/configs/or1klitex_defconfig | 26 ++++++++++++++---------
> >  2 files changed, 27 insertions(+), 12 deletions(-)
>
> Hi,
>
> These all look fine to me.  Note, I have just using the autogenerated .dts file
> created by the litex build, so I don't usually use this one other than for some
> basic testing.  I know auto generated one has it's quirks but it does work.
>
> It's good to have these here though.

Agreed.

The auto generated ones need a lot of work to be relevant outside of
the vexriscv CPU (I tried to build for rocket, a different riscv, and
the script blew up...).

In the future it would be good to have this one support the drivers
that are merged upstream.

>
> I will queue these after the ehternet driver is queued.  Are you planning me to
> queue the ethernet driver?  Or will someone else be taking that in?

I should have mentioned that the driver and bindings were merged
through the network tree last week. You can see them in Friday's
linux-next.

Cheers,

Joel

---------- Forwarded message ---------
From: <patchwork-bot+netdevbpf@kernel.org>
Date: Thu, 26 Aug 2021 at 11:30
Subject: Re: [PATCH v4 0/2] net: Add LiteETH network driver
To: Joel Stanley <joel@jms.id.au>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <robh+dt@kernel.org>,
<kgugala@antmicro.com>, <mholenko@antmicro.com>,
<devicetree@vger.kernel.org>, <florent@enjoy-digital.fr>,
<gsomlo@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>


Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Thu, 26 Aug 2021 07:51:04 +0930 you wrote:
> This adds a driver for the LiteX network device, LiteEth.
>
> v4 Fixes the bindings and adds r-b tags from Gabriel and Rob.
>
> v3 Updates the bindings to describe the slots in a way that makes more
> sense for the hardware, instead of trying to fit some existing
> properties. The driver is updated to use these bindings, and fix some
> issues pointed out by Gabriel.
>
> [...]

Here is the summary with links:
  - [v4,1/2] dt-bindings: net: Add bindings for LiteETH
    https://git.kernel.org/netdev/net-next/c/b0f8d3077f8f
  - [v4,2/2] net: Add driver for LiteX's LiteETH network interface
    https://git.kernel.org/netdev/net-next/c/ee7da21ac4c3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


>
> -Stafford