Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anup Patel <anup.patel@wdc.com>
To:     Palmer Dabbelt <palmer@dabbelt.com>,
        Palmer Dabbelt <palmerdabbelt@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Atish Patra <atish.patra@wdc.com>,
        Alistair Francis <Alistair.Francis@wdc.com>,
        Anup Patel <anup@brainfault.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Anup Patel <anup.patel@wdc.com>
Subject: [RFC PATCH v3 06/11] dt-bindings: timer: Update SiFive CLINT bindings for IPI support
Date:   Mon, 30 Aug 2021 09:47:24 +0530
Message-Id: <20210830041729.237252-7-anup.patel@wdc.com>
In-Reply-To: <20210830041729.237252-1-anup.patel@wdc.com>
References: <20210830041729.237252-1-anup.patel@wdc.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from wdc.com (122.179.63.14) by MA1PR0101CA0002.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:21::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Mon, 30 Aug 2021 04:18:15 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7b9bd03-85e4-4786-a1ee-08d96b6d3279
X-MS-TrafficTypeDiagnostic: SJ0PR04MB7870:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SJ0PR04MB7870AF79873234FEE646532A8DCB9@SJ0PR04MB7870.namprd04.prod.outlook.com>
WDCIPOUTBOUND: EOP-TRUE
X-MS-Oob-TLC-OOBClassifiers: OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: IAgKJ7wU4VlmmdHmct2SZ4ilH8/6didw6qyPTWNiidaKVSWKZI+IJ8Z25KzFemD2uTnRqptZ78uJE7X82rj0in5cG0/rAHxOJxJfmsqxwE+ROofDClRxbQLDMQd709txau3IGhAe+aD8he+LYSi7ZqjkKX+0xzNU/5FawvX8U/BU1jwhmHM8MXhdpL5o9pOuEp6BekBqCEAfXguBffnUjBOOygxq3s4fxZVhDdnZB62QMclp+rf1p4raxHjo+TfEJJ5KVo0L7kgbxC+8byX1wj3c5RbbRliHhSE2d1u3fH/07bjunYukFa2OHDdMm0dXyqpZj5fwHLHacH+mwcnk61NBjLnwuKDalQe7Xtuh2MCDwgZeDRRMWWvMyr9emwlqTXC1bSnxHewFLfIi1RFW9A4wBCOVIlw4iVmKf9xVdidI046EyMi3n0loDMSOkcOFhTj4uljoRNQOIxReisHppmttWO2yAByzdMFj60DGv49IoMEduRyo2zDYAs+LNuUPR+LajYXMBV0OhL6p6mLAqSNvbYEWp8ZkJyQXJB/dh2rQRSlR0CIkomfSSr/2R1qshb7sJGlfwh4b/Afc9vF3nXSvVgGJjXrurvpEfwos7nh8YL659twuRObMNoD9hZzF/NqMAubqkbDok1bhQcwRgXnLKRdEnpyvFCnSMzLtEsnX9QESJOIezF1Mkrt1q18eqQV9y5Ecibti4z2H2M5hnYVeIoZpseeV5EF1yO2Kr3o=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR04MB7821.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(376002)(346002)(396003)(366004)(136003)(55016002)(110136005)(66556008)(66476007)(54906003)(8936002)(7696005)(52116002)(956004)(316002)(66946007)(2616005)(44832011)(8676002)(6666004)(2906002)(8886007)(83380400001)(5660300002)(186003)(86362001)(478600001)(7416002)(4326008)(38350700002)(38100700002)(26005)(36756003)(1076003)(473944003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aIkr+qo01DZPhMi3IKpD1uoZtSSbnepa4vqpQctoEVHuLs1eUbQPGAmDvyPE?=
 =?us-ascii?Q?D9Wga/OKpNqCG4mEo5e1s3TZdW9GrFT8+R/4uh4+RlshiBChpSu4RQ843rUF?=
 =?us-ascii?Q?TU4nOLT6+wjNkK+RA7pDR7UdktUTRRRCnu+PkGgSoyrsv7SMJxCSJfB7wbpV?=
 =?us-ascii?Q?dLp6Hd8llU0N3Yoyh5dl078QOtLFxPKuxFx0OoKTS7+2Szd6QEBdkoryLceC?=
 =?us-ascii?Q?rSIslMV88jOoT3xjT2Ujnt0emflh/oh7MRNQEeaMt29oPO4ux+71gdVUfTH0?=
 =?us-ascii?Q?JYK4I8FRTsL0SaeY4wTrSz+sYK+fV53tCg/cTtSVF4fNI+YS07OnoWihJ19m?=
 =?us-ascii?Q?G4WiOyMlq3h2Ts9Bc6IH6JXB9/XAf/2LNaJGAEZfTVmhITYnoceN+C8qr9ma?=
 =?us-ascii?Q?l4KofxyRfDukvIz4GS0FqOD3aErzDsf99udSfMmtGfKAerpZ1+9RirPSejwx?=
 =?us-ascii?Q?596c6f/etnCGiWlqcR8Gi8aFHKtkR9aHuVt7ftauADOQHTpG01EP+5tc9jox?=
 =?us-ascii?Q?VM2QTsFaPggRs2sVdO0Ur9qvROHUd3x7Lq/bB1MelLgyWXDGXBTTDe5ByuIO?=
 =?us-ascii?Q?UlIIbQxzrz3LbRdnXYnSfOip3PZOkxkTObeozj+Vh6glY9yJuIxNHx2/R5l0?=
 =?us-ascii?Q?uN4smlQpdbkM54fMU8qghLgtIcVbqyYde4ovPmPGbiHOcC55MHPficBLVQ/l?=
 =?us-ascii?Q?ZSiBHX1893gyGytgEpaui2n2QtVTNN5jAc+Gso1vNKX2gKxDOR1uLZiEYJHJ?=
 =?us-ascii?Q?E26s1HkIWhgnxbylVFhcExZYD845E7vrEwIMUY/2fEjMnjv6rl7Tk0FQiNre?=
 =?us-ascii?Q?Ugywy+6ZVDLDSUrm6+Fb0u8h/1x62FXPfvzZXH5FWRCW7yenbZk2M5tk0oky?=
 =?us-ascii?Q?bsexPxx2gJRoykQ6KXFl1BokZoHS0oQ1jKvjBbmjr5Lm9BotuOFI+JdVoNuH?=
 =?us-ascii?Q?yH5Ao5icm+RRpCz1PD4CgqE9JDKsV7Bjup6DuM1Onvm5H0ZPFS+MzgvGst5d?=
 =?us-ascii?Q?aH6mevLWYMKcvdAw2gO1Q/qPi1RMcR41U+AkUS4ifCRlr1dBEZS2ltsg9elG?=
 =?us-ascii?Q?pOFDkmW4xm386uPUzwSRLRrpcHXmoSVfQEfRqrkn77V2XLQxam/PkZmXVTZK?=
 =?us-ascii?Q?33EIkEunjmdjfLL/zEWGuKvKwPL+bhPQF+HAR2fvQfx2dC2OD+g0lZSEbIYJ?=
 =?us-ascii?Q?ZswiHzRXygHmvEFVs2FKMKHPMHkZPEVw5bj7zZ33smkDGpbG2g9X8OOOOEds?=
 =?us-ascii?Q?uZeQ6zNWSSJUFlLw0Q9+/1dWY7mleAX6m/eOwthsF8N34CqPd9bSFqi806Ct?=
 =?us-ascii?Q?QQCxSOkvf0jwmZZmkZh/2z55?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7b9bd03-85e4-4786-a1ee-08d96b6d3279
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB7821.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 04:18:19.5380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9AgkEjRa9J5qdJiLGarNYsgnygSbDaMGImKtKQO0uVUzZEMYOZJlOPuI+evPdN7RjBYCK732m18L44ZemlrzGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7870
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Linux RISC-V now treats IPIs as regular per-CPU IRQs. This means
we have to create a IPI interrupt domain to use CLINT IPI functionality
hence requiring a "interrupt-controller" and "#interrupt-cells" DT
property in CLINT DT nodes.

Impact of this CLINT DT bindings change only affects Linux RISC-V
NoMMU kernel and has no effect of existing M-mode runtime firmwares
(i.e. OpenSBI).

Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
 .../bindings/timer/sifive,clint.yaml          | 20 ++++++++++++++-----
 arch/riscv/boot/dts/canaan/k210.dtsi          |  2 ++
 .../boot/dts/microchip/microchip-mpfs.dtsi    |  2 ++
 3 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
index a35952f48742..9c8ef9f4094f 100644
--- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
+++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
@@ -43,6 +43,12 @@ properties:
 
   interrupts-extended:
     minItems: 1
+    maxItems: 4095
+
+  "#interrupt-cells":
+    const: 0
+
+  interrupt-controller: true
 
 additionalProperties: false
 
@@ -50,15 +56,19 @@ required:
   - compatible
   - reg
   - interrupts-extended
+  - interrupt-controller
+  - "#interrupt-cells"
 
 examples:
   - |
     timer@2000000 {
       compatible = "sifive,fu540-c000-clint", "sifive,clint0";
-      interrupts-extended = <&cpu1intc 3 &cpu1intc 7
-                             &cpu2intc 3 &cpu2intc 7
-                             &cpu3intc 3 &cpu3intc 7
-                             &cpu4intc 3 &cpu4intc 7>;
-       reg = <0x2000000 0x10000>;
+      interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>,
+                            <&cpu2intc 3>, <&cpu2intc 7>,
+                            <&cpu3intc 3>, <&cpu3intc 7>,
+                            <&cpu4intc 3>, <&cpu4intc 7>;
+      reg = <0x2000000 0x10000>;
+      interrupt-controller;
+      #interrupt-cells = <0>;
     };
 ...
diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi
index 5e8ca8142482..67dcda1efadb 100644
--- a/arch/riscv/boot/dts/canaan/k210.dtsi
+++ b/arch/riscv/boot/dts/canaan/k210.dtsi
@@ -105,6 +105,8 @@ clint0: timer@2000000 {
 			reg = <0x2000000 0xC000>;
 			interrupts-extended = <&cpu0_intc 3 &cpu0_intc 7
 					      &cpu1_intc 3 &cpu1_intc 7>;
+			#interrupt-cells = <0>;
+			interrupt-controller;
 		};
 
 		plic0: interrupt-controller@c000000 {
diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index b9819570a7d1..67fb41439f20 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -168,6 +168,8 @@ &cpu1_intc 3 &cpu1_intc 7
 						&cpu2_intc 3 &cpu2_intc 7
 						&cpu3_intc 3 &cpu3_intc 7
 						&cpu4_intc 3 &cpu4_intc 7>;
+			#interrupt-cells = <0>;
+			interrupt-controller;
 		};
 
 		plic: interrupt-controller@c000000 {
-- 
2.25.1