Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3334279pxb; Sun, 29 Aug 2021 22:31:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZvGGUx6dx9SrKXnmJPftRB8R6bAquKbh6i5M25gEBnP4el+Xdwcm1qCkO10RFY3gOQZf/ X-Received: by 2002:a92:cb4b:: with SMTP id f11mr15193562ilq.189.1630301515533; Sun, 29 Aug 2021 22:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630301515; cv=none; d=google.com; s=arc-20160816; b=I4O50nhf60hLGo0yM5Xsz3gBjp9rPWdGidtuyKcv/8OjYsFnv0sJCXXTLqMKQLVAdM rSozEGFDbhT67CjUSrg7a4pUz8elA30tCuQZXBccsYkPWs+fWXdRHXUsVCGxzpahNV3d u1yr09rY86mvyOfxsx6bgWrdgiIJ889FmfO3Dv1W+pOAmDHpz9wUJHHp06CvTI47Bmy6 Efte4SnFRdDMt4rTze9M2qA6dGAJvroq14akjvWAYvBI6KtI6cs7HH79939myw8HVDby 9gb6zCr6NmJRZvnXJPiQiiA0imIV34myHlBC5nOeA9Nh7httLAvtp9gBwKFHW3ma7jxI evgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=PNU3clfbeVmDBrPqRckAK6yI5JGnGImupA3t/DmHunc=; b=DebNqSQTaLZ4OdNkK3PKn4DwsL7R0gHWV/mAMB+0yMZVPNh9xOxc0uut7mgRsWJMum iFtBweLl5J0pQZjDvMC/GW2k/JJwYsP+g/tsYqfCvIoeCatZho0E7mk0B+YO8dEEzJ9J x/oIRcdCZ7al9QUIgIedd5fpXZy9IQPMN3K7uAMtVH6P4n3khYkkzdtrpfQxKvmRPY9U MseTjCEeMi0wzIPgom5U9W4Dld/pdr1IWZQusWtSS+/fLj4ztF9/j0cimcGKJ4B2ro4z iXkU2AveCd2y+EBLlSb53Nz5b/zJgJgZrnqCJ2KCgcW5L1XEtTh8t2jEzxKAhyECZYGw Ylgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si10703377jac.26.2021.08.29.22.31.43; Sun, 29 Aug 2021 22:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230503AbhH3Fag (ORCPT + 99 others); Mon, 30 Aug 2021 01:30:36 -0400 Received: from smtpbguseast1.qq.com ([54.204.34.129]:44203 "EHLO smtpbguseast1.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbhH3Faf (ORCPT ); Mon, 30 Aug 2021 01:30:35 -0400 X-QQ-mid: bizesmtp54t1630301358tp73135x Received: from localhost.localdomain (unknown [111.207.172.18]) by esmtp6.qq.com (ESMTP) with id ; Mon, 30 Aug 2021 13:29:16 +0800 (CST) X-QQ-SSF: 0140000000200070D000B00B0000000 X-QQ-FEAT: vCa7dv7JIu7h/OEU73Iq3I8ZIIaeIJtLUZK6oCc7M8av+W9edfBIM+fI9M2GP A2WHJV1Iki6zZMV9pK/+OlCGsPC/ZgmXcg3zBjMkdM9nYjSA/vV0S28z9ElUcamn7iCEcb4 chSjGGNapd4NKOLkm/ctnvQwit9wnz3S55aKV1HLLnnyytYLu0gXZmL14YCEAJKAJFG4Gn7 bO2zPvAIXgBK7lmWalTzi7C9RWf/+q+oC9wcEnEDvxJYWv0HMcQgeISzM7ZpUcQqkVXslUw TQlGSvcmPnWZvIxJGx703rqDxfFkGjeLt2pFrJNmPMLE3euiairPYyxlBVrlstOx1rxO4Ra Aw8KpvUF6rA/Q6TH7IDpk+m/GkIWg== X-QQ-GoodBg: 2 From: zhaoxiao To: davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zhaoxiao Subject: [PATCH] stmmac: dwmac-loongson:add the return value Date: Mon, 30 Aug 2021 13:29:13 +0800 Message-Id: <20210830052913.12793-1-zhaoxiao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign2 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the return value when phy_mode < 0. Signed-off-by: zhaoxiao --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index 4c9a37dd0d3f..ecf759ee1c9f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -109,8 +109,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id plat->bus_id = pci_dev_id(pdev); phy_mode = device_get_phy_mode(&pdev->dev); - if (phy_mode < 0) + if (phy_mode < 0) { dev_err(&pdev->dev, "phy_mode not found\n"); + return phy_mode; + } plat->phy_interface = phy_mode; plat->interface = PHY_INTERFACE_MODE_GMII; -- 2.20.1