Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936957AbWLFRyJ (ORCPT ); Wed, 6 Dec 2006 12:54:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936958AbWLFRyJ (ORCPT ); Wed, 6 Dec 2006 12:54:09 -0500 Received: from smtp.osdl.org ([65.172.181.25]:49801 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936957AbWLFRyH (ORCPT ); Wed, 6 Dec 2006 12:54:07 -0500 Date: Wed, 6 Dec 2006 09:53:41 -0800 (PST) From: Linus Torvalds To: David Howells cc: Andrew Morton , "Maciej W. Rozycki" , Roland Dreier , Andy Fleming , Ben Collins , Linux Kernel Mailing List , Jeff Garzik Subject: Re: [PATCH] Export current_is_keventd() for libphy In-Reply-To: <21690.1165426993@redhat.com> Message-ID: References: <1165125055.5320.14.camel@gullible> <20061203011625.60268114.akpm@osdl.org> <20061205123958.497a7bd6.akpm@osdl.org> <6FD5FD7A-4CC2-481A-BC87-B869F045B347@freescale.com> <20061205132643.d16db23b.akpm@osdl.org> <20061205135753.9c3844f8.akpm@osdl.org> <20061206075729.b2b6aa52.akpm@osdl.org> <21690.1165426993@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 37 On Wed, 6 Dec 2006, David Howells wrote: > > + if (get_wq_data(work) == cwq > + && test_bit(WORK_STRUCT_PENDING, &work->management) > > I wonder if those can be combined, perhaps: Gcc should do it for us, afaik. I didn't check, but gcc is generally pretty good at combining logical operations like this, because it's very common. > Otherwise for i386 the compiler can't combine them because test_bit() is done > with inline asm. Nope. Look again. test_bit() with a constant number is done very much in C, and very much on purpose. _Exactly_ to allow the compiler to combine these kinds of things. > And: > > + if (!test_bit(WORK_STRUCT_PENDING, &work->management)) > > Should possibly be: > > + if (!work_pending(work)) Yeah, that's a worthy cleanup. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/