Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3469581pxb; Mon, 30 Aug 2021 03:05:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw88aLho3f+BQmqphHPkO5pcT5Xf8KhMxdWr2aX6/8RkoPYiFhes9nsfR1g2YHIqS+M1eXv X-Received: by 2002:a6b:b20c:: with SMTP id b12mr11177919iof.145.1630317952651; Mon, 30 Aug 2021 03:05:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630317952; cv=none; d=google.com; s=arc-20160816; b=FmCmqFqlhC6jBJMTh1QB25fDhkxSueGqaBH3ihGrpd0ij8E7W5QN1qQvdWj0GaXklp D7LabuWDb7enI/DN4f+MWWX/moBe63SE2K83C9rKskqPP/iOsd1CkphdPxfZBW0vzCL2 iCv+uBIj40/2H8EGgTEdWAdRUST87I2KReWKZn3YmT9+9jZOlKcEMh3QTfVcE9SMw1vg QhXuW/3Nri+6NdhOnSyklEr4VV+rguJDzz0Q2avJkxa8BAtUo17Y8AbUMUDsVo530khA s4X4WcPM2p0IzwAPPgG3A8SJL13kxunU4g+6LRm/vIROOqAkEVmlmOJh6Z0aLy3/DZ9p +b7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=/BZ9Nzbh36Uo0OVwK8BMQEKq6pKk8VDrZgnYLw2r5LY=; b=hFgbOg1njHQCVLl2mVFYM60ht90b4xEy7NHNHpTMgVJ+3ikfBcN3J1182YClHLvBcn EJhPymafqQDpiCy2dL0N/Lm+g7CBr+HB5O/urkPNUh4A9SpUMMTlLtEzeB31axWKNOiX DML4wHR8plDbTistaQ6HlnbIwuvyC9HTLxoFEvTRK237xgPSQrD1Pepw166OMBfj47p0 KbYa0sbEQoPOEnKSa171EG7YJ+YlWRfri0HBKAr7a6l/bVElugG3n/R7F4ENXQ51INB5 o21yqKpJdf6ucMXfIwHUxLgf6o5NbNNn8hxgBVBgigEdjZLwPyd2+YOB+12PPqr0vpeE UedQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=qeXtqhtr; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=w9mIVkZ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h30si11678412jaa.9.2021.08.30.03.05.41; Mon, 30 Aug 2021 03:05:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=qeXtqhtr; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=w9mIVkZ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236015AbhH3KFi (ORCPT + 99 others); Mon, 30 Aug 2021 06:05:38 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:40768 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbhH3KFh (ORCPT ); Mon, 30 Aug 2021 06:05:37 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9E4B91FDE9; Mon, 30 Aug 2021 10:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630317883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/BZ9Nzbh36Uo0OVwK8BMQEKq6pKk8VDrZgnYLw2r5LY=; b=qeXtqhtrEOPqMzRzjW9t+TL3jD98MhlIpYFJ14zcXaGcQZrNOZmLbncf5x17UL634db6rd 6zt9q/NPMSYigFoIOBBEtFa0LyjpNJEfDC3wxg+AhGcVnttMXNuBk0DB5nJTJSpQc7qhSG 2NSpDOIlgfXwxDOzxYehTIXjSfJcg7Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630317883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/BZ9Nzbh36Uo0OVwK8BMQEKq6pKk8VDrZgnYLw2r5LY=; b=w9mIVkZ+OuEEu+8qMvcwqgTG2QA7yK6/k+KJ8QRCp1byGlaAS0DamOhqqmcrWNh5Tdu/M9 7K5DA6/Cs8gmOmCg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8AAEA1365C; Mon, 30 Aug 2021 10:04:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id KnbNITutLGEdQAAAGKfGzw (envelope-from ); Mon, 30 Aug 2021 10:04:43 +0000 Date: Mon, 30 Aug 2021 12:04:43 +0200 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Hannes Reinecke , Keith Busch Subject: Re: [PATCH v1] nvme: avoid race in shutdown namespace removal Message-ID: <20210830100443.b2zkdp4l3vi2gz42@carbon.lan> References: <20210830093618.97657-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210830093618.97657-1-dwagner@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 11:36:18AM +0200, Daniel Wagner wrote: > Though one thing I am not really sure how it interacts with > nvme_init_ns_head() as we could be in running nvme_init_ns_head() > after we have set last_path = true. I haven't really figured > out yet what this would mean. Is this a real problem? I suspect it will regress the very thing 5396fdac56d8 ("nvme: fix refcounting imbalance when all paths are down") tried to fix.