Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Aug 2021 14:23:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kari Argillander <kari.argillander@gmail.com>
Cc:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        straube.linux@gmail.com, ross.schm.dev@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        saurav.girepunje@hotmail.com
Subject: Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree
Message-ID: <20210830112342.GF12231@kadam>
References: <YSu9GQa1A3s6FYQx@user>
 <20210829171351.u63zoaqa3x5qfodt@kari-VirtualBox>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210829171351.u63zoaqa3x5qfodt@kari-VirtualBox>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (62.8.83.99) by JNXP275CA0031.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 11:23:56 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a0f72c1-c3ff-48c3-6ff6-08d96ba8abf7
X-MS-TrafficTypeDiagnostic: CO1PR10MB4595:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4595D49A52C634CD5C5BFA728ECB9@CO1PR10MB4595.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: f3Tg6qj0OXXN2mCniPnhJmUso4VminXGiDvoJe8QdVgGTrLnX9X/JYA2kQ1ATG8rRoMzJe7hrOxPrl1iTquRk9TTCiNyS5d2aNSbUrECZrTAmOjVRPIA2f99zDjXz4gEdP9x+AIR3Do/hP2+Iu/EANFp6/v1vYH+p4kzs8KBNa4Ds1XZWY+x10HwI+2a46zGQ+2CEhoLq2v/eZDgro4EzDxqH79myP4xv/3baTqqwvsDdu4ymz783Rler8EvdAqrVVI+Hg3BmBstvuv5wATm+ICJuPo6eUGDX6tJfhDsdlQrsy7/rimMx+xHDyaShz0Ah1qiIrJvmTy30aTN0pbBZd4ZwOfGnhJWqJFv4/hzoWZuZ0pNuRyeSxIMfgzFdApsAkiVlOqed2H3ehH/LX9fp6klJeWgEoqUZXj2z3dDfy66rH6rF3F6QUhwC7KuDeyC8KoHKe9ct1t/JtLCOv0kCn+HDjAzkih8SXI5+h8seJiC1lJzy8eHL4ZjW+KE7p+rwRJE4pcmFO8ljvlSz4yokbPrj8HxG8Zol2oD0Cph69fXpZu7E0bQnV6IcoZVJFo50iPUb5x13XDUHiCHXcj1bOJECV4bwQM85UuOquBTAHxMp/jHq9PAu3egaaQQbiML1XS0AGr/Uyeoh1OwEPiC3zJ/yQ7vjQdz3QBw3VkDxkCz393Qi55GQ0m9QqwZh30RSsnUyU1GZVCu1LT/WYZuww==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(396003)(39860400002)(136003)(346002)(86362001)(7416002)(55016002)(6496006)(316002)(4744005)(8936002)(9686003)(478600001)(5660300002)(52116002)(4326008)(9576002)(66476007)(8676002)(186003)(6666004)(956004)(1076003)(66556008)(38100700002)(38350700002)(2906002)(66946007)(6916009)(33656002)(26005)(33716001)(44832011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+tkAELQzVGDNVbAt/aStFUGQBxwYY5yMWDolk2aX0kBqVryUGN7P0aMlkmS2?=
 =?us-ascii?Q?8/R0Mof+E3XMj0ru4D3rr3pkYWyheZuYANjr8YAJaj84Y+Ng9yAb9mfePvky?=
 =?us-ascii?Q?LsToFzz3h5ShuXPQxITU5QnNWYDUwztkEbpL9TtyWkcqkU6qJ3buWZYMj7ui?=
 =?us-ascii?Q?b/lobS7ar1W0AQ58BEUEOPvXmSD3bu5dce7w22/jedcrVLV9hTpbXg9xXCMX?=
 =?us-ascii?Q?0DQJa7dueBUXYJ9IcrHqXtmuxW8aMQbMwOvuLSm3mCuQhLdHup2SJ/uC18Et?=
 =?us-ascii?Q?P8Yg1fZQYUCsA60kssDRIbGo+qmBW0jsjsnuyEz3yOeyI5Ujs7TRoTiHHp+b?=
 =?us-ascii?Q?4JbCkek9o8fawMvD+c+JUFhPB5WNJZbirRhSuHEcfZybf1ksAuQ6KBtzafoE?=
 =?us-ascii?Q?zyR7QR20BpErlwiaY401K4AmEQpKNrAlb4PU3uZc9YD//kUV67z4XRW9+lMl?=
 =?us-ascii?Q?jLeCJ1lQTZy9hYlAgXJoyy9A4nVAs4YbQWQ3w2X99u6arXptSlk3KNceokmt?=
 =?us-ascii?Q?9Q6lQLLqWbbtJBZkfCaUlF/g7xs4Tr6V7j314dVbCH7KxNaqo4hkRsOhfcSj?=
 =?us-ascii?Q?/OW8F5U48sxwpxEOXiRxAQmHaNUBwO8RSPyoeQqNAmbBVTPFx0XHM0nrpA10?=
 =?us-ascii?Q?r2JbZyIYZA4sh/4UHB0GX4zskJ1c+ukBZhcNWByM516mQ2DxdoBPTCli7Ui5?=
 =?us-ascii?Q?TFGdF+sUe/uJQKqKdCDafx9Cw9Kr11sLQOTQqxCwaecvdllL0UVMx02tXDz9?=
 =?us-ascii?Q?2b2t1NoKo5G8TVyOmlJYk94MdhGOF3OfzX24ThQZuVDVO8F5j5+gKlUg+stK?=
 =?us-ascii?Q?+PAN79ZwNZRUbzSyFtMF6y5NCmN47vBXf6aTSbw7IgVwQnpxB3YUK68fXo7b?=
 =?us-ascii?Q?2qPE6Nm7qzv/1pJbJ7JeS/2gma60Ey4YjV0AFIzfWG7LnHneO18zzActcfJc?=
 =?us-ascii?Q?TgAvD+KHueYh2zN51vDPnAiuvQuOiU4WuG002NxjUxlMLgKTAKn6jyfd9K/3?=
 =?us-ascii?Q?gN1KL0zMnQAf+QLI7RyXYutsYQrtRW42I3jJ+3TtPL5q9vrdpoZ2zCF3SZDj?=
 =?us-ascii?Q?l8u0dV8yeGcmoVSYVdI2U4fbxHvHhQpSlz8Y7TM+R89OP/9a82bQFPFMlr0W?=
 =?us-ascii?Q?veMN0gJrJ15rrFLmTQjDNNFKQHvlBut5tNRkbG9/P9AnVQfR3SfLmc69XUXK?=
 =?us-ascii?Q?6HPYiZxC4imU58Ceju8mD163B7KBac7PtK4Bd04Z67FCGY8YEzSbIGzHZFUG?=
 =?us-ascii?Q?l0mmDvDNu2uxpTOFlyaaq7Y7VHuHRB2/e0jLSIfTap6ZefXwCd24bmj5gL6Z?=
 =?us-ascii?Q?33u2+UAoLOR2tULG2YrmfyAM?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a0f72c1-c3ff-48c3-6ff6-08d96ba8abf7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 11:24:03.5504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ybo2us8pJbFNsf97yyM4eGqACm+mwduTGrkjuPZL+vMeE8iswnZmTD9BGMHbDxdpejCNVREN3AkwJYqCuERcA21m2TvO7iEuFssH9nILmUo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4595
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10091 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108300082
X-Proofpoint-GUID: VF1rw7k3s23HyUAaDHEBEBm6JfswHlo0
X-Proofpoint-ORIG-GUID: VF1rw7k3s23HyUAaDHEBEBm6JfswHlo0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 29, 2021 at 08:13:51PM +0300, Kari Argillander wrote:
> On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> > Remove NULL check. NULL check before freeing function is not needed.
> > Correct the indentation.
> > 
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> > 
> > ChangeLog V4:
> > - Add Change log below --- line
> > 
> > ChangeLog V3:
> > - Add change log.
> > 
> > ChangeLog V2:
> > - Correct the indentation.
> 
> You need "---" here also.
> 

No.  It works fine.  I applied it myself with `git am` just to be 100%
sure in case I was missing something.

regards,
dan carpenter