Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3551646pxb; Mon, 30 Aug 2021 05:15:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHemK99DVWYsyFpsTzeMilLUHFgj/snBGbZsB/VWmib20wgqDcItWucm0V+9egc7Z9buP4 X-Received: by 2002:a05:6402:40ce:: with SMTP id z14mr5719883edb.28.1630325716087; Mon, 30 Aug 2021 05:15:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630325716; cv=none; d=google.com; s=arc-20160816; b=ZbSzPoMgbnUWH/TkU/30cgw6cQlxWSNw50FoQ9sgXcwkuKsb187TPGP5SXbTKiWM7N tM+OmIPPa+GToVMe87X1YI2PR5zwkiw/2qNaobDS8065hWHqaXianQfIkKAsrsvy6oWw 3Ii8TfBVFvHUASqpnz8ItLmNkOWDSoi8OM1e/Rg1rS1dwPpL0d6fzTdktizNXLd1+Mp8 INEtEXczBdIBfkE/seKMuKXaNex8p6J4hGA7HfUd/UjC03bfZAO4qPWv83xv0c3SaajJ bVxCIEevBOTLJnF6cVAARaQbCjoKcWk3kCufSTH6TF5zAqeu5SOMUDzF9O1hepMXwn2g UZXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=v05CHMGkNy/7iRKZsqcb072iAMcR/4Py4W7Z6a3AFlw=; b=bekWpY8OQDBxYjwVOCvBTpf1FlIBRdiE9DLQ0m7nWwhMr/GR1X2ceu9qIvdX6ZnNaj GNvZj+ReZK9/eqCK7wwnZyJjHO+ADYRA0n6V5Y8G/Sa17VGTdKnGMEqiXlVm937hEBzQ FoeX/zHzhn9qCHqA1DvzPTZPd8AdYCY2lybujh21/lokIIdrDTb5PpgtS/7/NNXP4bZo 2U6tKqU09EUvQjX3LGTZd9m3pIt07RC5JKngqgnJ7OwrzaWgjPvQWoEErVggnd/6LqoS JkjF0o5KX5Zsxg5pRE4h2pb/qLJVxZEa8w+xSQaBi6aj7SvcWe2UJ3uIxPOysoIixljC ilOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PRZsfWp4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si14485952edt.4.2021.08.30.05.14.33; Mon, 30 Aug 2021 05:15:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PRZsfWp4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237257AbhH3MKR (ORCPT + 99 others); Mon, 30 Aug 2021 08:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236582AbhH3MKR (ORCPT ); Mon, 30 Aug 2021 08:10:17 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65F88C061575 for ; Mon, 30 Aug 2021 05:09:23 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id j17-20020a05600c1c1100b002e754875260so9266419wms.4 for ; Mon, 30 Aug 2021 05:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=v05CHMGkNy/7iRKZsqcb072iAMcR/4Py4W7Z6a3AFlw=; b=PRZsfWp4uIvlMEd8zyEQdp3H+MRjz4psg405lNjW2xPYzAd7ITYSWIsTHWSpzEv+2v t/mnwGLByQblAhZXVo4OcTWDLMlY6tL/ajNMcy84H0Zd56W4aj8ddouXwuM8ScBwOTI4 wsNP2rUsSd+ef8fx9BZXIaWs0H0ndPKKuJXnjh2SpIg6hO6oH4UZhFoZe+R/T5Bs9EfP cw6RAzowgH+GbZqk2l7AkKSrI6wMjWlh72biVrbR1HcLT6tSh/v0ehDBpcAlZ0iD124C Sp0Xv/9Y1NsDqqXbWDilB4KmxK3A4IzuMKZnpEO6RiELM1BXLrWRfir4SjWFIBpUhpgN xt5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=v05CHMGkNy/7iRKZsqcb072iAMcR/4Py4W7Z6a3AFlw=; b=hufIcBPMtX7c6J/bQN2foelNyzmAAgTycM1w6/nxksonoMQWNqJmObMb293uCqn2ak 7GlHCVZqovmBXNeE88NRP0Y0g26gPm9HnqfikAOZ6V5tsBvELMv8kKz9q81W9FJ1BBDG eyLxQgYhuzOi7sp7VxBudMz9wBrhdjgsHSPFpfmqFM1r2pj+NAQlqtvkNBnKkomWUM45 7yzi9N+vnnL53mVuuAuiHR/SizW83tx5W2JoSkAL+UiqAItcueZKscHwuz4s/b55cSBP vfoOe1QAi/VdIYgadMA/zOoknBPtAaf9GB2oPs5R+KPPNChYe2Kewhdiyn2ou0SWjERi L6Jg== X-Gm-Message-State: AOAM533W231TaNxdjVvDDFzWmFWU4vSIrQUIjCf+UYHx7vIlMM5caq+v unc9JKXOllAi2YRRGqF959s= X-Received: by 2002:a05:600c:a4b:: with SMTP id c11mr21717493wmq.97.1630325362003; Mon, 30 Aug 2021 05:09:22 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::16fa? ([2a02:8108:96c0:3b88::16fa]) by smtp.gmail.com with UTF8SMTPSA id q13sm15116117wrv.79.2021.08.30.05.09.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Aug 2021 05:09:21 -0700 (PDT) Message-ID: Date: Mon, 30 Aug 2021 14:09:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree Content-Language: en-US To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Michael Straube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/21 19:00, Saurav Girepunje wrote: > Remove NULL check. NULL check before freeing function is not needed. > Correct the indentation. > > Signed-off-by: Saurav Girepunje > --- > Acked-by: Michael Straube Thanks, Michael