Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3558518pxb; Mon, 30 Aug 2021 05:24:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY3xSSCaq530IHl8fa6ROuuZRkQsJMcgfP9E+PVKLZxDPEiRlVB322lHAo5KNWVcw4+mg/ X-Received: by 2002:a05:6638:38d:: with SMTP id y13mr12763577jap.139.1630326281662; Mon, 30 Aug 2021 05:24:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630326281; cv=none; d=google.com; s=arc-20160816; b=d7NM9mkqfbfL2cuh9zzdA7efFiabkTxq8/AubFf9vvBA5xw1ziugBvarQi0EY+rJlx pGhbduBpGuSEl7EZRUDRzeHyTQ1KA51ES4oCL589YiUcwxUToXAY+tkldJ77DDiVZcAh soXoqncu27Lt5NJ242PWnURflmATbXhiOJQQ6+UtC4O5O9ByHi1XJBfWUV3ExzaVpx8p 4wnkBUx1677aLuFiQmyj6FKFCwVAzKMRph4kziJ1n9ef81MYyapiAgsNeH2hMnkiv0h2 iDKdmADPu9yBbF5+FlCvOSTMsQRzubBUbpeqOsBA+pVQTFSD590oBfQ1T6FjvWh2vyVm MwBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=8xAoIMEiwiEVsacLObSiOkPM+z18UgAjq/nEWRNlTaI=; b=C5dAx8e47ZLmnoyDqGBGTMYimbo2zLCR9rKN1sl5wSYxqFK6sggo5Z0vdxZnSw97rl KGXFW7iYvmYARWJgLCEVemV6ZxBOt3vK8JeDYm96QL3CP0noon1E8Cgi8Ue3bomRKCpu Dvnl5iqb10cmXKmesGVmblW2UxVj0lQtDCOApnJFIq3wBklBcoRdGvnSSs7Jch9kU/4u jlavMYllN5NmJSvVvm0W/f/YsmyHowmXBz4l4+K0hckm+zfTmaPOQanqNmNB04KvjzSM E9AahS4uX6ZYFi+26/BVpImxeXtek9WoxJ3ohJ2EhtDQvCqHBA+OIeX2q/p49m08Ck8d vHew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si16362300jak.6.2021.08.30.05.24.29; Mon, 30 Aug 2021 05:24:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231487AbhH3MYW (ORCPT + 99 others); Mon, 30 Aug 2021 08:24:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:60632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232442AbhH3MYV (ORCPT ); Mon, 30 Aug 2021 08:24:21 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC01E61154; Mon, 30 Aug 2021 12:23:24 +0000 (UTC) Date: Mon, 30 Aug 2021 13:26:36 +0100 From: Jonathan Cameron To: Eugen Hristev Cc: , , , , , , Subject: Re: [PATCH v2 00/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 Message-ID: <20210830132636.16dde030@jic23-huawei> In-Reply-To: <20210824115441.681253-1-eugen.hristev@microchip.com> References: <20210824115441.681253-1-eugen.hristev@microchip.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2021 14:54:31 +0300 Eugen Hristev wrote: > Hi, > > This series adds support for sama7g5. > > The sama7g5 is slightly different from sama5d2, but has the same basic > operations. The register map is a bit different, so, I added some primitives > to differentiate between the two classes of hardware blocks (sama5d2-sam9x60 > and sama7g5). > > Sama7g5 has 16 channels ADC, no resistive touch, and extra features > (FIFOs, better oversampling , not implemented yet). > > It is a rework of the series initially sent here: > https://marc.info/?l=linux-iio&m=161461656807826&w=2 > > I reworked this according to review by Jonathan, meaning that first I created > a no-op patch that will convert the driver to a more platform specific data > dedicated type of driver. This adds various structures that hold things like > register layout and channel information. > After this I created few patches that implement the main differences between > sama7g5 and older products: the end-of-conversion new register. I added > helper functions to make code more easy to read and more simple. > One the last patches adds the layout and channels for sama7g5. > At this moment in linux-next, the DT for sama7g5 and sama7g5ek is present, > and the last patches add and enable this node in DT for this board. > > Eugen 0-8 applied with the minor tweak mentioned in a reply to relevant patch. I'll assume 9-10 will got via normal soc related tree. Note that I'm queuing these up for the merge window after this one now (5.16). Thanks, Jonathan > > > > Eugen Hristev (10): > dt-bindings: iio: adc: at91-sama5d2: add compatible for sama7g5-adc > iio: adc: at91-sama5d2_adc: initialize hardware after clock is started > iio: adc: at91-sama5d2_adc: remove unused definition > iio: adc: at91-sama5d2_adc: convert to platform specific data > structures > iio: adc: at91-sama5d2-adc: add support for separate end of conversion > registers > iio: adc: at91-sama5d2_adc: add helper for COR register > iio: adc: at91-sama5d2_adc: add support for sama7g5 device > iio: adc: at91-sama5d2_adc: update copyright and authors information > ARM: dts: at91: sama7g5: add node for the ADC > ARM: dts: at91: sama7g5ek: enable ADC on the board > > .../bindings/iio/adc/atmel,sama5d2-adc.yaml | 1 + > arch/arm/boot/dts/at91-sama7g5ek.dts | 8 + > arch/arm/boot/dts/sama7g5.dtsi | 16 + > drivers/iio/adc/at91-sama5d2_adc.c | 586 ++++++++++++------ > 4 files changed, 425 insertions(+), 186 deletions(-) >