Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3662749pxb; Mon, 30 Aug 2021 07:45:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNMUo7Dctg9zU5LEJWjoet9ADZyAJ6CpRIiBp79zvDihsB1k+Uo+o5MIik/U4aoQb6veJQ X-Received: by 2002:a5d:9655:: with SMTP id d21mr18042854ios.111.1630334751287; Mon, 30 Aug 2021 07:45:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630334751; cv=none; d=google.com; s=arc-20160816; b=TE6sxywNXdvnrgn/MaSCRdj+QU4BNscpXyLdUeCM+RKdfSHgghyF+3CwGFyDZI5Olj 1uiYu/ffhP6q+GJWVToiQD2TaDOWY9g9xP1bV9Lo2B9a8GKLNknukTxtREn/6sNHPgiq 4/lLJP9tRV4lmO3sAuGi6yHLIpGzH+bdFT79K7s3O7t/50J7aKUzqfNLRKKzdlSHxX/I C2anbFrq8FuIN9XzUrK4OdTR55eAD3KH59RvrVSussZHzE62dfoI9IjB+RYMi9NfR05L 8I3KQlGwnzziEsNu8A65O9fsCd0sNVGRTmBy2PvIE2SnnGyEtwBi4qM+CkBTuiQIdIye dx0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2mUEVGaDHklyh6ZR9nxnq1+fJDzLMjt6bOsluGTQ+48=; b=SLMBBfIHHPoGIbk019XL8GTvL/HiWSEJPnxTLMOhreMNIFX07rx4i0NzKsHle9Xz9R PcukAy2dCid67uVJoQ8Xdvuepu4Ft2klTpenMJbGwrLm981sYM+6/UvzXud+C9o3Gs/n aqNI1rztbbCplUaMWixHpOherirQw+2/h8qHLcegUflNJW236NYuZ1X1bnrIIDeGG1Ms RGtKJQ5yDboxvfQhD4tILDZlvd1FX77xEdVeEgvtQqB5Sg0+aKLicwOoRIpO8Rk2To0B 8hMvlIwe0TYplnoHzFEg3FFXJvASFfrS2zKhi95M7tek7dJfjKOZjYIWUEnstOYqWoHb bFiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UGzIQPAn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q35si2880112jac.78.2021.08.30.07.45.39; Mon, 30 Aug 2021 07:45:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UGzIQPAn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237208AbhH3Oom (ORCPT + 99 others); Mon, 30 Aug 2021 10:44:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47001 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233798AbhH3Ooc (ORCPT ); Mon, 30 Aug 2021 10:44:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630334617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2mUEVGaDHklyh6ZR9nxnq1+fJDzLMjt6bOsluGTQ+48=; b=UGzIQPAnh7280ocXrO/hjh6qA0hO9J5gm/Gh/wIdut0cw2wgro3pcUQiniQI9eni+UtTEh Bfeaba8ukmjutVR4bHc8r3gL7TmuKjEF7oFYq4WNTOlVmj5SpZygg77HUwzGSgxP6sIlwX NdEz9omrLClBy8l/6CpqOPnXReqcMSo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-JHArCordPU6lSo82J9H1QA-1; Mon, 30 Aug 2021 10:43:36 -0400 X-MC-Unique: JHArCordPU6lSo82J9H1QA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 50D6587D558; Mon, 30 Aug 2021 14:43:35 +0000 (UTC) Received: from fedora-t480.redhat.com (unknown [10.39.192.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BC5E5DEB8; Mon, 30 Aug 2021 14:43:27 +0000 (UTC) From: Kate Hsuan To: Jens Axboe , Hans de Goede , Damien Le Moal Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Kate Hsuan Subject: [PATCH v3 0/1] libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung 860 and 870 SSD. Date: Mon, 30 Aug 2021 10:42:52 -0400 Message-Id: <20210830144253.289542-1-hpa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Many users reported the issue when running the system with Samsung 860, 870 SSD, and AMD chipset. Therefore, completely disabling the NCQ can avoid this issue. Entire disabling NCQ for Samsung 860/870 SSD will cause I/O performance drop. In this case, a flag ATA_HORKAGE_NONCQ_ON_AMD is introduced to used to perform an additional check for these SSDs. If it finds its parent ATA controller is AMD, the NCQ will be disabled. Otherwise, the NCQ is kept to enable. Changes since v3 * Modified the flag from ATA_HORKAGE_NONCQ_ON_ASMEDIA_AMD_MARVELL to ATA_HORKAGE_NONCQ_ON_AMD. * Modified and fixed the code to completely disable NCQ on AMD controller. Kate Hsuan (1): libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung 860 and 870 SSD. drivers/ata/libata-core.c | 24 ++++++++++++++++++++++-- include/linux/libata.h | 1 + 2 files changed, 23 insertions(+), 2 deletions(-) -- 2.31.1