Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3710503pxb; Mon, 30 Aug 2021 08:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiSO9jMcsAF/sOk4EQDQSnf0doZ4Zi/rdgCzOphyOkAPnGQxql56LMumftfJqt3431cfsj X-Received: by 2002:a17:906:3708:: with SMTP id d8mr26306758ejc.310.1630338754786; Mon, 30 Aug 2021 08:52:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630338754; cv=none; d=google.com; s=arc-20160816; b=V7mF1c/abgLAP2Iju/9nh4DxqFZ2FFtN+qxFFLRH2ra4C+Akxm0s64OEqiroqFCk59 Xm/wQ7M350irea+G57/rQqrLmQiiyj4IFuYVUAfvenkdiAPB0xwgUJjdyd2A6rgn2/DC xRULs1VLA5cvYsZZAz6fBMoXRGawynlCehm0LO4X+E+G+Ts5DAKBwieobSm6HqDAaq0u EfxSD3pxPzQvgv6Wi6vRfkSJPuYGlPpNx24VAsvsc9vWKqgbR/DNXa5DJt3WwXnXGZal 8E4vxGp0tN8x3LqYgJdmCJNx5xSj6cYNYs0QJfsRPFifOngVet4evYWL1+DrssihCpS/ ukoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=ceX1dMxIClr9YSJ/0dIk11Ssam9+xQ+XyrlF6BIEsAg=; b=kk2UIc6gRTy9DeZkniNG0IURYe2FGKMRpsknpPxWeuvQwr7id5mU1SnuW/hX9j/Vvd FJ0mY2E3R6kUUdlMqPeytp8tUDN5ijBk7inDyYyfsI/tCYltCw8dDBPJmvGY4KdxVhBl FJPoYtCJSQ1rWMe33wWtumEKGSea+KfVpTTsmX4gt4Jlc+aJYVz0voQ9jEimiETsBAof DgqCGMKkRdqEortDwV9O+uQtC61YkYbSraXHQrHoBxaqmGDd3bXBgF93/LORuPRyT+5r key82hfpExX2lr/ZcQtcw6BKeGP+OreArVnOtWgfPt95+ijtNsGiRaz70D94CzWAj/T1 W51Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AG5kyUwB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ESJGojnz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b20si14676836edw.120.2021.08.30.08.52.08; Mon, 30 Aug 2021 08:52:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AG5kyUwB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ESJGojnz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237646AbhH3PvU (ORCPT + 99 others); Mon, 30 Aug 2021 11:51:20 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:60272 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231725AbhH3PvT (ORCPT ); Mon, 30 Aug 2021 11:51:19 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74F81220D2; Mon, 30 Aug 2021 15:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630338625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ceX1dMxIClr9YSJ/0dIk11Ssam9+xQ+XyrlF6BIEsAg=; b=AG5kyUwBn8ctqnX2+iI3inK6/Izq07j4SRmFwCUAszezt1MfHKA3kmRMqFkj+Ekmm+gv0x 8wf+zCSI5UOhyntCRY2tSlAMKxr++F8SgfO5HpD0/qzIT74mySuLyA8I+FxbzBbvaZJiHb uLjnhivX+znnreLH5KNzch5qWhng7MA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630338625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ceX1dMxIClr9YSJ/0dIk11Ssam9+xQ+XyrlF6BIEsAg=; b=ESJGojnzI4LchpjfkAqI6xi0wYJFsjXPCKieciALPDwamE+MsndawpN+SIqOgJwdJiPcqO G1Lxi2xjvjImGTBQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 5F61B139B8; Mon, 30 Aug 2021 15:50:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id +v/iFkH+LGFqGwAAGKfGzw (envelope-from ); Mon, 30 Aug 2021 15:50:25 +0000 Date: Mon, 30 Aug 2021 17:50:24 +0200 From: Daniel Wagner To: Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Hannes Reinecke , yi.he@emc.com, kernel test robot Subject: Re: [PATCH v6] nvme-tcp: Do not reset transport on data digest errors Message-ID: <20210830155024.ekughhihfecbzzby@carbon.lan> References: <20210830133626.139828-1-dwagner@suse.de> <462c31ae-446b-cc23-eb91-5e27ef04ec13@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <462c31ae-446b-cc23-eb91-5e27ef04ec13@grimberg.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 06:38:28PM +0300, Sagi Grimberg wrote: > > + if (req->status == cpu_to_le16(NVME_SC_SUCCESS)) > > endian conversion a zero enum? looks weird.. I though it makes sense to stay consistent with the rest and don't make it harder for the reader to figure out why this might not needed here. And obviously the fear of the static code analyzers... > But, > Reviewed-by: Sagi Grimberg Thanks!