Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3723656pxb; Mon, 30 Aug 2021 09:09:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIdhGbrx3uNaqgEqzf2vCysDtTGmWkEtjSag19luhncS5dvq7BJLdT6bQcckr8hms8AbFR X-Received: by 2002:a05:6402:493:: with SMTP id k19mr7400177edv.386.1630339789512; Mon, 30 Aug 2021 09:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630339789; cv=none; d=google.com; s=arc-20160816; b=bd92LpnDz/1NWm+uWmlkLSyKkT1KN2vl8zIns/8XeNRofNWGfKO0EouIRp6u40AzEp BAnjYGwIxaGr5yBsKIFl4Ikf4E9iwQN+angZrNNTPZmoh2WlauWFZqUHmbswdSSYch49 SLVYXBege0A0wuXQle93kekfcwcsvOpcHkinrBBbeQBjN9/9F5eSgBI3VNLML4wjpLin nB+gZmCf3zZyOiRE/WbU4PHd1dHRSMx3Q1PLOhxo1Hcnd2vitCXahCm4XL+Pp26b7i50 ZU8mSqqDxcT7YM9kd1Tsz52hJIVOgkBFqPJdjvhkAAUyfqIC7xC1HYwAO/fuuHbOp/T+ rl2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=6BtEWVe5hUeab8q8CCkZgYLqgz9PL4mbc3f0l6qdXAo=; b=yRAYZZ4LKTV5STME7GpCgoQCuRJXTLpcyfwg1MQqvlc70n4Q74GjUg/rwgP2i25g56 4gnruJBm29uoc+I9xyOOSe5QYhKs3/fAUFqdwYY+h51EVLqRzgbipQuoo+/atCw1p1+r nKtg7t0mKonu9RnKqIfaXKQ3858FYQren4INkrU4QXoo/N8sy+yXLqpmRbpTvG+dfwNb ZRdo0RU0eAzSea2qU3bYDU6m8JWdp+Tj9UPSkP38tkaeQuXhXUnh9EJ9bHdGaSWA86WL HuHaWm4xzGilsxbrHBPfRskNMyi+W8MMhSg+94MJ0jxf6iwXCtyo9PYYTVROuH2YL3QB 9uRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail header.b=EeAOOX03; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si1182087ejx.184.2021.08.30.09.09.05; Mon, 30 Aug 2021 09:09:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail header.b=EeAOOX03; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237946AbhH3QHL (ORCPT + 99 others); Mon, 30 Aug 2021 12:07:11 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:47690 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237899AbhH3QHK (ORCPT ); Mon, 30 Aug 2021 12:07:10 -0400 Date: Mon, 30 Aug 2021 16:06:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1630339575; bh=6BtEWVe5hUeab8q8CCkZgYLqgz9PL4mbc3f0l6qdXAo=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=EeAOOX03lkc7k3EXPRBQonyTQS5/D7GQLTZp5QwNvHUocDNirfXUfWQFLSwhoySoC 5Fg6AP4pApoG1XNBS/UMDK+UHrDjHk5OUJCdMrfhQGi31r43exHSHEN0E06iPtY5he 9OL3ev6CCxJgcuBisu39/+LFjeoxSp8T3wSoB1t19R484Fy76DhKCWvOt0HgDEm1P5 7uX7wX1UOaf4X3xTtJNT5gswy0bAhYhHeOpYqildTkZYKvJeD0F+KAvVv8eiNfJo5P VhrwLTOeWSZP0p1z6uHqn2ocU/oqwbhLe8HKJefdV5tztwhdQCnF9wEOPsUnJIYG2J bRwgZKB1X9ovA== To: "F.A.Sulaiman" From: Simon Ser Cc: airlied@redhat.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Reply-To: Simon Ser Subject: Re: [PATCH v2] GPU:DRM: returning ENOMEM Message-ID: In-Reply-To: <20210830160207.23936-1-asha.16@itfac.mrt.ac.lk> References: <20210828154027.8198-1-asha.16@itfac.mrt.ac.lk> <20210830160207.23936-1-asha.16@itfac.mrt.ac.lk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe the commit message can be improved a bit? Add a prefix to make it clear this is about the udl driver, make it clear this is about the udl_get_edid_block function. The new `return ret` statement may return something different from ENOMEM. This would give something among these lines: drm/udl: return -errno in udl_get_edid_block