Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] trace/osnoise: fix missed cpus_read_unlock()
To:     qiang.zhang@windriver.com, rostedt@goodmis.org, bristot@kernel.org,
        mingo@redhat.com
Cc:     linux-kernel@vger.kernel.org
References: <20210829055206.137025-1-qiang.zhang@windriver.com>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
Message-ID: <fb07e806-71bf-6bac-ac3c-1d99136d6f8e@redhat.com>
Date:   Mon, 30 Aug 2021 19:26:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210829055206.137025-1-qiang.zhang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Qiang,

On 8/29/21 7:52 AM, qiang.zhang@windriver.com wrote:
> From: "Qiang.zhang" <qiang.zhang@windriver.com>
set the Subject to:

trace/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads()

> 
> When start_kthread() return error, the cpus_read_unlock() need
> to be called.
> 
> Signed-off-by: Qiang.zhang <qiang.zhang@windriver.com>

Add:

Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
Cc: <stable@vger.kernel.org> # v5.14+

> ---
>  kernel/trace/trace_osnoise.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
> index 65b08b8e5bf8..45d22d6f3acb 100644
> --- a/kernel/trace/trace_osnoise.c
> +++ b/kernel/trace/trace_osnoise.c
> @@ -1568,6 +1568,7 @@ static int start_per_cpu_kthreads(struct trace_array *tr)
>  		retval = start_kthread(cpu);
>  		if (retval) {
>  			stop_per_cpu_kthreads();
> +			cpus_read_unlock();
>  			return retval;
>  		}
>  	}

Why not initialize retval = 0, and then remove the "return retval" from this if,
returning rteval at the end of the function?

-- Daniel