Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Aug 2021 11:28:18 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Andreas Dilger <adilger@dilger.ca>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: Discontiguous folios/pagesets
Message-ID: <20210830182818.GA9892@magnolia>
References: <YSqIry5dKg+kqAxJ@casper.infradead.org>
 <1FC3646C-259F-4AA4-B7E0-B13E19EDC595@dilger.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1FC3646C-259F-4AA4-B7E0-B13E19EDC595@dilger.ca>
Precedence: bulk

On Sat, Aug 28, 2021 at 01:27:29PM -0600, Andreas Dilger wrote:
> On Aug 28, 2021, at 1:04 PM, Matthew Wilcox <willy@infradead.org> wrote:
> > 
> > The current folio work is focused on permitting the VM to use
> > physically contiguous chunks of memory.  Both Darrick and Johannes
> > have pointed out the advantages of supporting logically-contiguous,
> > physically-discontiguous chunks of memory.  Johannes wants to be able to
> > use order-0 allocations to allocate larger folios, getting the benefit
> > of managing the memory in larger chunks without requiring the memory
> > allocator to be able to find contiguous chunks.  Darrick wants to support
> > non-power-of-two block sizes.
> 
> What is the use case for non-power-of-two block sizes?  The main question
> is whether that use case is important enough to add the complexity and
> overhead in order to support it?

For copy-on-write to a XFS realtime volume where the allocation extent
size (we support bigalloc too! :P) is not a power of two (e.g. you set
up a 4 disk raid5 with 64k stripes, now the extent size is 192k).

Granted, I don't think folios handling 192k chunks is absolutely
*required* for folios; the only hard requirement is that if any page in
a 192k extent becomes dirty, the rest have to get written out all the
same time, and the cow remap can only happen after the last page
finishes writeback.

--D

> Cheers, Andreas
> 
> 
> 
> 
>