Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Kate Hsuan <hpa@redhat.com>, Jens Axboe <axboe@kernel.dk>,
        Hans de Goede <hdegoede@redhat.com>
CC:     "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/1] libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung
 860 and 870 SSD.
Thread-Topic: [PATCH v3 0/1] libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung
 860 and 870 SSD.
Thread-Index: AQHXna1t7boOugOZ8kmPA9hpElRs0A==
Date:   Mon, 30 Aug 2021 21:45:48 +0000
Message-ID: <DM6PR04MB708147357F91D5AEB6128A2AE7CB9@DM6PR04MB7081.namprd04.prod.outlook.com>
References: <20210830144253.289542-1-hpa@redhat.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mDqSSxaNSmtMK8JmVYGrdbHxv+ofiovp7xeDH5kgu/ivu/DnmVTG8K2DsJ9k?=
 =?us-ascii?Q?qDq5q44XjiCR2DfxxIoDGKBN4o9ivLr4Pm/L7SUQETl3Pw37NeVcJipC45Ra?=
 =?us-ascii?Q?61aNrneIvxD88NW4Gdv75jmPmkl2960PQvr7Cohy7pcBGHOfid7+84raF7dG?=
 =?us-ascii?Q?G48HpVumHdpK3SNL5QE6uzn9Y2kMsprAWPgh7eZ7wVqxhNpzeHprUWkfpu+8?=
 =?us-ascii?Q?Pkw3HJ1B/vsnScxyBH2UOsGyIVu1FSjoFg6V8sEhQ2G6RDB53nSrIpXGBSgi?=
 =?us-ascii?Q?06qemEKcfxgb9CjlYypA5mqNSo0kJczmQiNH7He7o1XXInz91gblQ+GNJPHt?=
 =?us-ascii?Q?wj4/crrnVPTM8xdekwrP8kKI/pAwCN6TnhoEEBVAcVVy2NeVbKVUN1K7NeRt?=
 =?us-ascii?Q?3e1R1457z1Z2BJuve+vRPZYJzOqrNI2dhbvIp7ieKZMmVYUPc+YlknWkiM62?=
 =?us-ascii?Q?eiKkZf/tYEwWK5SdrBzVfUVkTAN0pPhJvrOeOF6TI37pFUPvCbQa5kU7vfxQ?=
 =?us-ascii?Q?TsURUhGvMyuoT3InfIcfQ4MyKi8u92Us9Vc/C04/zdG1o9XKxOV2AiON26zo?=
 =?us-ascii?Q?4lxxAmxjsIZUki2BNiB6sv4IF0tG11tGlX9LLRPAYxXd15x9/LL7sm3CxSq8?=
 =?us-ascii?Q?iBLOrlTYL9eT8+H1ispMVEP0OvFGUxxjLa4hkI+FmkrGah+VW81QEcIY44SA?=
 =?us-ascii?Q?NWyJvIA2EqI00RhmHnARubB0YEdegloNSumooI8liAdXEfH+dGwcwfluh/EK?=
 =?us-ascii?Q?VDSjTNJXnWJ+6JIbCur6HjEd/l6e/JVC2QlUcwnWcWJbwHJ1TotlqrvkENoB?=
 =?us-ascii?Q?/eYttavxLa+f2oLjLC/aIuqytHLckThPK0YAJYO+Rh6+37ENq48BYnO9e3bz?=
 =?us-ascii?Q?j1FRBQyMsJk6RXqIFwaiCOLsf6qDQPgbrvryCrU51oaunaBpYc+LRFYmnmVM?=
 =?us-ascii?Q?H68N2F3bPjBRu0LR7oLWk3gn7vqNxzVuttj46asOPk90re/QTr+JaVVdPhP3?=
 =?us-ascii?Q?h786JTmhZalYv3ughatszQ/D1nGMbQOSWzEZW9+zJsdToPBjfqCLS7nQh2fH?=
 =?us-ascii?Q?VQCUtEp3gg+2yXt3QJabkYKoj0toUGnpO4CMOOQ6nfjoqzd9aVZbnREbHcxj?=
 =?us-ascii?Q?fwshidNLKlg603L03zM+063egGvTjF4uzyxID6BKaOj+DbKGGx9Y6gQuUt0f?=
 =?us-ascii?Q?BtOSI8OROLbRg5BaQEPK9RNa9VV1pB5QRmPnSuyCjEzor4KILlFy1BRsQBSf?=
 =?us-ascii?Q?ng958x43mBDduJ6xXLhXj1YTH8T4vKv7mMxs5lzfKXWZx5t51Dppp/1bFtSy?=
 =?us-ascii?Q?zg4tZW1BoKdoy5IYiAmyXm1zhcAjF/Wy1S6jyvSfr3JaggFEgnAukPDhmHNO?=
 =?us-ascii?Q?VKMtEX9MGlj0AjujihPZVUoRh3PTf+qYHjnlebfOijnSeqBKsA=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB7081.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6f58db-f709-4d44-8f1e-08d96bff87d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2021 21:45:48.9240
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3n0xVMcRDFYKby9C5fDRTQSURqYO9/Y3vTuxakoqtDwLtdT2syDFHRCfEimgrt85VqgaPc/cFm5LPoGR8rdGZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0810
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/08/30 23:43, Kate Hsuan wrote:=0A=
> Many users reported the issue when running the system with Samsung 860,=
=0A=
> 870 SSD, and AMD chipset. Therefore, completely disabling the NCQ can=0A=
> avoid this issue.=0A=
> =0A=
> Entire disabling NCQ for Samsung 860/870 SSD will cause I/O performance=
=0A=
> drop. In this case, a flag ATA_HORKAGE_NONCQ_ON_AMD is introduced to=0A=
> used to perform an additional check for these SSDs. If it finds its paren=
t=0A=
> ATA controller is AMD, the NCQ will be disabled. Otherwise, the NCQ is ke=
pt=0A=
> to enable.=0A=
=0A=
For a single patch, generally, a cover letter is not needed. Especially so =
in=0A=
this case since your cover letter message is the same as the patch commit m=
essage.=0A=
=0A=
> =0A=
> Changes since v3=0A=
> * Modified the flag from ATA_HORKAGE_NONCQ_ON_ASMEDIA_AMD_MARVELL to=0A=
>   ATA_HORKAGE_NONCQ_ON_AMD.=0A=
> * Modified and fixed the code to completely disable NCQ on AMD controller=
.=0A=
=0A=
Technically, this is a v2 right ? Also, by "completely", did you mean "alwa=
ys" ?=0A=
(see patch comments).=0A=
=0A=
> =0A=
> =0A=
> Kate Hsuan (1):=0A=
>   libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung 860 and 870 SSD.=0A=
> =0A=
>  drivers/ata/libata-core.c | 24 ++++++++++++++++++++++--=0A=
>  include/linux/libata.h    |  1 +=0A=
>  2 files changed, 23 insertions(+), 2 deletions(-)=0A=
> =0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=