Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/7] btrfs: qgroup: try to flush qgroup space when we get
 -EDQUOT
From:   Anand Jain <anand.jain@oracle.com>
To:     Greg KH <greg@kroah.com>
Cc:     Qu Wenruo <wqu@suse.com>, Qu Wenruo <quwenruo.btrfs@gmx.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        linux-btrfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>
References: <cover.1628845854.git.anand.jain@oracle.com>
 <740e4978ebebfc08491db3f52264f7b5ba60ed96.1628845854.git.anand.jain@oracle.com>
 <0711671b-b08c-ee78-7271-b756dd1b579e@gmx.com>
 <b49529b9-3f1c-be5f-f95a-dadceae057ec@oracle.com>
 <6f45f8c6-03df-b2e0-cfda-85fd0b41212a@suse.com>
 <26649302-ce62-798d-4a9c-6a46ab1e25ec@oracle.com>
 <YRZP4Jh0FNHrma5/@kroah.com>
 <5fe24e8e-0f59-216d-a230-3f26c086b8a3@oracle.com>
Message-ID: <99d3d022-c5b7-5bd7-2340-f61bffee76e7@oracle.com>
Date:   Tue, 31 Aug 2021 06:27:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <5fe24e8e-0f59-216d-a230-3f26c086b8a3@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.10.109] (39.109.186.25) by SG2PR0601CA0019.apcprd06.prod.outlook.com (2603:1096:3::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 22:27:37 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9df39404-8c9f-47ad-f404-08d96c0560bb
X-MS-TrafficTypeDiagnostic: MN2PR10MB4287:
X-Microsoft-Antispam-PRVS: <MN2PR10MB428724D6E9C8CAE69B475258E5CB9@MN2PR10MB4287.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LKwTLK6YMVj4kFoSVb42jN0Isxm5fjmT4rvc9h0WmOmZED8P9V7GMB+e8atfWLEiVs3T5rW7/jR0h9hp6pDEBsDUoswdxX0RGE+IJBBaNN57mAayVybFhS73QXENrKtSYkMSRMbWEijDf+jnmdZk/OXJMF+csA8gxDV54FDazQMn+jSvzF3nbxOYD6BdLapt3Lv678tInIp0QSuTH2lcvbGlxrJAHrj9zFKde33dAbMyyNAx4C5twcQdR0m5XaH6a+Evuz6WRgHY7sWYgR1QitmKx5/ICYI8FjPtmHG+q4IALlm3ssWUQ70H4f4DUSlfZ1OFD9lVYR7n1eJzRijfK9k9HatDnyLMDt4eqaGZypRiPeSnKZ0rfJEiDnax48uZwqMYD0bpS5Pztc7WuFQScBqtN+EI9SB8550+zVpcQQuK7DIvKox0BP5bKx/ipH98sfqh6szTrEr8Yj3wbLD/l2AOzBlbaOZa5NYaQYo5yTFMdYFE5Cb3HK90xXsilO38v8DB7WsIwznpzHWRFw0t0UTIKx4BdrgKZhh81XnzsGPbLf4y7l8cXsQUYxzTrcBhbujWf9Ut1Cvr1sZC2S5rjcVeFCOV95fPULPtiOPecPMAnMT6bVSS8Z61J00cDRe1oylvJ38W6+I7uOTxV3s63lZJVunMHyOMXXnwwNL0oDcdYJ2qUxbICfMTWpmmuVtEnOaa5wlMpPRW5eT2Huer33uPnZpbmGXRQR7w6NiSDrI=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4128.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(376002)(346002)(136003)(83380400001)(6666004)(38100700002)(6486002)(86362001)(2616005)(186003)(54906003)(8936002)(16576012)(6916009)(316002)(44832011)(31686004)(26005)(53546011)(66476007)(5660300002)(66946007)(2906002)(66556008)(4326008)(956004)(36756003)(31696002)(478600001)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUcralA3a284VXBlQzNkeXdzTHVodUIzUjhYaVYxeEVtSFh1cUNVV0s1cmp3?=
 =?utf-8?B?aHhjZVhJUTN4ckNDc1pySWNVb1ZUN3pRUHlmbmhBWWdnTzVsTmduT2pIbVdH?=
 =?utf-8?B?SlUrOXIzMitVaU5DL1hpeGVYUkRTNnp3UFFjeFd5ekVsQkFBLy9GRzAzZzcx?=
 =?utf-8?B?RzJZYnBHM1F2cFA4VktzUWJKZlJjRDl3dWZjOHU5WWx5VGxyZ0JmcnhFSXcz?=
 =?utf-8?B?K2dFMEt5cHR5V1ZLNjY4c1Q0Wmx6TjRWVnRGMFZNMG9jaWszd2wrd3UvVlFa?=
 =?utf-8?B?dG1TRVBxYTl3cGM0aVVYMEVsOHNoRUQ1eG80YzFYQkhxM01BWVRBSkVnVFpP?=
 =?utf-8?B?M1hxZDVXMDI2NTA1ZVp0RHFUZUw5SlF3bVJEdnRVTWIrVTVpaitvWisxbDN3?=
 =?utf-8?B?S3FPSmt0dzdHQWR6ZWpsVHhPazVKU08rWXFWVmFUSzZ1M0VnZ3o3eTM2MXBV?=
 =?utf-8?B?T214RkRFaGc4WjVmdUJCcHNQTTZLQndRUHhNUHl0WFo4cUtrQ2k4UTV0cGQv?=
 =?utf-8?B?ZE5OTDA2WXA2UU43VjRCTSt1bUJIRG4rVmZhdnFVWTNId3hZUXlWMHN4VWww?=
 =?utf-8?B?K1ByQUR6ZU90bVR1SkhZQ0tNV0twK0ppdnZmdHZqM1FjK1NZMWhuUWp0MG1E?=
 =?utf-8?B?aXVjS3NSMGR4bXpoSUlsSVppcVdwOGNhL0J4S3JYZC9VZndOTW9OeWlkY2Nl?=
 =?utf-8?B?US93MjhRd3FuRlRzSVlOb2FCUkpTTmVrbUkrQWNJeFBUKy8wZ3VWQ3ZOV0JW?=
 =?utf-8?B?a3p1dGpjZjZiSWdiMExYaS8rZ2UySjRSMXl6Nnd4Z1h4SW5JT2p3eG55bGMv?=
 =?utf-8?B?THFBdHBaV2ZjMVVBWUVlS0xzalBsSnpDdGlJbDJ1U3JIR3YrSWhVSzl3U3RT?=
 =?utf-8?B?MThtSWtHckxJZi9hUVJtb3U0cTMyQ3RYRmtmazBWVHVQbzR3SGpDb3NlMm5S?=
 =?utf-8?B?RlVaN1VSUnZqUWUrTjNsSCt3L0tiRmF4L3IwSUZiUEdYaElpNFFMTzRpcG81?=
 =?utf-8?B?RDBKZS9PV0FhYXVxZ01PNzFRY0V2NGxjdThNcitNbktiRTIzQzcvV0Z1WTJ2?=
 =?utf-8?B?L0p0bFlPTE9qWml1SGhJUzNSTWxjcVVDelNSMEpwMUUwV1dYZXFSeitnTTRt?=
 =?utf-8?B?SUcyengrT25LZERUVnp2bzYwR0VGM0tVN2xaVml0WUZZUzd3alllQkEycjJp?=
 =?utf-8?B?MDhuK1BZSzdqeEtKdmZCZFovK1F6OUhCVDhHWG13MTBYT0M5RHZwRVZ6U1VC?=
 =?utf-8?B?WjhkT25UMlFDaVo0YTZ3dmJKS0hrcW5GeGZORWpFL3JBTUVuVzRxMzNnZklD?=
 =?utf-8?B?OU9WdWVhQ01NWUpEY0ZFZnE0OGhIMHErejZDNmI1MlBIYXJzb0JSRDEvZUY1?=
 =?utf-8?B?VjRCcFZwbm5NR2t6MHVLL3NMWlJOWDhBckErOXJFWVdjWEM0YzZyUllyVFlk?=
 =?utf-8?B?RjFqbTBaTys0Z0huNFR4RXZGT1dyRW93M2lCZTFiM1dleDV6NDNhTE5SWk9t?=
 =?utf-8?B?RGlHUitkWDZmQmNTOUN5dWdpSGwrMmhYY2loZzZxcTNLN2g3VDlHVHNRbHpQ?=
 =?utf-8?B?RDRMY3JmLytkWFFvczV4SXF1VGM1QVJGY2ZZdzdVaFhCZ3pPQWswYzRjWDhn?=
 =?utf-8?B?ZEhXaFdTSUovRklEZUwyMEt2VUtvanNwcmw5VkZ0b2IyV1dkeDZiR3l4c29P?=
 =?utf-8?B?ZmQxMnNUUU0vT21XVHV1TFZLalJzNFlUbWJIK3I4bDBpTlM2ZVhOeDY2azlv?=
 =?utf-8?Q?WHjrtGuo9ika0INKcuVqESOQzXXe3nHqAEwvr4L?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9df39404-8c9f-47ad-f404-08d96c0560bb
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 22:27:40.5034
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IJVnXHOVqbtAuK/5924/PhVPtcimuUNw+IZMtOijda9UstRRYPLn+9UgF9Z/u2unCICmCUe8LHrboTS8sUdVWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4287
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10092 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108300141
X-Proofpoint-GUID: q49LCMSMSbin8iBMDfyctOrQFGcUfiDO
X-Proofpoint-ORIG-GUID: q49LCMSMSbin8iBMDfyctOrQFGcUfiDO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13/08/2021 19:06, Anand Jain wrote:
> 
> 
> On 13/08/2021 18:56, Greg KH wrote:
>> On Fri, Aug 13, 2021 at 06:41:53PM +0800, Anand Jain wrote:
>>>
>>>
>>> On 13/08/2021 18:39, Qu Wenruo wrote:
>>>>
>>>>
>>>> On 2021/8/13 下午6:30, Anand Jain wrote:
>>>>>
>>>>>
>>>>> On 13/08/2021 18:26, Qu Wenruo wrote:
>>>>>>
>>>>>>
>>>>>> On 2021/8/13 下午5:55, Anand Jain wrote:
>>>>>>> From: Qu Wenruo <wqu@suse.com>
>>>>>>>
>>>>>>> commit c53e9653605dbf708f5be02902de51831be4b009 upstream
>>>>>>
>>>>>> This lacks certain upstream fixes for it:
>>>>>>
>>>>>> f9baa501b4fd6962257853d46ddffbc21f27e344 btrfs: fix deadlock when
>>>>>> cloning inline extents and using qgroups
>>>>>>
>>>>>> 4d14c5cde5c268a2bc26addecf09489cb953ef64 btrfs: don't flush from
>>>>>> btrfs_delayed_inode_reserve_metadata
>>>>>>
>>>>>> 6f23277a49e68f8a9355385c846939ad0b1261e7 btrfs: qgroup: don't commit
>>>>>> transaction when we already hold the handle
>>>>>>
>>>>>> All these fixes are to ensure we don't try to flush in context 
>>>>>> where we
>>>>>> shouldn't.
>>>>>>
>>>>>> Without them, it can hit various deadlock.
>>>>>>
>>>>>
>>>>> Qu,
>>>>>
>>>>>      Thanks for taking a look. I will send it in v2.
>>>>
>>>> I guess you only need to add the missing fixes?
>>>
>>>    Yeah, maybe it's better to send it as a new set.
>>
>> So should I drop the existing patches and wait for a whole new series,
>> or will you send these as an additional set?
> 
>   Greg, I am sending it as an additional set.
> 


>> And at least one of the above commits needs to go to the 5.10.y tree, I
>> did not check them all...
> 
>   I need to look into it.

We don't need 1/7 in 5.10.y it was a preparatory patch in 5.4.y
  [PATCH 1/7] btrfs: make qgroup_free_reserved_data take btrfs_inode

The rest of the patches (in patchset 1 and 2) are already in the 
stable-5.10.y.

Thx, Anand


> 
> Thanks, Anand
> 
>> thanks,
>>
>> greg k-h
>>