Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp3998376pxb; Mon, 30 Aug 2021 16:03:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzs8o9kqOA2UncnRLuypmuoGR4yJJPrG4dyKF/4nsiOL+Z6oMjr5hx0O/CaIsRmnGvBeR9 X-Received: by 2002:a17:907:9604:: with SMTP id gb4mr28068841ejc.142.1630364581091; Mon, 30 Aug 2021 16:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630364581; cv=none; d=google.com; s=arc-20160816; b=wZOIbNhcj4bRoxrDDhRJr4eNRXhDobmnLNOZ56GuP/r8MTiPONaUunrGT+fiwWbWz9 ATWNuB4q2GyNkpQLsTsPfTGxljINYqSECijy1psCpBo9oM4froPyp89EScXrn/BdnLQg isbebfBEHA4roUVq1z0Uyn3S8yvqUXaEvFPoykhRkU7F8U+3VnSqEQnnUb+7OiueO57P GvD+Ka5M2jaIH4GS1nEqy0Bn+VcUS8KPhf/srfWilQgTykBEmXqH+vd2JYtQCLUGtM32 88WQFnzxxoTxLRszYssZqI5DutnpBNFFwFX+rgD/5EdRlHEPYXc/HDkBxFT04JY7Xzo5 rOyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=SBvWEFE7ZHRV6dF93YeVztgkppDJ5iGt+SWnxMoR3Zo=; b=cc6ZDSScuArUB8WSZVQb7MM7aaaefVYUD9r9E6De2geuVpD1MnZ0VLnIHDgQOQj+st trV6hn6SCwptaNrNPGmPEkuBiZ741msKSvnJVDhaqi66yCzi7dysTs7lAMLCvEvfz9na IXqsAwwZeC/N9d8uUNBDGnNJyzkiMnfRqlmLzv3+8iF1fleCFrGn8BcZNYc6eddgg5Px GiO2pQu8Deb6Elctbg1mZtbqy9s1sPkWa2zGtTlThUM8jEJdop4z5ROOkpfybq+sGzPM Vq2BxhYJ6nkn+/xKHGINZba1jThkY7O/pyG6QxWSNHsNtASOP8YjW4YNYjbO2gCkHvH/ UNqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K2aL61yr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si15585633edr.52.2021.08.30.16.02.37; Mon, 30 Aug 2021 16:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K2aL61yr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238842AbhH3XCL (ORCPT + 99 others); Mon, 30 Aug 2021 19:02:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238773AbhH3XCH (ORCPT ); Mon, 30 Aug 2021 19:02:07 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC83AC06175F for ; Mon, 30 Aug 2021 16:01:13 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id 107-20020a9d0bf4000000b0051b8be1192fso10284893oth.7 for ; Mon, 30 Aug 2021 16:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=SBvWEFE7ZHRV6dF93YeVztgkppDJ5iGt+SWnxMoR3Zo=; b=K2aL61yrvUo2pFacIrBVkLxIAHZ0ijDkNx0/BdyNj2ChxOpGGi2qY7C9FxzMzGGMOu I20sjcqzzPEaxBrwdCj351IE5YaIWm0Wx/E/ou/QxI9ebJ6K/zg86A+ujSPHIphzLG9K RA8odMrTuEgsYD1dRHXJAjSU2vAdSrFMTRgIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=SBvWEFE7ZHRV6dF93YeVztgkppDJ5iGt+SWnxMoR3Zo=; b=srtPMUAszLKdV/37qHOW7BedsC6csmO4Np1PNJ4GLIwjzwBijBQlO/kDHR75TQNHsV PgMkZXjpe6xdGHIEesoOzb56dscqdUqfG3RBqWAvZhsG9QJc0BeCIsqKjAXmHeEn9Y/7 JW9v1M2cNLKkMVSq4wk3p66v2T1U/lqSkHSJGqNUo0MLfT1vAl1x9dbApbeR58mL7v/x OnoJ6qvElY84julzKAUsgfCTX3iMdJrWp+wA6/WgHahL4o3Ppinfn6aNxsQauPFqWWcQ HM6xjoyI9Fhq6od8nKP53eqtIMApDplEBVuF17onUL/bhyxENw2RtT3UBYrn/uO49HM7 SfZA== X-Gm-Message-State: AOAM530SKNfFvAcG593cJjk1i0AWIsPRmCFuW2SbwwTLxGdERafl25BZ tws67WE5X3BT3zW2I/TTn6BKwA1sU8AQzj5i74MApQ== X-Received: by 2002:a9d:123:: with SMTP id 32mr22337333otu.124.1630364473117; Mon, 30 Aug 2021 16:01:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 30 Aug 2021 16:01:12 -0700 MIME-Version: 1.0 In-Reply-To: References: <1628161974-7182-1-git-send-email-deesin@codeaurora.org> <1628161974-7182-3-git-send-email-deesin@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 30 Aug 2021 16:01:12 -0700 Message-ID: Subject: Re: [PATCH V5 2/2] soc: qcom: aoss: Add debugfs entry To: Deepak Kumar Singh , bjorn.andersson@linaro.org, clew@codeaurora.org, sibis@codeaurora.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Deepak Kumar Singh (2021-08-30 04:46:53) > > On 8/5/2021 11:58 PM, Stephen Boyd wrote: > > Quoting Deepak Kumar Singh (2021-08-05 04:12:54) > >> It can be useful to control the different power states of various > >> parts of hardware for device testing. Add a debugfs node for qmp so > >> messages can be sent to aoss for debugging and testing purposes. > > Is it ever useful after device testing? I'd prefer we not apply this > > patch as it looks like testing code that won't ever be used after > > developing this driver. > > This is not only for testing. Some user space clients can also use this > to send messages to aoss. > > One such example is setting higher ddr frequency during boot and > reducing it post boot from user space. > The debugfs file system should not be used by userspace to do things like that. It's a debugging file system, not a configuration file system. If you want to expose userspace control for this it needs to be done in a different way.