Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4305832pxb; Tue, 31 Aug 2021 01:41:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys12caSJXGjz7LHKs0h//ZKtXIW03J686evmvDcpY6DrcciJTTPm9KaY9ZSOgmZsONe4Wv X-Received: by 2002:a6b:8e50:: with SMTP id q77mr21177338iod.96.1630399293466; Tue, 31 Aug 2021 01:41:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630399293; cv=none; d=google.com; s=arc-20160816; b=EETeGgetJVTrrj+nqZfe/xoFTmULrLq8DXkvEu0AaLqZnJWFmmuCevX24BIv8YIC9d Os7uzSzJJ/v9n1zCkINs0iK/S9joTqQKITZ39BEcExCrHcc3IeGicPWUAhGGCtGLt9jB hnp29H+RdGS2ItEBbb/KW35PFXRUwj7HEV3aVZIssTIUrd2uUWlwuwxFDMLP03ribJoB L33Q8wWi+Mq8ONiVv7jeHxg/90je9DMtra4+w60JmtMWyD1mA6RFuLTG9S4Jv9cRBSIh h4SjTcN3SkpEBuBM3/nCz2U2lx1ws0bYpqoTuotFZ2L6BbWCP0h1YuvZwjeaBPIeMaKY 10Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Lcb2QpqE7SCe57K/FeQyD32Ygc6FkYVP7nEFcP52JHQ=; b=UND9e10hkQncSeSBiVUNhSzeoSOkNjpg5mH7rV2TzohBP25x7N/QETxcmZgsoMIWA1 WgFWjDCtz7mdlljdw134FYuGcA2oRNI9oN7U/9tlyhvRu5qcE1jy3MG5uX84KLlxQbqt lqdklMtFbtbaskmEv1xszPOxjBUbPAKD0OvKCcB3dGwMhWvN9pchU16PucRESUrvCmal sF4eABfuOstmc1Ipjhpo9yWXgnWsOReAOZ/b1DFifvGNILsHOhsNerjSWq8dheFDOZKn n38Y5DyZp8YJA1lNtx1sD5OLx6w3B3DwL1/byjltCMiHPqZWnOLu4UmJ0At+K9oNp96q op8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=G+2Oqoix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v17si16469169iln.134.2021.08.31.01.41.14; Tue, 31 Aug 2021 01:41:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=G+2Oqoix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240381AbhHaIlF (ORCPT + 99 others); Tue, 31 Aug 2021 04:41:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:48672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240403AbhHaIlD (ORCPT ); Tue, 31 Aug 2021 04:41:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 243F960E98; Tue, 31 Aug 2021 08:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630399208; bh=gqiAk6efM2NN49iQ6niUDVype6wdTyTtrakguXN3l0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G+2OqoixJR5gxsUHm+HCT4jEjATdneaHH8fhceORBhplLmZnEa8lBaX3OdTjQtbUj ypyZHT7vKvuDgO6ss0PxUhJXTLgWgyquyyn9/4Wrl7+R//GUcG4mQ7Igkhg9YNm7i+ HljCOvfeS2INezlaD3Xblc9SWH4FWctfVr0SubaJAav7J2VZ860G0YYhtnNlPQo/lJ 7xouBtHZyh9x53cP1oIT2tkFmU/5oR6Njp3bv8dtOQ6YDIpU+nSCUUfphv5mZU2Fa1 gQcm92SwWyqLwAh8tTDAqlam2nc+VuC95/Wuj295yfSmdaeRAiR2LEHdiLoyiRlIgc 7q3OxLc8rIjIQ== Date: Tue, 31 Aug 2021 11:40:01 +0300 From: Mike Rapoport To: Rick Edgecombe Cc: dave.hansen@intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, akpm@linux-foundation.org, keescook@chromium.org, shakeelb@google.com, vbabka@suse.cz, linux-mm@kvack.org, linux-hardening@vger.kernel.org, kernel-hardening@lists.openwall.com, ira.weiny@intel.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 05/19] x86, mm: Use cache of page tables Message-ID: References: <20210830235927.6443-1-rick.p.edgecombe@intel.com> <20210830235927.6443-6-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210830235927.6443-6-rick.p.edgecombe@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 04:59:13PM -0700, Rick Edgecombe wrote: > Change the page table allocation functions defined in pgalloc.h to use > a cache of physically grouped pages. This will let the page tables be set > with PKS permissions later. > > For userspace page tables, they are gathered up using mmu gather, and > freed along with other types of pages in swap.c. Move setting/clearing of > the PageTable page flag to the allocators so that swap can know to return > this page to the cache of page tables, and not free it to the page > allocator. Where it currently is, in the ctor/dtors, causes it to be > cleared before the page gets to swap. > > Do not set PKS permissions on the page tables, because the page table > setting functions cannot handle it yet. This will be done in later > patches. > > Signed-off-by: Rick Edgecombe > --- > arch/x86/include/asm/pgalloc.h | 6 ++- > arch/x86/include/asm/pgtable.h | 6 +++ > arch/x86/mm/pgtable.c | 79 ++++++++++++++++++++++++++++++++++ > include/asm-generic/pgalloc.h | 44 ++++++++++++++----- > include/linux/mm.h | 11 +++-- > mm/swap.c | 6 +++ > mm/swap_state.c | 5 +++ > 7 files changed, 142 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/include/asm/pgalloc.h b/arch/x86/include/asm/pgalloc.h > index c7ec5bb88334..1ff308ea76cd 100644 > --- a/arch/x86/include/asm/pgalloc.h > +++ b/arch/x86/include/asm/pgalloc.h > @@ -7,6 +7,10 @@ > #include > > #define __HAVE_ARCH_PTE_ALLOC_ONE > +#ifdef CONFIG_PKS_PG_TABLES > +#define __HAVE_ARCH_FREE_TABLE > +#define __HAVE_ARCH_ALLOC_TABLE I think one define would suffice. If we'd ever have an architecture that can implement only one of those, we update the ifdefery in asm-generic/pgalloc.h > +#endif > #define __HAVE_ARCH_PGD_FREE > #include > > @@ -162,7 +166,7 @@ static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) > return; > > BUG_ON((unsigned long)p4d & (PAGE_SIZE-1)); > - free_page((unsigned long)p4d); > + free_table(virt_to_page(p4d)); > } > > extern void ___p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d); ... > diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h > index 02932efad3ab..e576c19abc8c 100644 > --- a/include/asm-generic/pgalloc.h > +++ b/include/asm-generic/pgalloc.h > @@ -2,11 +2,26 @@ > #ifndef __ASM_GENERIC_PGALLOC_H > #define __ASM_GENERIC_PGALLOC_H > > +#include > + Why is this required? > #ifdef CONFIG_MMU > > #define GFP_PGTABLE_KERNEL (GFP_KERNEL | __GFP_ZERO) > #define GFP_PGTABLE_USER (GFP_PGTABLE_KERNEL | __GFP_ACCOUNT) > > +#ifndef __HAVE_ARCH_ALLOC_TABLE > +static inline struct page *alloc_table(gfp_t gfp) > +{ > + return alloc_page(gfp); > +} > +#else /* __HAVE_ARCH_ALLOC_TABLE */ > +extern struct page *alloc_table(gfp_t gfp); > +#endif /* __HAVE_ARCH_ALLOC_TABLE */ > + > +#ifdef __HAVE_ARCH_FREE_TABLE > +extern void free_table(struct page *); > +#endif /* __HAVE_ARCH_FREE_TABLE */ > + > /** > * __pte_alloc_one_kernel - allocate a page for PTE-level kernel page table > * @mm: the mm_struct of the current context ... > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c13c7af7cad3..ab63d5a201cb 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2327,6 +2327,13 @@ static inline bool ptlock_init(struct page *page) { return true; } > static inline void ptlock_free(struct page *page) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > +#ifndef CONFIG_PKS_PG_TABLES > +static inline void free_table(struct page *table_page) > +{ > + __free_pages(table_page, 0); > +} > +#endif /* CONFIG_PKS_PG_TABLES */ > + Can't this live in asm-generic/pgalloc.h? Then you won't need to include linux/mm.h there. > static inline void pgtable_init(void) > { > ptlock_cache_init(); > @@ -2337,7 +2344,6 @@ static inline bool pgtable_pte_page_ctor(struct page *page) > { > if (!ptlock_init(page)) > return false; > - __SetPageTable(page); This change is only valid when __HAVE_ARCH_ALLOC_TABLE is set. > inc_lruvec_page_state(page, NR_PAGETABLE); > return true; > } > @@ -2345,7 +2351,6 @@ static inline bool pgtable_pte_page_ctor(struct page *page) > static inline void pgtable_pte_page_dtor(struct page *page) > { > ptlock_free(page); > - __ClearPageTable(page); > dec_lruvec_page_state(page, NR_PAGETABLE); > } > -- Sincerely yours, Mike.