Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: Re: [PATCH v3 net-next 5/8] net: dsa: felix: support psfp filter on
 vsc9959
Thread-Topic: [PATCH v3 net-next 5/8] net: dsa: felix: support psfp filter on
 vsc9959
Thread-Index: AQHXnhk3bR+2BJOkCk2OO1PW76puEquNPsAAgAANEQCAAAFHAA==
Date:   Tue, 31 Aug 2021 08:46:11 +0000
Message-ID: <20210831084610.gadyyrkm4fwzf6hp@skbuf>
References: <20210831034536.17497-1-xiaoliang.yang_1@nxp.com>
 <20210831034536.17497-6-xiaoliang.yang_1@nxp.com>
 <20210831075450.u7smg5bibz3vvw4q@skbuf>
 <DB8PR04MB5785D9E678164B7CFE2A38CCF0CC9@DB8PR04MB5785.eurprd04.prod.outlook.com>
In-Reply-To: <DB8PR04MB5785D9E678164B7CFE2A38CCF0CC9@DB8PR04MB5785.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EGEAMIk2fMSHMo6gIG+/Wg+CWK9plRzA7Z+Y+PBLOd+0s7icSJ93mBuJCRpT?=
 =?us-ascii?Q?ijFEXK4ZDdaIFfm12gKI6pQrmaoWPyFWU6D64V/oCO2WdGYKYbpbxp8AbV3a?=
 =?us-ascii?Q?OqoKhWr7mj+eEqx6b/Fj0/H5M/r+4sB98DzxWKaXkJoQCZffmtUbti5ZjvN8?=
 =?us-ascii?Q?KaOFFb7fmjwrZBr2Hqvc/TxZ6JAy/v9mgGdi1BJEnbfy/XY+IPXsmZQZd76o?=
 =?us-ascii?Q?geHKRpWmoaN+x/U4uIP3CGQXDxmWHvR7jCfyb8jmadrV4yMJhyaNmSObr6em?=
 =?us-ascii?Q?HZuJH08hDUg/7RAAJlCwg0f92pDQTiulbTNETvK9t0bo/4rTj3pcVR6RVkti?=
 =?us-ascii?Q?rAb4nQmD0RJlcM9b3J/CGM6mO5CEJlw0INBD5eIEfpbbcbK61lXGCNvdIicT?=
 =?us-ascii?Q?l6SJ7utilyOX0kRmidVcxjySwpLIXWdoUtcqDx3hJNvC4jlqiHzq+fOdItUV?=
 =?us-ascii?Q?DNFGBfFr/YSfX1gY0ohzyR9qd98Rk/IB90W1HNZ0yry2YLG8IR51TnAA8aMz?=
 =?us-ascii?Q?GRJRauBKkcAmLd7tHYNxn58lp8e2hkywhv2OzBGmI8M44hzULXciy3ZbI/8f?=
 =?us-ascii?Q?6VJ7opf+HnWcJhN3uFUzSLDFrvpftH3kyeYUDGNaAJv4+BmnZEhcl7G2SwUe?=
 =?us-ascii?Q?cwdPcCGlpfsdl9ginkBgdFJXVoZXU+FU3bb3OkLMoWU2dQYgHpTfn0IYa+q5?=
 =?us-ascii?Q?IatHBPhOCd5tEeFYbV1wp6vSFoR6XYkcwfhrWqM89NBCQAvot5pHZq4fiOYq?=
 =?us-ascii?Q?/rm3NVmPuvbTlaBwCskqD12A03PIgJfvuZHikYah120Ccdq4WWUQcF4QBd7z?=
 =?us-ascii?Q?eHq1+tN5qhcrn3C5RpWsEVX9Qkqjkj9V3MfZblKaZaUNH8nVQAsBVvpI3PA6?=
 =?us-ascii?Q?eiNBVWptFQIH5x4iazdheYAczd0uAS4C5nbOGaopAajDVqnz+UmPT7B+O+JF?=
 =?us-ascii?Q?G6Pmy97WScEWmx5gPRTXLTpowYI1Zz+pNCC4oLZz3lQp0tbInfCgOPz2DPVl?=
 =?us-ascii?Q?TC2eQOx2r27AswDt2C7i714VhVxOmou6sh68Rm5KOB7y88V7aApxE5gPq/oh?=
 =?us-ascii?Q?Hy/8oAM5xiS5sISEIORfqUsMNx2riiQod/CUss7c3CMimIQ1KaUQqonx/6up?=
 =?us-ascii?Q?SK0EnEY2TJ7j4LsLkFwqlKVsWf9w8NRLsIsC3baADuLM7l8n1BqPkCFH3+at?=
 =?us-ascii?Q?R21J8q7GeQXQljC89DiIQoDa921wjCrJKt/dV1/ICgerc8sk8Pxz+va4yLTm?=
 =?us-ascii?Q?Lg5xNaJEhd6J/JtUQGAQjAntaz3/zZ1SC8OxFpiJvXMQ0+LgY/yS2e5IcTJp?=
 =?us-ascii?Q?VXdCrB8ENl5Mf/tyT0tuZkonK2nhqiibwWi6zAWA8UbcpQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ABCCBBCFFAAD1549913671D80B9055F4@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a7c370c-ddfe-4849-2a29-08d96c5bc8c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 08:46:11.3939
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: od8PkQ107zJu72b2hpdKcqSy5UIcrNkJTeG4nG9itlgjmiwpehnSTkANhjzErgPei/1F+iH6YugsvM7Rb5SmiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4910
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 31, 2021 at 08:41:36AM +0000, Xiaoliang Yang wrote:
> Hi Vladimir,
>
> On Tue, Aug 31, 2021 at 15:55:26AM +0800, Vladimir Oltean wrote:
> > > +static int vsc9959_mact_stream_set(struct ocelot *ocelot,
> > > +				   struct felix_stream *stream,
> > > +				   struct netlink_ext_ack *extack) {
> > > +	struct ocelot_mact_entry entry;
> > > +	u32 row, col, reg, dst_idx;
> > > +	int ret;
> > > +
> > > +	/* Stream identification desn't support to add a stream with non
> > > +	 * existent MAC (The MAC entry has not been learned in MAC table).
> > > +	 */
> >
> > Who will add the MAC entry to the MAC table in this design? The user?
>
> Yes, The MAC entry is always learned by hardware, user also can add it
> by using "bridge fdb add".
>
> > So if the STREAMDATA entry for this SFID was valid, you mark the MAC ta=
ble
> > entry as static, otherwise you mark it as ageable? Why?
>
> If the MAC entry is learned by hardware, it's marked as ageable. When
> setting the PSFP filter on this stream, it needs to be set to static.
> For example, if the MAC table entry is not set to static, when link is
> down for a period of time, the MAC entry will be forgotten, and SFID
> information will be lost.
> After disable PSFP filter on the stream, there is no need to keep the
> MAC entry static, setting the type back to ageable can cope with
> network topology changes.
>

So if the MAC table entry is ageable, will the TSN stream disappear from
hardware even though it is still present in tc?

I think in previous versions you were automatically installing a static
MAC table entry when one was not present (either it was absent, or the
entry was dynamically learned). Why did that change?=