Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4395738pxb; Tue, 31 Aug 2021 04:13:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTL9t/a6SFcpOxL7nhstSNLLP/onNTC1Kn/ouA35ZAhxHhZSWBmJEw9/QAd8OBkjWsm6ob X-Received: by 2002:a17:906:84d0:: with SMTP id f16mr29759701ejy.6.1630408428510; Tue, 31 Aug 2021 04:13:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630408428; cv=none; d=google.com; s=arc-20160816; b=0FRV8hJdNwpO724vMPzaF8LUEOjPtQzU+JmMlM0NSadXXHhaJ6e7EFhaWrmT0b5A0G veDNtZmdbXw7Qne8qHrzeUMksMf1z+R0wnG65drQeu+upHzA/V/XlhJX2Gi074ARtUvN r6z3ioLNTZbqK9/6xWP8LdasxrS4vjl+bVM6CymiSmVBWp9gfqi/e3FNxfSmOKkktpQv yM/MH84o0lWmHRHQH3nkfYPg7m8rV+S+pfCIrUURabG9k1TiVfQc+SWB0GtTlsF0yjYn l/OPTi6rw+qbLzG5k7dm+BDHre8csuep/VIUFWr4hwH+anoK/SVdtLrLctZUrHLIZguO /60g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=WIlUSU9N9PAA8vEccf8pOKwKn3W2i/ZK1lz+f9lguek=; b=uOLXo0ODpTYAnwm41teMNUme+PMg5f9fTrEkK8y07OUDM7gs7hFCETZv6yim1zOJEl UJ471XcD+xMI+Yfx7ZK2y/eUngagt/cfPBy083XaSbPBOyZ0uhdFdwIQYvykm4Wulmia uwLzMfuOaE7USX6FACH/mvvvbPKedCsy4XsHQrdEX22x1QY9AlnXx5SlKkvmaxoY7uMY zUAfBo3Pfzv4kshZfBCMBqcWGud5Wgujsl+8xOdBTXISDaM1EJa6CUJKm/e1cvNJte4W xFWzEsYEnTqxeCL8fefvdyrVpVUtPoWj4ORbUot6MU3mgjwf0n6o3iTD9bRCrkD1aet/ CmHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=taQzhgpb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d5si15991836ejm.652.2021.08.31.04.13.20; Tue, 31 Aug 2021 04:13:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=taQzhgpb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241444AbhHaLLG (ORCPT + 99 others); Tue, 31 Aug 2021 07:11:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:58694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241420AbhHaLLD (ORCPT ); Tue, 31 Aug 2021 07:11:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 5F2FA61058; Tue, 31 Aug 2021 11:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630408208; bh=6XTiFVpAOU/U5QiTGxTmalseSswMAbrKt9dCYpd7zDE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=taQzhgpbYHMJ8UjsN5eR+CHkGMC0IxXRWA/+EHoGSqprf1pEknB75XRbho5E4snZ7 mb5IVZhwkDmRJo9PFq+mxMolvJZmwP/UkFJLF0DwTC31rkjNscy0Shc6AZs0Tvcowt 6H+nBTwmjo2ge8brzDHojEwOWOJGW0VZbinmrGMlrkHDe+RGhCBUVvG5bSrV2XBWAM x9n5CHiNsyGg5ePEuxpSPSp5s7IWOE+r2d3lFnBYR3oAvarFA+KQfEmtsPQ2+84nd+ 0x8Ej4PnpSpJR6F/94NL470xh8HV2/33/dpGkjn3LohGPnu1b1SkUoAOQNdlF/imxO 3a3DAFuSnC4YA== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 5A33060A9D; Tue, 31 Aug 2021 11:10:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] dpaa2-eth: Replace strlcpy with strscpy From: patchwork-bot+netdevbpf@kernel.org Message-Id: <163040820836.5377.14060243264259649124.git-patchwork-notify@kernel.org> Date: Tue, 31 Aug 2021 11:10:08 +0000 References: <20210830130531.12429-1-wangborong@cdjrlc.com> In-Reply-To: <20210830130531.12429-1-wangborong@cdjrlc.com> To: Jason Wang Cc: davem@davemloft.net, ioana.ciornei@nxp.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 30 Aug 2021 21:05:31 +0800 you wrote: > The strlcpy should not be used because it doesn't limit the source > length. As linus says, it's a completely useless function if you > can't implicitly trust the source string - but that is almost always > why people think they should use it! All in all the BSD function > will lead some potential bugs. > > But the strscpy doesn't require reading memory from the src string > beyond the specified "count" bytes, and since the return value is > easier to error-check than strlcpy()'s. In addition, the implementation > is robust to the string changing out from underneath it, unlike the > current strlcpy() implementation. > > [...] Here is the summary with links: - dpaa2-eth: Replace strlcpy with strscpy https://git.kernel.org/netdev/net-next/c/995786ba0dab You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html