Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4494699pxb; Tue, 31 Aug 2021 06:37:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7rA9IbaOirpYE7UFDXEcJcP9AGpujg7B2yM8ze5VtUxUrW3L4ACwCUmj4eUIiN56wPyFK X-Received: by 2002:a05:6402:781:: with SMTP id d1mr30211783edy.32.1630417072422; Tue, 31 Aug 2021 06:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630417072; cv=none; d=google.com; s=arc-20160816; b=ZJVQf4GOtdheJUXfDXOwToPx1RQhrzwdnQxw2TlBEOwXOtHry28oWcsgT+SNvhR3YX uSKtkW/RQfOEU3mVOffbWhUI/oZ0XXYUXPd9UjE6KhqEDGVVmJTLhVgTxpJrvC2UEviO 8a71biLHhSxpwKz6uKBQCKlvPwr6odM7/b+EobrCYFNcdv+e1vHFOUB81f6ozfW8c34C W33fFcBmsidXEhoN++66nNq8JSxIUvgdQAPS+cbTYOTt2KZ8APDZuYlo/bMVEA24fe0Y ShX7ooeXY7KHIFVt/uRXNUgHtuqxH4cyyq73c0mIzc++1UfYLRryPj5owtr28d38ppQw jiNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=WJhlLrMyhoI4qOo5N9aFjZUNhoU4SIbTyJ71+NMLKX0=; b=HnGAFItzQceeuQXfWcSnngOfwG4E5RH+LdrcmD9DD+I4/jiQybNVglnXH3i9Sieg7P 5ylPwc6KxdAEnei69qcEys+4RgNFx6pIS6CDXX1AaeXShjoseowJE0LV5f1Ktllh1S+5 8uFPT1kjze7TSZPkpoZUHfGQVCGaoXEleB+A6kLMiCt8y2KvOqqlb36AsH78NUC6KpuJ 0Em74huXZxtzsm21WhCqVsA/bnIOCeoD3fcsQCBmc7piDcCktDFnTai79Hw/iewL74W1 nbXg6BXjUNzeDzlXuFjfqVvUomCMCNEDV57Nbev/8ATWzeksSG2icHrbdVj0OKtiZJ96 EuDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si20687198ejr.724.2021.08.31.06.37.05; Tue, 31 Aug 2021 06:37:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234150AbhHaNfL (ORCPT + 99 others); Tue, 31 Aug 2021 09:35:11 -0400 Received: from outbound-smtp50.blacknight.com ([46.22.136.234]:42519 "EHLO outbound-smtp50.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbhHaNfI (ORCPT ); Tue, 31 Aug 2021 09:35:08 -0400 Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp50.blacknight.com (Postfix) with ESMTPS id 4E26EFA9A1 for ; Tue, 31 Aug 2021 14:34:12 +0100 (IST) Received: (qmail 12446 invoked from network); 31 Aug 2021 13:34:12 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 31 Aug 2021 13:34:12 -0000 Date: Tue, 31 Aug 2021 14:34:10 +0100 From: Mel Gorman To: Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm/page_alloc.c: remove meaningless VM_BUG_ON() in pindex_to_order() Message-ID: <20210831133410.GC4128@techsingularity.net> References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210830141051.64090-2-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 10:10:46PM +0800, Miaohe Lin wrote: > It's meaningless to VM_BUG_ON() order != pageblock_order just after > setting order to pageblock_order. Remove it. > > Signed-off-by: Miaohe Lin Acked-by: Mel Gorman -- Mel Gorman SUSE Labs