Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4497912pxb; Tue, 31 Aug 2021 06:42:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1zkIAQrf6oVbermgsIWHbvK3sZA/j+WcBDqjXHVTfxAyDGMFRjjAh/SCbVwTjUCPLSLFo X-Received: by 2002:a6b:c8c7:: with SMTP id y190mr23121447iof.210.1630417340876; Tue, 31 Aug 2021 06:42:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630417340; cv=none; d=google.com; s=arc-20160816; b=HrwQ1vOcc0+XzRhBBADn6xMN6dMmtMWXwyvZtMvmQ/nSXTL+miUxtXj4t79tHNBQTK FTf2ZAszntQeu1VVKrUoVmjR5jeh0MueM+hxX2MKuLy2TPnKtp8jo13woT9Vinxy6hWV ak4lcWMDUEuYRwrzdAEYNpGjjq6Rm02pxIOaS8uPtJwmeLIpjIaJIDVoy0L/TpD1sIxB t/ratVpLZ5G2cCVOTRxOg5I2MVSdk8ObVXK1HfVeK23vtcH3g/H4Z1iYljkvUvEHt1Lt FH7ziHsGcBz3aFFXTioBSog9anhRK1b5eAOwhGyEjEkdy1XnmogLNwsasvOQ9d/ZV44v VI4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=MMjU5rjbhrs8TgyEVzfgDqhBPH5HcbBNFum33Lq+YG8=; b=dgcoZyDtg+ZS4tgiwCc0ph3OBtLxDq4/JKJnqssWpdoCf/2dAxcMGIWpgyZGUO3Vrx ZgdfWOD9XlklIeeD6CCcvWcvIQLo4t3PNs+LZpgyQQRsQkXviPi2DnoM18b6P1u0WxVc b3BMoY6bqAW3ufLBpfCnv5UZysfWlST+IVdzitio3lLtFnCVrvpyGID4ZyXPzO/oqsnA c4p6efnqF4//2sEihyCyFsoWKbtjzL6tmUD3orRtJEqIPV9JIGfvTk/tJ7dxgciXYBJl QrkIKHuP2i8GBTudlNNRekZpEG//Nry1UbrP9upTzEzj86l87/q4/Wcf+5D9XFaEOPNy hVlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si18325841ios.58.2021.08.31.06.42.06; Tue, 31 Aug 2021 06:42:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238283AbhHaNjd (ORCPT + 99 others); Tue, 31 Aug 2021 09:39:33 -0400 Received: from outbound-smtp26.blacknight.com ([81.17.249.194]:55035 "EHLO outbound-smtp26.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238105AbhHaNj3 (ORCPT ); Tue, 31 Aug 2021 09:39:29 -0400 Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp26.blacknight.com (Postfix) with ESMTPS id 8C6F9CAD17 for ; Tue, 31 Aug 2021 14:38:32 +0100 (IST) Received: (qmail 28652 invoked from network); 31 Aug 2021 13:38:32 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 31 Aug 2021 13:38:32 -0000 Date: Tue, 31 Aug 2021 14:38:30 +0100 From: Mel Gorman To: Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] mm/page_alloc.c: remove obsolete comment in free_pcppages_bulk() Message-ID: <20210831133830.GE4128@techsingularity.net> References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210830141051.64090-4-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 10:10:48PM +0800, Miaohe Lin wrote: > It's also confusing now. Remove it. > Why is the whole comment obsolete? The second two paragraphs about "all pages pinned" and pages_scanned is obsolete and can go but the first paragraph is valid. -- Mel Gorman SUSE Labs