Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4504137pxb; Tue, 31 Aug 2021 06:51:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZwvNrMV9adykKF+Kja3ajl3nukih3m9LWc1KJu3S+vC7mTstMwV9P8TM5ryVSL01QmFWR X-Received: by 2002:a50:fd86:: with SMTP id o6mr29840034edt.312.1630417888749; Tue, 31 Aug 2021 06:51:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630417888; cv=none; d=google.com; s=arc-20160816; b=lni9gsPWBy2I44C0jT+u8n8NjuZLyuvybUkYkuiypKUUYdh6CR/rR4FloloiaWnPmK /1VZcdpMVpV7qYVCN4qzKKVImIdoU7zVlmyYfiCCLQwcMqXCZhBK1OSFilr3nWsBx4ik QnNQ2ougLOArfm2njdmQNveZaLhGexNtOFK94FYFdT0eZtCdBlOB8MAiNkGS4ueHb/g/ /4Aei29oQzohJV/gC9pTVqhfjRtv+rjo4h9mWQwI+5oJ1axfopzom3CzR3uaxel61AWT Dtb/mOKmVzvwxnEx77iXy1yGXbzpy9epjeqOHPeUtdMv5rpp3f/hk+yZrF8u5RMoV8q8 UjNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=HeUHkfUk/Hs2C59A6/TUUJIsZA1M5PNUO7ZWX+hYyNo=; b=UHdzK8PDQB6Rt/Ff+m/CMO/CuJwczJ/Pr/gxAK6Qb6lWSIradOzI3UEtDdOCYbiTvB Ml9gO1EOJB/nY1odyWjsi+76Qo8GDfljtNaWwQOpdlzQRl+7fPrWE//OoLQtxAHV7qsT W4Ls/hV8i45Kj95LbnGvBHqe1Vj0yB/QZc616n2xfitOL8A3EDWrMAU3kxhUKAnn5XOI y2c2NQES+X503HaksMjUkXwpZlUG/RXW2lt7X/L4zGF/+wR5nmkgvlIabXmzMUzRcgCx aOrf90UFSl8lXDDzgu1/4mJLOET+bBuSujfs/VawV+TUZgWYJ93IaRA8bGJf0a0XNxYk Lz9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=pa1QMkVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si15581533edq.288.2021.08.31.06.50.48; Tue, 31 Aug 2021 06:51:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=pa1QMkVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbhHaNti (ORCPT + 99 others); Tue, 31 Aug 2021 09:49:38 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:46549 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239065AbhHaNtO (ORCPT ); Tue, 31 Aug 2021 09:49:14 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630417699; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=HeUHkfUk/Hs2C59A6/TUUJIsZA1M5PNUO7ZWX+hYyNo=; b=pa1QMkVlGCbPI8IBd8iU/NtDI962MmViCI0M2GU/YrJfTd7d6VGERvoW0l3fFx1vn1AV8xWp 8TnVq6jCqnxcPPbLqZMH9tMKQzJrLXz4Vo9mhbbJCy/n+108Q+RCA40KyT+u5RbIkZEapkC4 Ndt9o4ErSwXK+FtKH5QkPUW+owA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 612e331e4cd90150378c5669 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 31 Aug 2021 13:48:14 GMT Sender: luoj=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 422AAC43460; Tue, 31 Aug 2021 13:48:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL autolearn=ham autolearn_force=no version=3.4.0 Received: from [192.168.10.117] (unknown [183.192.232.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luoj) by smtp.codeaurora.org (Postfix) with ESMTPSA id E4500C4338F; Tue, 31 Aug 2021 13:48:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org E4500C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH v1 2/3] net: phy: add qca8081 ethernet phy driver To: "Russell King (Oracle)" Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org References: <20210830110733.8964-1-luoj@codeaurora.org> <20210830110733.8964-3-luoj@codeaurora.org> <20210830113950.GX22278@shell.armlinux.org.uk> From: Jie Luo Message-ID: Date: Tue, 31 Aug 2021 21:48:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210830113950.GX22278@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/2021 7:39 PM, Russell King (Oracle) wrote: > On Mon, Aug 30, 2021 at 07:07:32PM +0800, Luo Jie wrote: >> +/* AN 2.5G */ >> +#define QCA808X_FAST_RETRAIN_2500BT BIT(5) >> +#define QCA808X_ADV_LOOP_TIMING BIT(0) >> >> +/* Fast retrain related registers */ >> +#define QCA808X_PHY_MMD1_FAST_RETRAIN_CTL 0x93 >> +#define QCA808X_FAST_RETRAIN_CTRL_VALUE 0x1 > These are standard 802.3 defined registers bits - please add > definitions for them to uapi/linux/mdio.h. > > Thanks. will add definitions for the standard registers in the next patch set, thanks Russell for the comments.