Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210831125843.1233488-1-nsaenzju@redhat.com> <20210831125843.1233488-2-nsaenzju@redhat.com>
In-Reply-To: <20210831125843.1233488-2-nsaenzju@redhat.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 31 Aug 2021 08:50:14 -0500
Message-ID: <CAL_JsqL-CdrAqY_4vnXQfTuSU8GsYzZutyFhZZgm4o3p-qaqFA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: bcm2711-rpi-4-b: Fix usb's unit address
To:     Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc:     Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devicetree@vger.kernel.org,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@broadcom.com>,
        "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Stefan Wahren <stefan.wahren@i2se.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 31, 2021 at 7:59 AM Nicolas Saenz Julienne
<nsaenzju@redhat.com> wrote:
>
> The unit address is supposed to represent '<device>,<function>'. Which
> are both 0 for RPi4b's XHCI controller. On top of that although
> OpenFirmware states bus number goes in the high part of the last reg
> parameter, FDT doesn't seem to care for it[1], so remove it.
>
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633
> Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> ---
>
> Chages since v1:
>  - Add patch as per robh suggestion
>
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>