Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Michael Walle <michael@walle.cc>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of
 phy-connection-type
Thread-Topic: [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of
 phy-connection-type
Thread-Index: AQHXnm3EiJALWCaAGkmp9YI1iG/tB6uNo+kA
Date:   Tue, 31 Aug 2021 13:59:17 +0000
Message-ID: <20210831135916.ccvyc5intxs7rlal@skbuf>
References: <20210831134013.1625527-1-michael@walle.cc>
 <20210831134013.1625527-8-michael@walle.cc>
In-Reply-To: <20210831134013.1625527-8-michael@walle.cc>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iKHScwQkjj5mdAnki6HR+3Q/NIkBTkvafNme0HxofOFzJNR/g54wnm1oMMsK?=
 =?us-ascii?Q?0LQ+T9x/LA6hEG7SZ63nBmkfyRPpx3xc3oE6gwbHYCSfvoU9YAcPg1yhdG2b?=
 =?us-ascii?Q?YYTamMSPxZa6tQnl4YeGCIMJtwUGiTrhtlb2T0bi9bwofRR44bcFWDeH285z?=
 =?us-ascii?Q?JagqkEW7M/4b47D+z0tYOJq4YQ+u2X67kSRc3DCfl6f4Uz9DqrakfxgJJlsq?=
 =?us-ascii?Q?vtfux6JmnvuQqdZyxSh+JAHE9ekd2lbLPrCIew7w8umYWmvNVr/KmPJ6Ct8X?=
 =?us-ascii?Q?fLErsT81Omlyxz7WKCE75PY6PR+KP9dQNpDuShZdoNyNZnQgAo+qvWpBm6wm?=
 =?us-ascii?Q?v0STZK9Il9sbTQEITUyCOVMvfo3HOV1dU5M5dkgIFErWQfFpb7dtJeVKLRLL?=
 =?us-ascii?Q?da/iVbRol/N8FrdmH3gmQ9+bUA3mUJYY0yIvnYqfoSSbOCc0xjM0ozfy6wG/?=
 =?us-ascii?Q?4jvQFZL7lC0wbloYuOPSSx0eL7Csq4VVpCBbQ5cnrCpcc/Xg2W43ksriR3EX?=
 =?us-ascii?Q?LYHCy3+tbtUNJGko1UuhM4GB8jTc4ouJcA85km+Yu6Imdgn7rqMEsHni2BdL?=
 =?us-ascii?Q?dzro6SEc3Kp4p3F5+/YXKF3yxuvNYgodD4PaNthffH1kfiz0JJaAt3hn3Rp/?=
 =?us-ascii?Q?vOi6JBj508bxSEmblkIEFjTqrsOyuHUdjtx4WizKmIMbTQwX6mEYQyhuhMDP?=
 =?us-ascii?Q?WE1xjEf2wSnyHJRt/knAjvAuY78yksIB7tL+xfDG2PId94HiYxQP7Za7cn6k?=
 =?us-ascii?Q?2jey5ykeJElybdE63ExNAu5rFReu3OtCMF4bN3WafeSRQa6U24SaVsY2vccq?=
 =?us-ascii?Q?UVoFf7lIkleY96SbNe9YZ6j+h1V9j+B4o+gPCF9ua0Uu9TN8ASAdHJFr1ZBu?=
 =?us-ascii?Q?hZKCYOlszXVB+L+HXCj1Rf1xb7EZNk0X8ohMncmOK8oBYGKiXVjZlEnDx6oj?=
 =?us-ascii?Q?/gzR5W1nyTNQ7i56ECL+OlKwbMsQJKRhb7c1Ba+lIBU2OrXX/Ra5FCuHkACk?=
 =?us-ascii?Q?t/pwWjrY1KZxRDk8c8w3Lp62nrh55JZvgouq13efOidaLv5nNiLwLeBZxlcA?=
 =?us-ascii?Q?N4q1nd/wfsxe/3lLc754IZAC6SoGEMkynB0Slwq66gQGjQHVe3jUyAE6fgcJ?=
 =?us-ascii?Q?jAFRyu26pDt4lqLe32nFnyzYdP7qaFRjpvnuP6b8V2YHCzMpWdJpCj87CyY8?=
 =?us-ascii?Q?YMjB7I82W6w7P8s/XYrCdmocDJqjRz0hydHgOiw2SFXjXCdZFvsBrQo9Z3QB?=
 =?us-ascii?Q?CsiEAriGSB8YO0uAv49q3HRzRCCVU8HU/sfu4iVbg4c/WVnKIoxv9ggMKcAy?=
 =?us-ascii?Q?O0oc42kgzE7M3J88wq93zVqk?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9A40EE81CC3C6A40A7E8332F6B30024F@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff437862-3dd9-41fc-251a-08d96c878613
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 13:59:17.4822
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZlhsC2ZpnmlC5FUcnjnCmUBfoHxQBni5rPz5Ae5X+zlqAXlNejdiFzWNp/gPUC3Tupd5Mxf9xUSIoVKuviyaGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 31, 2021 at 03:40:13PM +0200, Michael Walle wrote:
> In linux both are identical, phy-mode is used more often, though. Also
> for the ls1028a both phy-connection-type and phy-mode was used, one for
> the enetc nodes and the other for the switch nodes. Unify them. But the
> main reason for this is that the device tree files can be shared with
> the u-boot ones; there the enetc driver only supports the "phy-mode"
> property.
>=20
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---

Actually that is not really a valid reason in itself for this change.
The enetc U-Boot driver is perhaps a bit silly in that it calls
ofnode_read_string(dev_ofnode(dev), "phy-mode") manually, especially
since right below, it uses dm_eth_phy_connect() which searches for both.

So we are artificially restricting what we support. It would be fine to
do the dm_eth_phy_connect first, then use phy->interface for enetc_start_pc=
s().

Anyway, I do not mind the patch at all.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>=