Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210830212951.3541589-1-pgonda@google.com> <CAA03e5Fd2aes=euzXv51d6b3E0S3tK45hkqQhONsmWA5dE33dw@mail.gmail.com>
 <CAA03e5G9TEsmzbQw_m_Zh+Evdief0hgiuMmBGF40xctMAwjY2w@mail.gmail.com> <CAMkAt6r8X5XbhRSbfX5vfHn+F40Mp_Ou+qmtUqeDBCtTF1oTxg@mail.gmail.com>
In-Reply-To: <CAMkAt6r8X5XbhRSbfX5vfHn+F40Mp_Ou+qmtUqeDBCtTF1oTxg@mail.gmail.com>
From:   Marc Orr <marcorr@google.com>
Date:   Tue, 31 Aug 2021 08:20:43 -0700
Message-ID: <CAA03e5Fp2PeY162sL6YVn44an28RBNvbRRF4HLJ_vea9V69Ryg@mail.gmail.com>
Subject: Re: [PATCH 3/3 V6] selftest: KVM: Add intra host migration
To:     Peter Gonda <pgonda@google.com>
Cc:     kvm list <kvm@vger.kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> > > > +
> > > > +       for (i = 0; i < 1000; ++i) {
> > > > +               j = input->source_fds[i % LOCK_TESTING_THREADS];
> > > > +               cap.args[0] = input->source_fds[j];
> > > > +               /*
> > > > +                * Call IOCTL directly without checking return code. We are
> > > > +                * simply trying to confirm there is no deadlock from userspace
> > > > +                * not check correctness of migration here.
> > > > +                */
> > > > +               ioctl(input->vm->fd, KVM_ENABLE_CAP, &cap);
> > >
> > > Should we use `vm_enable_cap()` here?
> > >
>
> I took all other suggestions but this one I just updated the comment.
> vm_enable_cap TEST_ASSERT()s if the ioctl fails. Since we are just
> randomly iterating through a bunch of ioclts we fail often so this
> would kill the test.

Gah, of course! My bad. Anyway, sounds good and thanks!