Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4598109pxb; Tue, 31 Aug 2021 08:49:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhWOWnV6WTv3bjveejjieJGK/8jO0PlGldmRyVWSVkUEvaw0KU2vL5hSCWx5p5UtojST4+ X-Received: by 2002:aa7:cf1a:: with SMTP id a26mr11880620edy.116.1630424962607; Tue, 31 Aug 2021 08:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630424962; cv=none; d=google.com; s=arc-20160816; b=FrZHAujtwOWabpxxut1p4gvKXMVqqjbJw8mCRcYGqxm56Tlb1gFyCTZPBc6RmHFXPR 40zshnFCi/+5Yf3+tGcJphWyWvpdjSz6RoYD5VFe60TXxUkkVYmFXIjH1KtNqM/B5LiB v4oRIEZvewYjGxFNVbJAiuoyLhPnt7dCKK4pZWP9pWmr3unv0p5cBvdw4atTG/w7JVKq 0vKmi1oUJ1OdTaVTKvOfRDCWN58XBe9OvMvfvWWHiYQy2/8jepsfpaDdm0NiJKfuht0B ba8CEeijD87RruXiSdkwvXyj/DVs+Zv5Lqor+CNCJIVsQkXEtmU4/T9J/s1Bxomt+3T9 WDBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=scuK1ehy5HtupVmZPQITLXq3WGLemHWuLYY7u5ziWo0=; b=SjJvpsuNfduMqbjiq2OnJiX1PsVhk5E+zHff/zaEgzEVhnYNzIeq0mLnQgyi9699Sf 1R1dpLG9Tnb2czaPGVqAgT/b8MtPlwtXVqDWT/WapRapvIx5OrFqwf1zx+VGHB9WW5MZ wj+XxAN3QamFhUK5TjgvkjZKFhvg+pCpNuJdjekjUaINZnTmp7scFdjbK5KZKgmwNT3I 8sasYQ25uQzyTe9P5WxO0BDiiJ3ensArErrXeSaezA7qenIU2guUnzFY4e+P/A5Cku6w Pm4AO0ggOkT7kN8Zv1Fpb6gJjBRq/tiTs1B5CmvnjJBRPtjezAXLzDU55sZUig8Cft1h EsqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=bPRwaN5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si851809ejc.511.2021.08.31.08.48.56; Tue, 31 Aug 2021 08:49:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=bPRwaN5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239153AbhHaP2n (ORCPT + 99 others); Tue, 31 Aug 2021 11:28:43 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:27481 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238916AbhHaP2m (ORCPT ); Tue, 31 Aug 2021 11:28:42 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630423667; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=scuK1ehy5HtupVmZPQITLXq3WGLemHWuLYY7u5ziWo0=; b=bPRwaN5DWcvFLRfA4h5DqxUzoz9iidxqVESRwcWsksmnJCi8gB2DxPmvGQ01hl0sCFCrbaCK eTWwWzXpqSfAyQEpHxbkk6RMIMB4gRvCnsfctW0tDDB8Hj0Phl8hiBFptL21wWVzfWBTATj/ sdBaCe0/VzXuGkqDHw+jcv6tilU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 612e4a5de0fcecca190b561f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 31 Aug 2021 15:27:25 GMT Sender: rajpat=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D3E1DC43460; Tue, 31 Aug 2021 15:27:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rajpat) by smtp.codeaurora.org (Postfix) with ESMTPSA id C044FC4338F; Tue, 31 Aug 2021 15:27:22 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Aug 2021 20:57:22 +0530 From: rajpat@codeaurora.org To: Matthias Kaehlcke Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, sboyd@kernel.org Subject: Re: [PATCH V6 4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node In-Reply-To: References: <1629983731-10595-1-git-send-email-rajpat@codeaurora.org> <1629983731-10595-5-git-send-email-rajpat@codeaurora.org> Message-ID: X-Sender: rajpat@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-27 02:31, Matthias Kaehlcke wrote: > On Thu, Aug 26, 2021 at 06:45:28PM +0530, Rajesh Patil wrote: >> From: Roja Rani Yarubandi >> >> Update the compatible string as "qcom,geni-uart". >> Add interconnects and power-domains. Split the pinctrl >> functions and correct the gpio pins. > > You could say that uart5 was formerly treated as special > (dedicated debug uart) and that the change removes this > specialness and makes it look like any other UART. > Okay >> split the pinctrl functions to match with SoC dt > > The message should say that this is about the 7280-idp > >> Signed-off-by: Roja Rani Yarubandi >> Signed-off-by: Rajesh Patil > > The change itself looks good to me, the above are only nits to improve > the commit message, so: > > Reviewed-by: Matthias Kaehlcke