Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: rajpat=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 31 Aug 2021 20:59:42 +0530
From:   rajpat@codeaurora.org
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, rnayak@codeaurora.org,
        saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com,
        skakit@codeaurora.org
Subject: Re: [PATCH V6 7/7] arm64: dts: sc7280: Add aliases for I2C and SPI
In-Reply-To: <CAE-0n538LE+Ln_4j63heVsuADOma5+oD2z6uSiQGdn7qpEhwgA@mail.gmail.com>
References: <1629983731-10595-1-git-send-email-rajpat@codeaurora.org>
 <1629983731-10595-8-git-send-email-rajpat@codeaurora.org>
 <CAE-0n538LE+Ln_4j63heVsuADOma5+oD2z6uSiQGdn7qpEhwgA@mail.gmail.com>
Message-ID: <cc32eeb9de3903aba947064849875d9d@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-08-26 23:42, Stephen Boyd wrote:
> Quoting Rajesh Patil (2021-08-26 06:15:31)
>> Add aliases for i2c and spi for sc7280 soc.
>> 
>> Signed-off-by: Rajesh Patil <rajpat@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 32 
>> ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 32f411f..c659f61 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -28,6 +28,38 @@
>>         aliases {
>>                 mmc1 = &sdhc_1;
>>                 mmc2 = &sdhc_2;
>> +               i2c0 = &i2c0;
>> +               i2c1 = &i2c1;
>> +               i2c2 = &i2c2;
>> +               i2c3 = &i2c3;
>> +               i2c4 = &i2c4;
>> +               i2c5 = &i2c5;
>> +               i2c6 = &i2c6;
>> +               i2c7 = &i2c7;
>> +               i2c8 = &i2c8;
>> +               i2c9 = &i2c9;
>> +               i2c10 = &i2c10;
>> +               i2c11 = &i2c11;
>> +               i2c12 = &i2c12;
>> +               i2c13 = &i2c13;
>> +               i2c14 = &i2c14;
>> +               i2c15 = &i2c15;
> 
> Please alphabet sort this on alias name. "i" before "m"

Okay i will change according to alphabet order
> 
>> +               spi0 = &spi0;
>> +               spi1 = &spi1;
>> +               spi2 = &spi2;
>> +               spi3 = &spi3;
>> +               spi4 = &spi4;
>> +               spi5 = &spi5;
>> +               spi6 = &spi6;
>> +               spi7 = &spi7;
>> +               spi8 = &spi8;
>> +               spi9 = &spi9;
>> +               spi10 = &spi10;
>> +               spi11 = &spi11;
>> +               spi12 = &spi12;
>> +               spi13 = &spi13;
>> +               spi14 = &spi14;
>> +               spi15 = &spi15;
>>         };
>> 
>>         clocks {
>> --