Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <72bc8926dcfc471ce385494f2c8c23398f8761d2.1630415944.git.geert+renesas@glider.be>
 <CACPK8XfyYpWTmaASuG7Jkyp06fRrg_zXvg93JB7igZgVDWjumw@mail.gmail.com>
In-Reply-To: <CACPK8XfyYpWTmaASuG7Jkyp06fRrg_zXvg93JB7igZgVDWjumw@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 31 Aug 2021 17:52:37 +0200
Message-ID: <CAMuHMdUvXKaw0OytAhRWxYL2GKpU6pCOSKgUkj7O-NAGM4PuKg@mail.gmail.com>
Subject: Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX
To:     Joel Stanley <joel@jms.id.au>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Gabriel Somlo <gsomlo@gmail.com>, David Shah <dave@ds0.me>,
        Stafford Horne <shorne@gmail.com>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Joel,

On Tue, Aug 31, 2021 at 3:37 PM Joel Stanley <joel@jms.id.au> wrote:
> On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
> > dependency on LITEX, to prevent asking the user about drivers for these
> > devices when configuring a kernel without LiteX SoC Builder support.
>
> nak.
>
> They can be present on any soc that uses them. We have an example in
> mainline already; microwatt uses liteeth but is not a litex soc.

But liiteeth.c uses <linux/litex.h>?
And https://github.com/enjoy-digital/litex can be used with a microwatt
CPU core?

The idea behind the LITEX config symbol was to gate off any driver
using LiteX interfaces.

> > Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- a/drivers/net/ethernet/litex/Kconfig
> > +++ b/drivers/net/ethernet/litex/Kconfig
> > @@ -5,6 +5,7 @@
> >  config NET_VENDOR_LITEX
> >         bool "LiteX devices"
> >         default y
> > +       depends on LITEX || COMPILE_TEST
> >         help
> >           If you have a network (Ethernet) card belonging to this class, say Y.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds