Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "kjain@linux.ibm.com" <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 1/3] perf: enable branch record for software
 events
Thread-Topic: [PATCH v3 bpf-next 1/3] perf: enable branch record for software
 events
Thread-Index: AQHXnefK6Dg/bsQBhE+Mc9IkeTmV3KuNvMEAgAANe4A=
Date:   Tue, 31 Aug 2021 16:12:42 +0000
Message-ID: <D4CBDC8C-ADBF-4EF9-9CE8-169D0052A3F7@fb.com>
References: <20210830214106.4142056-1-songliubraving@fb.com>
 <20210830214106.4142056-2-songliubraving@fb.com>
 <YS5Jqr60qHZ14+2g@hirez.programming.kicks-ass.net>
In-Reply-To: <YS5Jqr60qHZ14+2g@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jHDtmA/1ax/IPciLSyZkUtR8ErXLF0gMv9/oESC2DECP7GhqVN8xH5jkqxT2?=
 =?us-ascii?Q?wc8s3Ob7ZktqBIfk5RVFZ380z6rkfYmaY+aowyqU4RhMSfK86sg25fmQns7k?=
 =?us-ascii?Q?+OSqDVXXdGTNtl5mSN1wU5sZ86RWr4/gZRJn66IY1JA1LE7cr37l13H5YdlD?=
 =?us-ascii?Q?ucRDoacICWP/FqBNf0PtxZLyQSUlPWw/52GzPxwgkAIZys2sr1FQdRwG8+0x?=
 =?us-ascii?Q?cYBsqHaM4uvcSKvmwesi6VNa8YR0krKw3LGEftJngEKQYVy6XuyS9i1cl1+a?=
 =?us-ascii?Q?mWXFlQj9sf5V1/xuH4+gKBWAUz1b+VbODy9cvFDUUK4CBA1tlrg4/ywKM6FX?=
 =?us-ascii?Q?iHJR6eoQIuL4zhdVLB8H1IDLtzif7aRuDJP2c0OvtQnIdiicubVh6ZImOrp8?=
 =?us-ascii?Q?DHmM6Y4/5o33sWXUGbdmqmZytfoNp2VLzbDcYdobAliMNKFjWDCb1s19dgPc?=
 =?us-ascii?Q?UbjL1NGKGkGJPNE4i2wGDfwUY9AQeqd5r1N0KqOsr8Ik2ORe0xxr8F/wWx2x?=
 =?us-ascii?Q?hdGgzsXEAcXJHrLKsQIJSTv+QC2QA/EIgDe3GoAp9wvq7gYtYJyKsmhAsl1o?=
 =?us-ascii?Q?Yu5AmRPzl0VhLNyn0akaxQf/1CRgcWxzPzj9KfcVzbcPUeO5rgNgH4l4hsjv?=
 =?us-ascii?Q?DTCh+IRwh/Ch5NJUya4XFtwnfMppRREsCEIClHGo2mMakEut80UbPoHnyKgZ?=
 =?us-ascii?Q?MqalMqYjuh0zMae/dLNO9GEuyrME9VpnE+m+i4l6fI/fdDLuOW6S/hGt7Dif?=
 =?us-ascii?Q?c2cO1ZHuyNm6LhPPWrCQVw9BHwTq5ne0xD2F7ud2TtYYhs0WcmeSZ4Dlx+3A?=
 =?us-ascii?Q?4GzEbFkbQLtlt5kLox4q70tBnT7yqWuxFcxV8FTKIasEAs+pvmkYyCfQhg3T?=
 =?us-ascii?Q?EwImYwUEqa6AoqdGwY+gWL46aMVDCIjFUCxE/E2tdv6ydx3aJlMpu8TKP+Ws?=
 =?us-ascii?Q?GCYEW8u8hPyeZSoxbDC54E2Ky69hLc5fe49roGU9ezZSToDNN9ZPjVlFOXV5?=
 =?us-ascii?Q?GQ2fVvi4gv2fQMsavmGKIeRLtSHEULnK6CXH3Q804v++vjBRrq7toLdw3Bji?=
 =?us-ascii?Q?/9jmadDmASBGQGZx9TtYUD3mqOPBSb2qwom9hCX4GYENmV/1CCDazx/HOTnp?=
 =?us-ascii?Q?WZpBM4+H99BZtsr1RkphA0ZGmSrR5i6Z3jsdtwQDm97yAFWYdqwCIdoYV3+I?=
 =?us-ascii?Q?/YDkF1YcLyDaVMDR/ZTaMQdvoji4JVNL+3ulj3Svmo5Dfy+3iz1A600hH1F7?=
 =?us-ascii?Q?ljvDd7UzW+BPsn0yzLOv82yW/3e1z56+bjAWzIGdgltjEK2/wMLyDDipenI3?=
 =?us-ascii?Q?hC7DjNAbFuIcpqisYYKgZAhhK/x7ejJu4O4InJr+Lc1Gfyuw+hqfV8fkV5Um?=
 =?us-ascii?Q?UNczofE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <194A943B25F4DF4590B11A185CD54BA5@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ade87916-df26-479d-3c8d-08d96c9a294a
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 16:12:42.2473
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f4Z1ULrBxJFwn5ZHrJ+czaeU6Voqg9X02W5XqxOmaFxqokooQ+KY40PUIQN8k4JJdQ2Y814otbiJvrTMnznz7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5062
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: GAXMt0YErCmIaSCDGc8BJJhpHynqaCou
X-Proofpoint-ORIG-GUID: GAXMt0YErCmIaSCDGc8BJJhpHynqaCou
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-08-31_07:2021-08-31,2021-08-31 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0
 lowpriorityscore=0 adultscore=0 malwarescore=0 priorityscore=1501
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 spamscore=0
 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2107140000 definitions=main-2108310087
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 31, 2021, at 8:24 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Mon, Aug 30, 2021 at 02:41:04PM -0700, Song Liu wrote:
> 
>> diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
>> index ac6fd2dabf6a2..d28d0e12c112c 100644
>> --- a/arch/x86/events/intel/core.c
>> +++ b/arch/x86/events/intel/core.c
>> @@ -2155,9 +2155,9 @@ static void __intel_pmu_disable_all(void)
>> 
>> static void intel_pmu_disable_all(void)
>> {
>> +	intel_pmu_lbr_disable_all();
>> 	__intel_pmu_disable_all();
>> 	intel_pmu_pebs_disable_all();
>> -	intel_pmu_lbr_disable_all();
>> }
> 
> Hurmph... I'm not sure about that, I'd rather you sprinkle a few
> __always_inline to ensure no actual function is called while you disable
> things in the correct order.
> 
> You now still have a hole vs PMI.

Hmm... I will move this back and try some inlining. It may require moving
some functions from ds.c/lbr.c to arch/x86/events/perf_event.h. But I guess
that is OK, as there are similar functions in the header. 

Thanks,
Song