Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V6 1/1] interconnect: intel: Add Keem Bay noc driver
To:     pandith.n@intel.com, georgi.djakov@linaro.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     mgross@linux.intel.com, furong.zhou@intel.com,
        mallikarjunappa.sangannavar@intel.com,
        lakshmi.bai.raja.subramanian@intel.com
References: <20210831063615.1021-1-pandith.n@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <986f25c1-a6ce-f142-018b-88ee0c237943@infradead.org>
Date:   Tue, 31 Aug 2021 09:15:37 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210831063615.1021-1-pandith.n@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 8/30/21 11:36 PM, pandith.n@intel.com wrote:
> diff --git a/drivers/interconnect/intel/Kconfig b/drivers/interconnect/intel/Kconfig
> new file mode 100644
> index 000000000000..a2f933773380
> --- /dev/null
> +++ b/drivers/interconnect/intel/Kconfig
> @@ -0,0 +1,19 @@
> +# Copyright (C) 2019 Intel Corporation
> +# SPDX-License-Identifier: GPL-2.0-only
> +config INTERCONNECT_INTEL
> +	bool "Intel Network-on-chip interconnect drivers"
> +	help
> +	  Support for Intel's Network on chip interconnect hardware.
> +
> +config INTERCONNECT_INTEL_KEEMBAY
> +	tristate "Intel Keem Bay Enable DDR profiling using NOC"
> +	depends on INTERCONNECT_INTEL || ARCH_KEEMBAY || COMPILE_TEST
> +	help
> +	  Enable this option for DDR bandwidth measurements using NOC

	                                                          NOC.

> +
> +	  Add support for Network-on-chip (NOC) in DDR Subsystem(DSS).

	                                               Subsystem (DSS).

> +	  DSS NOC has capabilities to enable and get statistics profiling.
> +	  NOC driver enables features to configure and capture NOC probe
> +          counters, needed for DSS bandwidth measurement.

Indent above with tab + 2 spaces instead of many spaces.

> +	  Say Y if using a processor that includes the Intel VPU such as
> +	  Keem Bay.  If unsure, say N.


-- 
~Randy