Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/3] iommu/amd: Fix unable to handle page fault due to
 AVIC
To:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Cc:     joro@8bytes.org, Jon.Grimm@amd.com, wei.huang2@amd.com
References: <20210820202957.187572-1-suravee.suthikulpanit@amd.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
Message-ID: <f2ec4e5c-3bb1-b703-8842-34357e084bad@amd.com>
Date:   Tue, 31 Aug 2021 12:10:27 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20210820202957.187572-1-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXU4cHZYTlArV2N4MmJKVFJXSE93eG5qQkVwWFZtajhPZXJFNk1waWF3dFM4?=
 =?utf-8?B?Wmx6SEk2WmwvUnd1YmR0SEF5Z0dpeDVsaVlVYWIveXhWRUJKRS9vUTdpWTNz?=
 =?utf-8?B?ZGc0Q0dDdGY1N3UvV0ZJQ3F0VmlndWNTS0c0MWtDSnBWSzRPam15VFlDUjNU?=
 =?utf-8?B?cStvUnFRRDErMmNEaC9YZ0MxUHo4Qlp4TTR4a3NTQmFTNTJEaWc4eWxaeWlO?=
 =?utf-8?B?Qm1hQ2JqYTRjUVdtK2dVYmQ1ZWZ5OVQyRGtZMjRkeUFpc2psZndLMlM5VHJU?=
 =?utf-8?B?MWxpS1p3MElDUDZNcGZPSExrSUliWUU4aWxWVHhlbDFjZ0RzZXRHMndCV2pn?=
 =?utf-8?B?eHowN01iaDJTK0tOME5ZaEgyYnh1MWhScWZ2c1I3OVJlaFlkd3d6VGh1YS9D?=
 =?utf-8?B?cjdvdGZqZEJhYStMTnVGTC9PM29QSlFYYjNMTWgyZEk4S2UyWGZEYjVnbmUv?=
 =?utf-8?B?a1hacGNmNXp0SGdtY0NzOUIvMFdTZ0t2V2ZBNSttT3BaZ2VOcTBkYjJWanha?=
 =?utf-8?B?dXc5ZE5kTjBQZW83RmRlS3dLV3JmNkhZYWlrN2NvM29RdCtkbFZiak13MTA3?=
 =?utf-8?B?WEltMjV2R0M0K2lxdU1BbG5sSGxKMlBza1cvZnd4RzRjTW1aS21mSVMyaTBp?=
 =?utf-8?B?T2J0Y3VoQ1g3bUc3aFRHdHVXMjZKcVNKLzR6RnBEbHBLWndpbTBaR3Zpa0tI?=
 =?utf-8?B?WU5lNTdnc3duTWpsV0JaclhGTk1tYnc3V0hLTzdYUG9FY24rMjNUSndDalpv?=
 =?utf-8?B?cVJ0cnpUREgvYU9pRlRsMURFajN4djNWQnZFaWRndjZGUEllRG5hVnNxYUxW?=
 =?utf-8?B?QkJCejZwT2VJbXQ2cE40TTBUSExuemN1bVVqSUFXd0JDZHNkbUI4MnhZZzAw?=
 =?utf-8?B?UjE4UW9QRTVJVnFySjBnZ3ViRUZDQ3lWbUxtMVFlNGMvZXBDQXFBMDQwNVV4?=
 =?utf-8?B?RldDQzRKcGZtOE5EZ0tUZXpoT0s5ajdjMkdzM1NvSlNiZnIva2VtamdMZjdX?=
 =?utf-8?B?S1dwSzJXZUFScjBiQTNEcXFVaE00VHJMeDQ3c3dNQTV1QzQ0b0xNc3Rla3dp?=
 =?utf-8?B?SVExQmVpSllaLzRSb29yb0JqUkRPOUFuL0pXMEJ3eWVta3ltZDdUNmVQZmE1?=
 =?utf-8?B?K2E4VUlxdU5uY1lYNmYzYnRrVlNXcjRzbEdCcS9iMzBKRWgyMzAvMnNVTWdL?=
 =?utf-8?B?MG4waER6UEFIQUhuTDJjOGlEeG43YWpKMU5ma3Jta2lYNEtjM3c0bWpXVU9F?=
 =?utf-8?B?cTV1N3Rsa1hRTFZ6Y2hKWVBCS256ZUhjdjdjNjBEbUVSaC9WNTFSSlFGUTRh?=
 =?utf-8?B?OVhuaHhuREphb0NTQTVEcEtpVksvenZqWG45WmVhT0h4VnRGem1lYUUrSGtS?=
 =?utf-8?B?VFRYL2M5SGs0cGpFTUFxR00zN2NKNkRvYVRwS1BBcGhuVHBrRyt0Y0tKMCtF?=
 =?utf-8?B?NENVekRDMkMwTFNDYzlOOHdNblZlMDZhQzZ5UWNrNkpEVFNzRnM0dDdyWEh5?=
 =?utf-8?B?NU1hUm41TmNKOFhlTHdCdUxndzlNZElJN3ZyNGo0aVo5WkJwNFJub3hQS1BT?=
 =?utf-8?B?d0VwcmtWMkxiZzhBcmZmdVVDRUJwN0VDYStlZ29HZGxmcEI0VkpXODk5L3RY?=
 =?utf-8?B?NGJpc3NXMTRETmZBbVhKQ0p5cms2VlBwUlpWaWxya2p1WU9ONFBWeVpUYml5?=
 =?utf-8?B?a3g1WVc3ZDNjMEJxT3VkKzJrRjRnSm1wK1RYTG1hODJwZGJYV1A0UFNETUwv?=
 =?utf-8?Q?D7cMHbtz7VSRyOlnI3ptfbpjdpbqTbu6ZeuCyER?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1818a751-b982-4096-25b1-08d96ca23b96
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2021 17:10:29.0769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vlzry1MN8s/Wobt41w1pW+ER5GQLjezPEZ7oAx4yH/jchd2JsolSzedkXgSjWqaFwn9QXETzZdRAWVsd3w+Drw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5360
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Joerg,

Here is an dditional tags for this series:

Fixes: 8bda0cfbdc1a ("iommu/amd: Detect and initialize guest vAPIC log")

Are there any concerns with this series?

Thanks
Suravee

On 8/20/2021 3:29 PM, Suravee Suthikulpanit wrote:
> This bug is triggered when rebooting VM on a system which
> SVM AVIC is enabled but IOMMU AVIC is disabled in the BIOS.
> 
> The series reworks interrupt remapping intialiation to
> check for IOMMU AVIC support (GAMSup) at earlier stage using
> EFR provided by IVRS table instead of the PCI MMIO register,
> which is available after PCI support for IOMMU is initialized.
> This helps avoid having to disable and clean up the already
> initialized interrupt-remapping-related parameter.
> 
> Thanks,
> Suravee
> 
> Suravee Suthikulpanit (2):
>    iommu/amd: Introduce helper function to check feature bit on all
>      IOMMUs
>    iommu/amd: Remove iommu_init_ga()
> 
> Wei Huang (1):
>    iommu/amd: Relocate GAMSup check to early_enable_iommus
> 
>   drivers/iommu/amd/init.c | 45 ++++++++++++++++++++++------------------
>   1 file changed, 25 insertions(+), 20 deletions(-)
>