Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 31 Aug 2021 14:49:58 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To:     Will Deacon <will@kernel.org>
Cc:     Claire Chang <tientzu@chromium.org>, hch@lst.de,
        m.szyprowski@samsung.com, robin.murphy@arm.com,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        linux@roeck-us.net
Subject: Re: [PATCH] swiotlb: use depends on for DMA_RESTRICTED_POOL
Message-ID: <YS551niE8F5HzIaw@localhost.localdomain>
References: <20210827034802.1065294-1-tientzu@chromium.org>
 <20210831151746.GB32001@willie-the-truck>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210831151746.GB32001@willie-the-truck>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (130.44.160.152) by MN2PR11CA0002.namprd11.prod.outlook.com (2603:10b6:208:23b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.21 via Frontend Transport; Tue, 31 Aug 2021 18:50:01 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e6382b4-83f1-4778-88da-08d96cb0242f
X-MS-TrafficTypeDiagnostic: SJ0PR10MB4432:
X-Microsoft-Antispam-PRVS: <SJ0PR10MB443220C3BC260E1849DE364B89CC9@SJ0PR10MB4432.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1091;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: i7DPgJexKdGx4uWIiqTZI0wAQ/HI76Z33xzvfn5qb8Fnx8SspxD50Y/tprlQBAAppBhqbpRtqrND4hAcQ7c/s6LSFkdi0BJrxCZCve8dYqNcbVgUgfAOxtAhYq9Hs/Ou1lLlFZZuaXmoXHnWCTFfrri/kYZXOtdixVlVs/nHLsINXqTE86RnOVn9RkeVFRrjzuGIlAJ5MvLChdGhShN8A+sPhacBO4uHBk+K8wQZnDEXPeVGtjsj9D0K8t8x0TG/N4f3xeZ/RcEoKznGC8OdPOi5mDvzZg5v9Oy0501HXP17vTAwW2ZxvjD1RjuF6TEajSnWOhHbsWovIZzoTYabgS/zPjcOV4SAXZK+hurzHW0QY2ZHA9Z0wUD9XZoxIH9LNydlmyEVLze5XgIzr4WCf+RMyECRmXNFFDS+dgvTBrSUUmIp51ObpjHMjGVrif2VDcrCfTJRL7mpmNv/axPJzPEybgWMBmXYWmkyGwrfxh9+4KDZhvnY7bI7DBei/OenvgNRMvQdhuOEihA6HtkQo404P9hR+cFCpg5/W31NxqWsG8+6Mrv4+O3o3NRWza0cY9yWRLl4di15dlVKg3bAspfRBWOzrhxc8V1d9neelLNstkZav8VNxortyAwWJSXCZhDgAd4bDl2cu9cPSTfsIK/4a74oKYPV9KxC4W3Ic0kdCn7Shy+qOL0YVie4e103Pzb4x6zlMIJWQWVMApdoqQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(346002)(366004)(39860400002)(136003)(5660300002)(83380400001)(2906002)(478600001)(86362001)(316002)(956004)(8676002)(9686003)(8936002)(55016002)(38100700002)(6666004)(26005)(6916009)(52116002)(38350700002)(186003)(66946007)(7696005)(66476007)(4326008)(66556008)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j3UFpt4SWDR/cRm++HkSlzoP/kpXHi7KGHqdM5avmFmkXjHnB72qgOPvEprZ?=
 =?us-ascii?Q?ZrE1erhoddXBJoCfZAArNqtgIZMBzT4gigiB/meFyBr8iJp7OZKbsSfKIVLu?=
 =?us-ascii?Q?3PZRVyMd4aHZ0WvlCo09B2KEpJ2PiHclzYhVR/5zunoJwGLb4DSiEotdXLvn?=
 =?us-ascii?Q?DJJvnYBCq/SDd1DriiRGkLPI4PSeoLRn9VBw5QpDqaS1WZ7Vcbq010ZYZp/d?=
 =?us-ascii?Q?u6AW6HWuuNcx/b6WJ3IAbFZU/7uBwQ/XRYXpbUub/aQ0NjheuS+EyTGJO96L?=
 =?us-ascii?Q?7cL52yYfVPEYZ8A81QTyb6cbF/MtngaiIA6JawDbqDEJ3qgStGYcLJJd9aAX?=
 =?us-ascii?Q?HoA6jyqU87XpRCjCu4ZMQmjbn5sQf1C1nA4OH1Wlye7rMYuRkFHMsylhQFWV?=
 =?us-ascii?Q?Sv4pVlvzljoRkN9RwVwLQm1V7kAgZWL/NxDgduAxOyoVuCTBXJpqGJV4dcKL?=
 =?us-ascii?Q?+KSawqDn+89GgxCXiHVgndDaRkZqjYQCq4y5NBWooEieOAYvm9mCEzCDDOT7?=
 =?us-ascii?Q?x7fl+o3+l4rGGNtkO/jkvUw3Ur9T6u5BcJgdloSl+PZ/kcMw8TcEPUX05n//?=
 =?us-ascii?Q?MGFEtp6iQij0IdGTzDgmiUfBQZPEB2wRiAaCVhflEziB2NpFQgiLDqYNimQW?=
 =?us-ascii?Q?wnKbd+0pplQ7JHiShuE8kHqts6n2kFBYY+KaVEHaxsY8+A9NFaan7LOaFVkf?=
 =?us-ascii?Q?EddnKn54eQR2jAk/u4ABP9uL44VdK+34r09R4HecMxOdSUvpCu28dCQA0j5x?=
 =?us-ascii?Q?1rJVTC9GtIEmAUBvhbBCddv+PHEAFqZDCtBNfVUBm/iVXPlApu7vnCWI/CIJ?=
 =?us-ascii?Q?QhxIsRUWZuiF7Gbv7LxtOoOqhUZJZM3KN37y0sVZeVGyEC5VRo5Pqmj/Jp5h?=
 =?us-ascii?Q?tQEWnAi4EOj3VZ8h70zJDsKtSiECZOGjIvUNhHpN7FsOCXBNxYkm15Hpzyqw?=
 =?us-ascii?Q?JLsTjPVAdRV+8teCblo9PhAcN8huzThg9OGXAUI0T8r6yz5n9oT6UlGcp+TU?=
 =?us-ascii?Q?ZF0eWWX9YknR9V5Cyr5/2FEsgww5T/0PRhEbc/TYaSi7RK/6rim6B01yjGXf?=
 =?us-ascii?Q?wm+t65lP6MiUx4oVvha3JXsVzY24lebe4zXbPWvJv4AnZg0zqdYDnPMOIkpO?=
 =?us-ascii?Q?yvPLLByQ2Gtz8MnyjVgSQveA8Jd+CkcHDfDL6I5ogVEINivSWhegGCugzu0K?=
 =?us-ascii?Q?T7Bluk2skqY+myPMcJZppex7gcK6K06XPQRBOD4W6iAe0O3mgaCT98X37oKL?=
 =?us-ascii?Q?cqinDgoMcaQFpZWW+0DmZiG87QGpAwipYvDaj/1CJpxIxIR9FuY+9TgURH8c?=
 =?us-ascii?Q?PJsjmB0+ITCCBzL+enLmxvni?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e6382b4-83f1-4778-88da-08d96cb0242f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2021 18:50:02.8393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P+04csIlkC8vpILov5A+Ld9Z07Q2z8U2e5ghuoKqC8txhMudU8xirg6h4P+/dhqDlXmRuCOF9eG9RnTBKMMvcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4432
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10093 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108310103
X-Proofpoint-GUID: eSh9bh8ughdRcKPlBrGrXzKkapqQgDUS
X-Proofpoint-ORIG-GUID: eSh9bh8ughdRcKPlBrGrXzKkapqQgDUS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 31, 2021 at 04:17:47PM +0100, Will Deacon wrote:
> On Fri, Aug 27, 2021 at 11:48:02AM +0800, Claire Chang wrote:
> > Use depends on instead of select for DMA_RESTRICTED_POOL; otherwise it
> > will make SWIOTLB user configurable and cause compile errors for some
> > arch (e.g. mips).
> > 
> > Fixes: 0b84e4f8b793 ("swiotlb: Add restricted DMA pool initialization")
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Claire Chang <tientzu@chromium.org>
> > ---
> >  kernel/dma/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
> > index fd4db714d86b..1b02179758cb 100644
> > --- a/kernel/dma/Kconfig
> > +++ b/kernel/dma/Kconfig
> > @@ -82,8 +82,7 @@ config SWIOTLB
> >  
> >  config DMA_RESTRICTED_POOL
> >  	bool "DMA Restricted Pool"
> > -	depends on OF && OF_RESERVED_MEM
> > -	select SWIOTLB
> > +	depends on OF && OF_RESERVED_MEM && SWIOTLB
> >  	help
> >  	  This enables support for restricted DMA pools which provide a level of
> >  	  DMA memory protection on systems with limited hardware protection
> 
> Acked-by: Will Deacon <will@kernel.org>

I put it in linux-next and devel/for-linus-5.15.

I will wait a day and see if there are any issues with linux-next and if
not will send out a GIT pull.

Thanks!


> 
> Will