Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 31 Aug 2021 14:04:40 -0500
From:   Rob Herring <robh@kernel.org>
To:     Navin Sankar Velliangiri <navin@linumiz.com>
Cc:     linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, a.zummo@towertech.it,
        alexandre.belloni@bootlin.com
Subject: Re: [PATCH] rtc: bq32000: Add TI BQ32002 compatible
Message-ID: <YS59SDh1/mkpBpEJ@robh.at.kernel.org>
References: <20210831074922.273809-1-navin@linumiz.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210831074922.273809-1-navin@linumiz.com>
Precedence: bulk

On Tue, Aug 31, 2021 at 01:19:22PM +0530, Navin Sankar Velliangiri wrote:
> The TI BQ32002 is software compatible with the TI BQ32000,
> add DT compatible entries
> 
> Signed-off-by: Navin Sankar Velliangiri <navin@linumiz.com>
> ---
>  Documentation/devicetree/bindings/rtc/ti,bq32000.yaml | 11 +++++++++++
>  drivers/rtc/rtc-bq32k.c                               |  2 ++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> index bf9c1c4ddb7e..2ddf1cc097d8 100644
> --- a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> +++ b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> @@ -15,6 +15,7 @@ allOf:
>  properties:
>    compatible:
>      const: ti,bq32000
> +    const: ti,bq32002

'enum' is what you want here.

>  
>    reg:
>      const: 0x68
> @@ -35,6 +36,16 @@ required:
>  
>  additionalProperties: false
>  
> +if:
> +  properties:
> +     compatible:
> +       items:

Use 'contains'

> +         - const: ti,bq32002
> +then:
> +  properties:
> +    trickle-resistor-ohms: false
> +    trickle-diode-disable: false
> +
>  examples:
>    - |
>      i2c {
> diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
> index 2235c968842d..a167a6afdc7e 100644
> --- a/drivers/rtc/rtc-bq32k.c
> +++ b/drivers/rtc/rtc-bq32k.c
> @@ -307,12 +307,14 @@ static int bq32k_remove(struct i2c_client *client)
>  
>  static const struct i2c_device_id bq32k_id[] = {
>  	{ "bq32000", 0 },
> +	{ "bq32002", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, bq32k_id);
>  
>  static const __maybe_unused struct of_device_id bq32k_of_match[] = {
>  	{ .compatible = "ti,bq32000" },
> +	{ .compatible = "ti,bq32002" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, bq32k_of_match);
> -- 
> 2.32.0
> 
>