Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp43352pxb; Tue, 31 Aug 2021 14:40:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwukAQ5NUXQStVHpfsSWL1WBaky42zxdglpV8HMaNmTKS6dl5nh52yale93gbEJlB+4AVsX X-Received: by 2002:a5d:8d1a:: with SMTP id p26mr9472586ioj.141.1630446056472; Tue, 31 Aug 2021 14:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630446056; cv=none; d=google.com; s=arc-20160816; b=rxLUJywRX+ADbzOsvanv0Z486utc2xiuCKMLYuOdQGidh0GJmMe0Ocoz8qt1HzyNIO n0BEIYNuzcjG+8/qpRRWP5TmZJPttR8vN0uTxiZk+w/kqZIrlvkDy9oZEQbAoyT/K/fU Ph54Q6sjNXJQb05l3eC4eoV/zkUiGhbAnAhaOhE71/aXqNWJa5XNhLrnrPgxuBnqLzy+ BpBakBBAhK3Ux7Su18+qfo4Uk+r9cbx4XmMhbn8hg4b3Hf9jvh4k9QoU45kp3Pb5+a2r lfVy+xNdMZSZ+4mKywET5fSKD6ouXRVIU7K5AV6Um+nrwIwgZLsqkoivHa5TTxBAjcVI cNjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sjbtl7/bR4B+9kD2SmTDGZiIY4w3jh++mR5WOxCtO2c=; b=Qj3/tm8Jgjrk04GqEOApZiaUUAl3CBqFfXgHcFpPoMUO+MpWvId8KEO9dtN6YdHXru elLQQUB+xGtWJVxupYYb3i7W9TpcxIsr29QJrVn2CYG5aNUReyumNIE7/Bl7eGf/uRRL b5RyX0mb4qgINVcUWVkFB/hSOEf9+wKCyoEjoxT0BTcSNKmVLHvH8snZ28/bhCSk7e+L 4O+ODWsyuznKWTC+TxEHPHyL9i2hBrNhaROPSJ4GcAs6xKMHzE8weybJlHKcvy+auyCQ XJiBlq5gwzShLuMUnp6DXKDjf0PKHUFujdpv8wNqTnz/jzL/zXgW/KEnznmcUsoaoipZ lbZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ib9VzZNv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si18722842jaf.48.2021.08.31.14.40.44; Tue, 31 Aug 2021 14:40:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ib9VzZNv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240753AbhHaT0A (ORCPT + 99 others); Tue, 31 Aug 2021 15:26:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:41216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231952AbhHaT0A (ORCPT ); Tue, 31 Aug 2021 15:26:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D26F61041; Tue, 31 Aug 2021 19:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630437904; bh=LfTYo29aM8dEHYTzt+wGMSKyqaEeeay0p+2H1UYZ30c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ib9VzZNveg+hsvzL/JD6x5/M7xGvAuvxiaLDW+1jn5cH2+jZnpQDMAZuSf9LfaNH/ o4cQbgmANz+9SeYrQmA0/HUb9W/MUsJBN+AwTAme2tL9lWJoBzc22lq6/C501pR3MK r0pw3c2xAlfBLNCe//MLtNNTSe7FXVHHbpvWWWKpXMe89xdTFCECdumqfZUyfjavPZ I9Vl/Y9f7RpB1WRYG2MvuAn/8uKKMeFMb3PkxTrsgWFpZURNzQ80dJD7a4KBaNeYFd VWy5HobBZAqBuvFyAQg8F7yHKRkkFjCkMRXx3fVy68OTalDS3DU5sF8ni/lFls+S0M 9ZOa6X5NDhowA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DE65B4007E; Tue, 31 Aug 2021 16:25:01 -0300 (-03) Date: Tue, 31 Aug 2021 16:25:01 -0300 From: Arnaldo Carvalho de Melo To: Riccardo Mancini Cc: Ian Rogers , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [RFC PATCH v1 14/37] perf evsel: remove retry_sample_id goto label Message-ID: References: <340af0d03408d6621fd9c742e311db18b3585b3b.1629490974.git.rickyman7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <340af0d03408d6621fd9c742e311db18b3585b3b.1629490974.git.rickyman7@gmail.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Aug 21, 2021 at 11:19:20AM +0200, Riccardo Mancini escreveu: > As far as I can tell, there is no good reason, apart from optimization > to have the retry_sample_id separate from fallback_missing_features. > Probably, this label was added to avoid reapplying patches for missing > features that had already been applied. > However, missing features that have been added later have not used this > optimization, always jumping to fallback_missing_features and reapplying > all missing features. > > This patch removes that label, replacing it with > fallback_missing_features. Fair enough, applied, - Arnaldo > Signed-off-by: Riccardo Mancini > --- > tools/perf/util/evsel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index f61e5dd53f5d2859..7b4bb3229a16524e 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -1825,7 +1825,6 @@ static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus, > evsel->core.attr.bpf_event = 0; > if (perf_missing_features.branch_hw_idx) > evsel->core.attr.branch_sample_type &= ~PERF_SAMPLE_BRANCH_HW_INDEX; > -retry_sample_id: > if (perf_missing_features.sample_id_all) > evsel->core.attr.sample_id_all = 0; > > @@ -2006,7 +2005,7 @@ static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus, > } else if (!perf_missing_features.sample_id_all) { > perf_missing_features.sample_id_all = true; > pr_debug2_peo("switching off sample_id_all\n"); > - goto retry_sample_id; > + goto fallback_missing_features; > } else if (!perf_missing_features.lbr_flags && > (evsel->core.attr.branch_sample_type & > (PERF_SAMPLE_BRANCH_NO_CYCLES | > -- > 2.31.1 -- - Arnaldo