Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Tue, 31 Aug 2021 12:59:27 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Zhang Qiao <zhangqiao22@huawei.com>
Cc:     peterz@infradead.org, juri.lelli@redhat.com,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        vincent.guittot@linaro.org
Subject: Re: [PATCH] kernel/sched: Fix sched_fork() access an invalid
 sched_task_group
Message-ID: <YS60T2bfLpxb6SUY@slm.duckdns.org>
References: <20210826112635.7404-1-zhangqiao22@huawei.com>
 <YSztujInfNNXkG5/@hirez.programming.kicks-ass.net>
 <YS0WF0sxr0ysb6Za@mtj.duckdns.org>
 <1f0cd867-9c6d-4e22-cadd-06af9f852f7a@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1f0cd867-9c6d-4e22-cadd-06af9f852f7a@huawei.com>
Precedence: bulk

Hello,

On Tue, Aug 31, 2021 at 03:58:42PM +0800, Zhang Qiao wrote:
> > I think this would allow cgroup migrations to take place before
> > sched_post_fork() is run, which likely will break stuff. The right
> > thing to do likely is taking sched_task_group (and whatever other
> > fields) after cgroup_can_fork(), which fixates the cgroup memberships,
>
> But it still seems possible that it accessed an invalid sched_task_group?
> because the child process does not update its sched_task_group util
> cgroup_post_fork().

Between cgroup_can_fork() and cgroup_post_fork(), the cgroup membership and
thus sched_task_group can't change, so if the child sets it to the parent's
inbetween, the sched_task_group can't go away.

Thanks.

-- 
tejun