Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 1 Sep 2021 02:38:39 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Yang Shi <shy828301@gmail.com>
Cc:     Hugh Dickins <hughd@google.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] mm: khugepaged: don't carry huge page to the next
 loop for !CONFIG_NUMA
Message-ID: <20210831233839.afaenhn32nx6m2fq@box.shutemov.name>
References: <20210817202146.3218-1-shy828301@gmail.com>
 <CAHbLzkpkDXyEZ2izMwpkwLg9fN7qsQ+soR+iu6sd8RfOSqhS-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHbLzkpkDXyEZ2izMwpkwLg9fN7qsQ+soR+iu6sd8RfOSqhS-A@mail.gmail.com>
Precedence: bulk

On Mon, Aug 30, 2021 at 11:49:43AM -0700, Yang Shi wrote:
> Gently ping...
> 
> Does this patch make sense? BTW, I have a couple of other khugepaged
> related patches in my queue. I plan to send them with this patch
> together. It would be great to hear some feedback before resending
> this one.

I don't really care for !NUMA optimization. I believe that most of setups
that benefit from THP has NUMA enabled compile time.

But if you wanna to go this path, make an effort to cleanup other
artifacts for the !NUMA optimization: the ifdef has to be gone and all
callers of these helpers has to be revisited. There's more opportunities to
cleanup. Like it is very odd that khugepaged_prealloc_page() frees the
page.


-- 
 Kirill A. Shutemov