Date: Thu, 07 Dec 2006 00:09:50 -0800 (PST)
Message-Id: <20061207.000950.28414823.davem@davemloft.net>
To: dhowells@redhat.com
CC: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: cmpxchg() in kernel/workqueue.c breaks things
From: David Miller <davem@davemloft.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 818
Lines: 16


David, you have to fix the locking scheme used in kernel/workqueue.c,
you absolutely cannot assume that cmpxchg() is available on all
platforms.  This breaks the build on the platforms that don't
have such an instruction, and no it cannot emulated.

Also, because Alan Cox's machine (zeniv) went down, a few folks such
as Al Viro (CC:'d) had no opportunity to comment on your changes
before they went in.  This mess would have been avoided if Al had a
chance to read over this, in particular since he does cross sparc32
builds he knows that cmpxchg is not available there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/