Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210901023205.5049-1-wanjiabing@vivo.com>
In-Reply-To: <20210901023205.5049-1-wanjiabing@vivo.com>
From:   Geliang Tang <geliangtang@gmail.com>
Date:   Wed, 1 Sep 2021 10:56:22 +0800
Message-ID: <CA+WQbwvjzadxGi2yCs+PRdJpwYnj64jkXdgiYset8oX0PZX6xw@mail.gmail.com>
Subject: Re: [PATCH] mptcp: Fix duplicated argument in protocol.h
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Matthieu Baerts <matthieu.baerts@tessares.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        MPTCP Upstream <mptcp@lists.linux.dev>,
        "To: Phillip Lougher <phillip@squashfs.org.uk>, Andrew Morton
        <akpm@linux-foundation.org>, Kees Cook <keescook@chromium.org>, Coly Li
        <colyli@suse.de>, linux-fsdevel@vger.kernel.org," 
        <linux-kernel@vger.kernel.org>, kael_w@yeah.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jiabing,

Wan Jiabing <wanjiabing@vivo.com> =E4=BA=8E2021=E5=B9=B49=E6=9C=881=E6=97=
=A5=E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=8810:40=E5=86=99=E9=81=93=EF=BC=9A
>
> ./net/mptcp/protocol.h:36:50-73: duplicated argument to & or |
>
> The OPTION_MPTCP_MPJ_SYNACK here is duplicate.
> Here should be OPTION_MPTCP_MPJ_ACK.
>

Good catch!

Acked-by: Geliang Tang <geliangtang@gmail.com>

Please add a Fixes-tag here in v2 like this:

Fixes: 74c7dfbee3e18 ("mptcp: consolidate in_opt sub-options fields in
a bitmask")

Thanks,
-Geliang

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  net/mptcp/protocol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index d7aba1c4dc48..64c9a30e0871 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -34,7 +34,7 @@
>  #define OPTIONS_MPTCP_MPC      (OPTION_MPTCP_MPC_SYN | OPTION_MPTCP_MPC_=
SYNACK | \
>                                  OPTION_MPTCP_MPC_ACK)
>  #define OPTIONS_MPTCP_MPJ      (OPTION_MPTCP_MPJ_SYN | OPTION_MPTCP_MPJ_=
SYNACK | \
> -                                OPTION_MPTCP_MPJ_SYNACK)
> +                                OPTION_MPTCP_MPJ_ACK)
>
>  /* MPTCP option subtypes */
>  #define MPTCPOPT_MP_CAPABLE    0
> --
> 2.25.1
>
>