Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     geert@linux-m68k.org, vbabka@suse.cz, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org
Subject: [RFC PATCH 1/2] lib, stackdepot: check stackdepot handle before accessing slabs.
Date:   Wed,  1 Sep 2021 15:19:13 +1000
Message-Id: <20210901051914.971603-2-imran.f.khan@oracle.com>
In-Reply-To: <20210901051914.971603-1-imran.f.khan@oracle.com>
References: <20210901051914.971603-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (110.33.47.182) by SYYP282CA0014.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:b4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20 via Frontend Transport; Wed, 1 Sep 2021 05:19:27 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4a36f81d-bf42-4e05-91ee-08d96d081291
X-MS-TrafficTypeDiagnostic: CO1PR10MB4691:
X-Microsoft-Antispam-PRVS: <CO1PR10MB46913505FF5C666E49BA20A5B0CD9@CO1PR10MB4691.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CQPNTxhZkZxL6b27y4qjmT5A/gDLvydmoAZ9ualJejWk7sz+k4T9+13V09H2anMaDEFncKeTeQX5BxT/9v+puaCu120+BJ6u9/Zz4CdivEaU0FO5uyMZP2v1jJqeRBB4vYSCtzOzIoIJUW5GFUWGisGbV6l7e4Y79tk50datT2AjFc+HjrOOjYxnVE4sCczmHs5OJK77rGpEJYKRxCEXxCVa0FWZEalG46A4Gzi9Ft7WbI7LS8dSUYy+5K3PDKDkYlB4fxLaSsHVRX8oTHK3vmlFS34fi34WrB9cbXrySsJS40ATGfbAojZdGFxp5zE0taeaiGJjeLfoDflumjHlnKBpC4Y1P3D1fOHIulfCDxDwtLJd/MXuLhTHHckCEy4fgr7CuRg7jxR+KsYAFy7ibQQ2wL2sbyrueR473gl3jK7Ve6TTQzC6PYDNyTrRiiuel2VDATX5NcCsJ5WNHLwiA7EHAJeZrHWM2EE3DrO4O4d9tqpZdV+yaW0wo+hAu29zGZtvYUgAsN51kciI72SJluKPtsEDzBEqXGzGQRU/o8DhPBsL5dpKJeRW8PhuC0iRQryxGuO98CCCPezbhz+c6EYA2W/0WExgXbiNnLiZXHEmSmkAFqt87uEo5HvZrbQDeoickqdg4BGiuUyH4GttL0xbp6La57rmnsxRzalAKYxtsNN3ljNen7+A6XNbPw74IDJsVj1Vlp7YhD2vb5zKkQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4468.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(38350700002)(66476007)(66556008)(36756003)(86362001)(186003)(5660300002)(2906002)(508600001)(1076003)(6512007)(956004)(6666004)(8936002)(83380400001)(316002)(2616005)(4326008)(52116002)(26005)(6506007)(66946007)(6486002)(103116003)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kBKnuAGUm9XX34NFIjGZ13eKQWojSSqOd3et9nZ3Mw7/UFt1v6iH37A2ocen?=
 =?us-ascii?Q?MFu9yPmcIV+AEq82hpI90TQRo4fdHCRsaxgHrIhiBzB+NMMwRxDTqa3kyuk0?=
 =?us-ascii?Q?6BOOdO23/88WmPG8c3tpm9LL+iGCo5FsL+18SOT3DmdvBfhmZFLE0wJZ2sSD?=
 =?us-ascii?Q?3xq2+7brkBozgk9+3Hkaq6v3g0a/cBbsrCmpp5C8sMSaiichtdmQLKvQ0r0q?=
 =?us-ascii?Q?f7TR9G4OKaM9fGl88PErpKFyAQgmtQ01DewubcB/VsIZO/pwH01PiHHiAiyD?=
 =?us-ascii?Q?ZC+OagXGqEqGF94pWy0IYUrv81boTK6ZBPrL/Lt9+DP1GygT2xffPqV23Kch?=
 =?us-ascii?Q?82Y0vXPvxcnNAXdbZSOCR5H+hN2nFjPY1t8+ym8VZYmRKg0nLArnhOTiZmmO?=
 =?us-ascii?Q?YA28M5js0eQon8ug7YQrKL5rTxIs1JfQPEQjO82C1LVNwia24fT8BKZdIGKA?=
 =?us-ascii?Q?0ROjzGZG38hxxtwbBv+q8e5WI83G3bJxJkp1IhI6x5Kke+SNivjtf0kVuB4s?=
 =?us-ascii?Q?hKW/GZKFRHOwtBBAG7PnRTxZEbKqGK1zvWjJY3Cz/E45/Ly5yz2B7+RMfyQw?=
 =?us-ascii?Q?eciNz4YSXB7Js4xfbUKg42CToYZh/dn5LSlKBOZJrlJF9TbtIhU5gc4TIR/e?=
 =?us-ascii?Q?Ygn0VBdJhg8Yv8eKGZlRt7CT3dqsCILCKRSIDdgIDrGzm/HCtlaMQptZ8yFj?=
 =?us-ascii?Q?6vD11ciG8swC2tBf5rU79FAx9nqyjXzlqVV6alX6PpExAErQIIsibGGWBdrz?=
 =?us-ascii?Q?lqjn/E9wORYz+LZajZjGT4qplXYCRv2Pix1kq7Q201fMDW0dVKn6c0h5ttER?=
 =?us-ascii?Q?WdtFpvxZLms/rF4JdK0XmC1NaqO+HN/9WCkd0LoZz9IcS3ntJXwEeR+53Ops?=
 =?us-ascii?Q?pC0G95VE5sdMoK9HtSqM20kLQbrHv/7KdBLXMsWHTJrOwetXefw+igBnU1en?=
 =?us-ascii?Q?hSETpYBzHn++GBxWFjzwDn1ILGnVZnJIYpi3QKL5FuKVnOCNs/xZsjUE53Gy?=
 =?us-ascii?Q?nQMoptp3WL7eAhR78u9sUSxYqoLlIAbtijJoX3MEnl+7RWKWS9NOcSZTK+Pe?=
 =?us-ascii?Q?dFyCktmXjzWogpgdWX5P0LVdK0lUjU+zKGjXE6syd7emPb4hd2hypY5eeIwS?=
 =?us-ascii?Q?cns/cPcPVjV8VPoJuRjje1sOR4QWckSLawzwRTkh+QZebxOCz3TWK2sztLCm?=
 =?us-ascii?Q?swjxLgQD4DhQDKy6quuk5T+AvcMgQf7kHw5njOtVpArLv+mheFMhNXEhebTr?=
 =?us-ascii?Q?ClDafRk3HOriQNWbKuNZkAW5PAhUNhxy9yUKzFp6LbAfLtXuGzvA75H1lLOu?=
 =?us-ascii?Q?BmbHRMctd3MZuf1nurqNMGc0?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a36f81d-bf42-4e05-91ee-08d96d081291
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 05:19:28.9855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /AxQdss1KMZm63OknE81rEIy9tOxfB5dwazWYue9Jrd7milRiW+j5iVhvGTAEnQcqIaEF/e63UjWBx86PTfBFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4691
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10093 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 spamscore=0 mlxlogscore=984 adultscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2109010028
X-Proofpoint-ORIG-GUID: NdpB_giCvMDlSOHM91cLouFCPN902inm
X-Proofpoint-GUID: NdpB_giCvMDlSOHM91cLouFCPN902inm
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

stack_depot_save allocates slabs that will be used for storing
objects in future.If this slab allocation fails we may get to
a situation where space allocation for a new stack_record fails,
causing stack_depot_save to return 0 as handle.
If user of this handle ends up invoking stack_depot_fetch with
this handle value, current implementation of stack_depot_fetch
will end up using slab from wrong index.
To avoid this check handle value at the beginning.
Also issue a warning for nil handle values and when slab allocation
for stackdepot fails for the first time.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>
---
 lib/stackdepot.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 0a2e417f83cb..1d42ef9ef766 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -232,6 +232,10 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 	struct stack_record *stack;
 
 	*entries = NULL;
+	if (!handle) {
+		WARN(1, "stack depot handle is absent.\n");
+		return 0;
+	}
 	if (parts.slabindex > depot_index) {
 		WARN(1, "slab index %d out of bounds (%d) for stack id %08x\n",
 			parts.slabindex, depot_index, handle);
@@ -303,6 +307,8 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries,
 		page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER);
 		if (page)
 			prealloc = page_address(page);
+		else
+			WARN_ONCE(1, "slab allocation for stack depot failed.\n");
 	}
 
 	raw_spin_lock_irqsave(&depot_lock, flags);
-- 
2.30.2