Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <18995b9913c9acb7880b01a4f61ee5d0@codeaurora.org>
References: <1629983731-10595-1-git-send-email-rajpat@codeaurora.org>
 <1629983731-10595-7-git-send-email-rajpat@codeaurora.org> <CAE-0n51YGqp701EzUs1Q1PG89SECVQDdUPsiJ8P95xFj0UFs=A@mail.gmail.com>
 <18995b9913c9acb7880b01a4f61ee5d0@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.9.1
Date:   Tue, 31 Aug 2021 22:04:40 -0700
Message-ID: <CAE-0n516KfBJWeZ_nG8C34xPLHohWTXw9sOFbt2HjRBA1uULmQ@mail.gmail.com>
Subject: Re: [PATCH V6 6/7] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes
To:     rajpat@codeaurora.org
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, rnayak@codeaurora.org,
        saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com,
        skakit@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting rajpat@codeaurora.org (2021-08-31 08:28:51)
> On 2021-08-26 23:41, Stephen Boyd wrote:
> > Quoting Rajesh Patil (2021-08-26 06:15:30)
> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> index 7c106c0..65126a7 100644
> >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> @@ -225,6 +225,10 @@
> >>         status = "okay";
> >>  };
> >>
> >> +&qupv3_id_1 {
> >> +       status = "okay";
> >> +};
> >> +
> >
> > Why enable this here but not any of the i2c/spi/uart devices that are a
> > child? Can this hunk be split off to a different patch?
> >
>
> Currently there is no usecase on qup1 and hence not enabled.
> Regarding splitting this, I did not get the exact reason why we need to
> split. This patch adds all the qup wrapper1 nodes and we are enabling it
> in board file.

I'm happy to see this part dropped from the patch. If nothing is enabled
that's a child of the qup then enabling it serves no purpose.