Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp309145pxb; Tue, 31 Aug 2021 22:34:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7p0mmmjzTNgR5TSD673Fpnoptm5HjN20Deh+qB01FKLOUQP8vS4IH4JFjmS44b01ZR1PN X-Received: by 2002:a05:6e02:214e:: with SMTP id d14mr23351330ilv.142.1630474483179; Tue, 31 Aug 2021 22:34:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630474483; cv=none; d=google.com; s=arc-20160816; b=HN6dKMd64o+ezzoV6zqiRtnS1tA799uq+dcJ5e0UYB+KLu9oDUF9FE1GRh3clZLFHx Rnmw2SEyq6Q9X2vrTwiBjDUJAmKTljZzvKLE9u2k15Jk3yI5HLyy6FOHIkGvLPO8NNFk rsmeKfTMD2HGwElZWiMiqS0HCpK3T49mRrzfbGu0vMvmv6hz/5SUkGmE4Rd1VsqA6HJY wm9KkMKN2PlRJRhjfruOxmlQPsJh5leROpXT8PAnpltxyLTilv6O9cZ0OlQASKuR4mTM Dv7JFRoPHB6BnoB73BkSjM0PcXwIhpF4BovXspdy+WJ8FRLxkWLQPeF110AxaJ2e53k6 ClWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=N2WVEhIn7g2xqwLHjd0/oieAY8b22yKtkcYybi7KwlY=; b=fAvx0cG2ZeMJIp0YZo7zPUnxJA9fjhHetCjRodKrXKeUPcaQStNak5U4jC1gbJqtaK ZWC94RlpQFAFMQBP6uJiQeIBIsW5X53Xzik+4w2BFA8EVl9Ox7M/390mfiCWmoSaji+r tBMkiFqE5on8lcReOHyY10XkodU8lu/Lu/vgr6zMwrtra03o6JVwwPrr+T1NLNCQvfAO 3MIBATMJmPqroNkD1j0g/Tf6K7c974Vq+P8rNl5nYMoM+qrEiNGF6WOtTf6KlDUU1x8a Zor5My/Cfkbn2Ongz6fFSoUKG6SQRvF+0RUYlenHcFvySBV7a5LIz6YQlqEuJXi9ro8t luyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W+VmqvrM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n123si26908245iof.15.2021.08.31.22.34.31; Tue, 31 Aug 2021 22:34:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W+VmqvrM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242002AbhIAFdS (ORCPT + 99 others); Wed, 1 Sep 2021 01:33:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:33294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241980AbhIAFdS (ORCPT ); Wed, 1 Sep 2021 01:33:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BCB346101A; Wed, 1 Sep 2021 05:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630474341; bh=N2WVEhIn7g2xqwLHjd0/oieAY8b22yKtkcYybi7KwlY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=W+VmqvrMQZfk8rutotH03eYCURAchYuizk2DK9nQxPm+pg+z9Kk5zUR6IzSdMHlv2 XU5A8i272PxI5WC+5fIYqptS9g43rvC52wgkbzF9mDgvV0Pk/5Cluk0QKs0B0fMjIp ACcRIncd9SjSso/34CiWix2MnxjY39LB/VZqHhuabJqpQilH0MiQG+nr4RW9Vm8jrP do5V5Su8v9Ch8p50pGDf1CLqzcxRE9Zum/fWoo/8IqmlYN2U0WeYjzX+jwvv157vb/ 0GhNNmFkw9KQDYbxMWXKfkrSlbND4atg8V1DdqAaE7AU3mz3VrY0GGNoW3/1PZ2D3C T4j6ToIqvt8WQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1630348984.24981.2.camel@mtkswgap22> References: <20210813032429.14715-1-miles.chen@mediatek.com> <20210813032429.14715-4-miles.chen@mediatek.com> <163021049667.2676726.10138202396240942833@swboyd.mtv.corp.google.com> <1630348984.24981.2.camel@mtkswgap22> Subject: Re: [RESEND PATCH 3/4] clk: mediatek: support COMMON_CLK_MT6779 module build From: Stephen Boyd Cc: Matthias Brugger , Michael Turquette , Wendell Lin , Hanks Chen , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Lee Jones To: Miles Chen Date: Tue, 31 Aug 2021 22:32:20 -0700 Message-ID: <163047434049.42057.5688419707288938766@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Miles Chen (2021-08-30 11:43:04) >=20 > sorry for my late response.=20 >=20 > Thanks for pointing this out. I have the same question when I was > building this patch. That time I found some examples where > they are using builtin_platform_driver and can be built as=20 > kernel modules: >=20 > config CLK_IMX8QXP (tristate) && drivers/clk/imx/clk-imx8qxp-lpcg.c > config CLK_RK3399 (tristate) && drivers/clk/rockchip/clk-rk3399.c We should fix those drivers. Care to send a patch?