Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp514244pxb; Wed, 1 Sep 2021 04:15:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4PZsKYdgT31sExhIuJ3h/2asTgEKudkSJJHXtHhlZsX8mXdjBMdQE1a4yrqvft9UPBsZa X-Received: by 2002:a50:998c:: with SMTP id m12mr30422649edb.327.1630494899919; Wed, 01 Sep 2021 04:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630494899; cv=none; d=google.com; s=arc-20160816; b=Bu7xTPU6Ku2spqHiN10NhS2HFqc7aKCjEBTMHvSm0eQGLBRRFtB6MaL9SCsBEvoAgH kdcF3LQ8wYegzjCj8J848nCtidgI1c/luG/FEUDRF0Hbx/o9XdgdyK9Xg7XBI5NoqxYz Mm9mslVAgVraFnLwOueZD0+6c4fLSOJDIaX8BTpShGBJeyGcG5EJlz+nDps4MoiR8rwZ BVg0D2rRp0tyuaZXMfOdvpvUXSKGcA2GYV7x5EOyRgbzY0S8Akf0JhoAVI4BWJB4+33y dGfSE5PW0x2KcpNNJF3qKNB/LGfeFHLYhW2o+wqK8vujaWW40UJZDPGcbGXv9WfETu/Y iX9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:reply-to:references:cc:to:subject:dkim-signature; bh=tow+I00w/W7MlNLoNIe8l0S+bKESvYH+X3hshRUdhzA=; b=jXuizN0JIw+dF1S7BU8HgeBCf0M2DoE2zJ8YG7vfN0lS2NSmXWH3ONs6MX5+Wq+btt lKfFg5VbrfxfDPbWkleieR8zG53WJ4vdLKlZ6/ya8MXmWqKmmiPF9pXgmgxR4rH6ZExn b6YfmYywntp1nV1rvunH1UVJsK7W8r1xmk0p3cJPc1KhjKSXy5ynLHJtzDwjNjdL3baG xiOnuPIW3cIs714+sJeqv8o7LitxQUZif5f85zNAw6U8THkKJyzLyX9kiA+E2Imov4pC PRqE6hAapkQ3PjQSdVi6yCFRh68U1fRSfhmv+nK9des58MmRrGCsx7MVVkPVWkO/DDzX Ikmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=OfQ6dMjJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de36si24560193ejc.582.2021.09.01.04.13.55; Wed, 01 Sep 2021 04:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=OfQ6dMjJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237548AbhIALGw (ORCPT + 99 others); Wed, 1 Sep 2021 07:06:52 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:45408 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232095AbhIALGv (ORCPT ); Wed, 1 Sep 2021 07:06:51 -0400 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 894C63D7; Wed, 1 Sep 2021 13:05:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630494353; bh=vBL3hgmAfgvTySdTKjIKgHFeX3apchXm9QXRGcsZJeU=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=OfQ6dMjJ4ur72ixmAwxAta9gxWEdrPpnDcndVQkpYuzs1hI4RkqR2qJRdmHsQ+G0e I0Ec+z9w92ZPxvYAF+nJi239VOS0JGpjutl0km+kxPDXckpTeiWzjpL2O2/5ZR4juw yk/Nf9arv4YxgduSgU2e9Y5RIySOXkeks0hZAClg= Subject: Re: [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource() To: Cai Huoqing Cc: Jacopo Mondi , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210901055540.7479-1-caihuoqing@baidu.com> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Wed, 1 Sep 2021 12:05:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901055540.7479-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2021 06:55, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Reviewed-by: Kieran Bingham > --- > drivers/media/platform/renesas-ceu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c > index 9376eb363748..2e8dbacc414e 100644 > --- a/drivers/media/platform/renesas-ceu.c > +++ b/drivers/media/platform/renesas-ceu.c > @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > const struct ceu_data *ceu_data; > struct ceu_device *ceudev; > - struct resource *res; > unsigned int irq; > int num_subdevs; > int ret; > @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev) > spin_lock_init(&ceudev->lock); > mutex_init(&ceudev->mlock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ceudev->base = devm_ioremap_resource(dev, res); > + ceudev->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ceudev->base)) { > ret = PTR_ERR(ceudev->base); > goto error_free_ceudev; >