Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031943AbWLGKaP (ORCPT ); Thu, 7 Dec 2006 05:30:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031993AbWLGKaP (ORCPT ); Thu, 7 Dec 2006 05:30:15 -0500 Received: from mx1.redhat.com ([66.187.233.31]:43826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031943AbWLGKaM (ORCPT ); Thu, 7 Dec 2006 05:30:12 -0500 From: David Howells In-Reply-To: <20061206234942.79d6db01.akpm@osdl.org> References: <20061206234942.79d6db01.akpm@osdl.org> <1165125055.5320.14.camel@gullible> <20061203011625.60268114.akpm@osdl.org> <20061205123958.497a7bd6.akpm@osdl.org> <6FD5FD7A-4CC2-481A-BC87-B869F045B347@freescale.com> <20061205132643.d16db23b.akpm@osdl.org> <20061205135753.9c3844f8.akpm@osdl.org> <20061206075729.b2b6aa52.akpm@osdl.org> <20061206224207.8a8335ee.akpm@osdl.org> To: Andrew Morton Cc: Linus Torvalds , David Howells , "Maciej W. Rozycki" , Roland Dreier , Andy Fleming , Ben Collins , Linux Kernel Mailing List , Jeff Garzik Subject: Re: [PATCH] Export current_is_keventd() for libphy X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Thu, 07 Dec 2006 10:29:39 +0000 Message-ID: <9392.1165487379@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 958 Lines: 22 Andrew Morton wrote: > I guess I don't understand exactly what problem the noautorel stuff is > trying to solve. It _seems_ to me that in all cases we can simply stuff > the old `data' field in alongside the controlling work_struct or > delayed_work which wants to operate on it. The problem is that you have to be able to guarantee that the data is still accessible once you clear the pending bit. The pending bit is your only guaranteed protection, and once it is clear, the containing structure might be deallocated. I would like to be able to get rid of the NAR bit too, but I'm not confident that in all cases I can. It'll take a bit more study of the code to be able to do that. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/