Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To:     Cai Huoqing <caihuoqing@baidu.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4] media: rcar_drif: Make use of the helper function
 devm_platform_get_and_ioremap_resource()
Thread-Topic: [PATCH v4] media: rcar_drif: Make use of the helper function
 devm_platform_get_and_ioremap_resource()
Thread-Index: AQHXnybRQySgKZeXfU+x4i7f1u7r7auPGY6w
Date:   Wed, 1 Sep 2021 12:22:40 +0000
Message-ID: <OSAPR01MB2737C7CCB159F768EDA12ACDC2CD9@OSAPR01MB2737.jpnprd01.prod.outlook.com>
References: <20210901114459.31493-1-caihuoqing@baidu.com>
In-Reply-To: <20210901114459.31493-1-caihuoqing@baidu.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OZbLvKEly1bkOElUUXJjhSmlXhWaLt+mnEXTz1nKwGW0arpckesPPN5x74iX?=
 =?us-ascii?Q?Y8YJdaCI/GR4Qqj0kVS+7PoDQZDasr5kcSOPqG2xOBBGJslVNeq1qirM4fR1?=
 =?us-ascii?Q?E7Oa3IanibCydPsEVhsx8p5gEj3hQPuZvj2v2fPOBRo+NuTyZ3IEJqALYnqQ?=
 =?us-ascii?Q?dMPTwGd0XB6jOFfQOm10slU+cofOVu0Jcz1Maelx0IZSXe1rEgWDceTtqoeN?=
 =?us-ascii?Q?mysvikB4g/VKqROUS7c9vXHd4y9n/r4XRqabQVNfr79xKbiPyL/RJMRLnQRp?=
 =?us-ascii?Q?ju1UYPp51Gn2kSYGB64cIs1JEgMonQJG5EPWQoR8s44pOKoYLJmwukPrPnFL?=
 =?us-ascii?Q?d062fSD01t5P+GLeE/ILUPm1rZdII/Eej7PpQTEkHGBauOcD7bCS6A2UAxyU?=
 =?us-ascii?Q?jQoZIvkSpbx0UU1ngr1gbkuSiKV0oehNUxQwIZcoKcFfMMcFGetLVrERnv8U?=
 =?us-ascii?Q?l/JmNZ1x1dRHVIodRpBIwAZgoDgh67CIZHKxr+PO9zis1gEdGu5eGuoaE8B2?=
 =?us-ascii?Q?fMNlHsj6gwBLUnbP7EZ8W9C78FyPbzWgjnQMxcZgoQ6bF/B2YZGN8apmtHwL?=
 =?us-ascii?Q?lo7+C/WEs70bLaezIS1EQsSGHhz2cCA1dMlNBoYkjO/Se3e+vLjS5t3NXPmE?=
 =?us-ascii?Q?/tFlbFh8G2naqD/YPAySvTITuP4JM+wDB2lNNa+2OB9GD3cNhgjktXr6gKpI?=
 =?us-ascii?Q?DqAW2PKEUeveds2DTuk9PktKaVDTRlfrlnE/B/kxsGKAvAqhhzCLzp19f6aG?=
 =?us-ascii?Q?/lpt1Z2uQtWLK+Umaz4ERFxpep6wDdptV1oT4jf8j3NZWG3cZQ7d41iX+uKW?=
 =?us-ascii?Q?7Ozx07kCOU3x0ubwtv8bkhQ7CqrrFGHvNuZz8zAH3GvlA1eFA+P1RGFS+yfR?=
 =?us-ascii?Q?Ch+glKHITbK+BcpMkplOdfZuqlFwVPfAQjSwgRBbWQTdVky9InBF6npFW+gF?=
 =?us-ascii?Q?KmN+J1i7ejCw7wsatBRvvH3Z2cwp8CCQLo/hBYZefvgc4sfhcCxNGMRg6A6X?=
 =?us-ascii?Q?uZuIxAwiH9JhlhBH4Ult7OVNgKPHFuwUjlnZJ2xG9k6BG6fMjCRcxAzIvd5D?=
 =?us-ascii?Q?lpAn2Ve955AWT6V1gZWDKSuCuuBSrU8m2NMk/MF5hFpBS3CJiL51/dy7JxTc?=
 =?us-ascii?Q?vJNDrWMqHhp8udsmasbFXWx0eNvAaTnYN82fi0WxBu3UZ9kfi4o1E1Kkv0iu?=
 =?us-ascii?Q?Jedb/5LtrfjCoRriqyhg8WixG7l88SiSNZSrX4VTdtN1dMLeLZPuwumLSDDh?=
 =?us-ascii?Q?v/WUrlsTw8D/TZ17q/ynwjR4PdqepZ4CPQjgzyKyHaZSUAsB3wjHKfLgh6+t?=
 =?us-ascii?Q?IRWNKYyWKHpN+/Bv2JJ67dWi?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB2737.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de924f34-ae78-4fcd-0a97-08d96d433193
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 12:22:40.9613
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4cUB7vu3Ihm5S3CNgGJM/kY+co7czf6HqUbHt2k3CVIZWJml4p/lNoIXFltn7gS49yn8eGothBGyzFW4g85dRJAuj8+aBV3XfIgfZAXSWic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB2737
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Cai Huoqing <caihuoqing@baidu.com>
> Sent: 01 September 2021 12:45
> To: caihuoqing@baidu.com
> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>; linux-media@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v4] media: rcar_drif: Make use of the helper function
> devm_platform_get_and_ioremap_resource()
>=20
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
>=20
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>=20
>  drivers/media/platform/rcar_drif.c | 3 +--
>  1 file changed, 1 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/media/platform/rcar_drif.c
> b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device
> *pdev)
>  	}
>=20
>  	/* Register map */
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ch->base =3D devm_ioremap_resource(&pdev->dev, res);
> +	ch->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(ch->base))
>  		return PTR_ERR(ch->base);
>=20
> --
> 2.25.1