Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 1 Sep 2021 06:45:06 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Zhang Qiao <zhangqiao22@huawei.com>
Cc:     peterz@infradead.org, juri.lelli@redhat.com,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        vincent.guittot@linaro.org
Subject: Re: [PATCH] kernel/sched: Fix sched_fork() access an invalid
 sched_task_group
Message-ID: <YS+uEmQRmQqAbkmG@slm.duckdns.org>
References: <20210826112635.7404-1-zhangqiao22@huawei.com>
 <YSztujInfNNXkG5/@hirez.programming.kicks-ass.net>
 <YS0WF0sxr0ysb6Za@mtj.duckdns.org>
 <1f0cd867-9c6d-4e22-cadd-06af9f852f7a@huawei.com>
 <YS60T2bfLpxb6SUY@slm.duckdns.org>
 <128d52ab-b4ee-65f8-e0a3-2796ef43a98b@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <128d52ab-b4ee-65f8-e0a3-2796ef43a98b@huawei.com>
Precedence: bulk

Hello,

On Wed, Sep 01, 2021 at 03:43:00PM +0800, Zhang Qiao wrote:
> 在 2021/9/1 6:59, Tejun Heo 写道:
> > On Tue, Aug 31, 2021 at 03:58:42PM +0800, Zhang Qiao wrote:
> >>> I think this would allow cgroup migrations to take place before
> >>> sched_post_fork() is run, which likely will break stuff. The right
> 
> cgroup migrations? Do you mean child process set its cgroups at
> cgroup_subsys->fork()?

As soon as cgroup_post_fork() is complete, userspace can try moving the
process to a different cgroup which can get confusing for sched_post_fork.

> > Between cgroup_can_fork() and cgroup_post_fork(), the cgroup membership and
> > thus sched_task_group can't change, so if the child sets it to the parent's
> > inbetween, the sched_task_group can't go away.
> 
> so the child just need to update its sched_task_group after cgroup_can_fork(),
> then call sched_fork(), is it right?

Yeah, the bug here is that a field which is dependent on cgroup membership
is being read before the cgroup membership is fixated.

Thanks.

-- 
tejun