Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1630513111-18776-1-git-send-email-spujar@nvidia.com> <1630513111-18776-3-git-send-email-spujar@nvidia.com>
In-Reply-To: <1630513111-18776-3-git-send-email-spujar@nvidia.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 1 Sep 2021 11:58:40 -0500
Message-ID: <CAL_JsqJgqyGGF=SwEox6LkR_P8AR+c30AWNejA6UiCCh+U55Pg@mail.gmail.com>
Subject: Re: [PATCH 2/3] ASoC: Use schema reference for sound-name-prefix
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Jerome Brunet <jbrunet@baylibre.com>,
        aleandre.belloni@bootlin.com,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-tegra <linux-tegra@vger.kernel.org>,
        Bard Liao <bardliao@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 1, 2021 at 11:19 AM Sameer Pujar <spujar@nvidia.com> wrote:
>
> Use schema reference for 'sound-name-prefix' property wherever
> necessary.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Cc: bardliao@realtek.com
> Cc: Alexandre Belloni <aleandre.belloni@bootlin.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
>  Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +------
>  Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +------
>  Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml  | 7 +------
>  Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml          | 5 +----
>  Documentation/devicetree/bindings/sound/rt5659.txt                | 2 +-
>  Documentation/devicetree/bindings/sound/simple-audio-mux.yaml     | 5 +----
>  6 files changed, 6 insertions(+), 27 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> index 5f6b37c..ae04a11 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> @@ -48,12 +48,7 @@ properties:
>
>    sound-name-prefix:
>      pattern: "^DSPK[1-9]$"
> -    $ref: /schemas/types.yaml#/definitions/string
> -    description:
> -      Used as prefix for sink/source names of the component. Must be a
> -      unique string among multiple instances of the same component.
> -      The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> -      available instances on a Tegra SoC.
> +    $ref: "name-prefix.yaml#/properties/sound-name-prefix"

This is generally not how we reference common properties.

Either you add a $ref to the whole schema document at the top level of
this one or add a 'select: true' in name-prefix.yaml.

Rob